Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5482060yba; Mon, 13 May 2019 11:35:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqySYPbZhjqM8tzDNLTjSHztlIer4ZQtfnCWZM0yvux1bT2XLyuhLUG3AEBgCLb3yzJbXF6s X-Received: by 2002:a65:4c07:: with SMTP id u7mr32060408pgq.93.1557772528163; Mon, 13 May 2019 11:35:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557772528; cv=none; d=google.com; s=arc-20160816; b=i06MjlQJSOFipV1T+2NZ/oCiuW04TbOZvRgeQCWJbh250wepg7sM8zWGtREWOj34Iu GvRm9xpg75Uc7whF8KxkA5xWT6j8HChwscCWYeKuXiJAOtBspT+brSm+fZZiCZAgK5tt uNyl1t6wsgtYZiU+O44m2DmiwoF1imz+kON/R+HcxxIV3D4UQhljI/GgEXCl/3+2d30f WhY9CYZ2JMKAzMS9By3lEqNKBUAFJoEVnceJzpQbcXh6ApwlI8N2oa3VZPmtAnS4tkRH tNUh4GPf7gDwoQnbP2IycdTsp9qbZ/4Mf9gKykgGoxpR9SFVHMAa4qvx7ndvLSeRSxU2 yElg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=YI4apKyiwzoFZU9dVSAV6s8pxksTddQsWQQ+ARnfARM=; b=vd8qLSIorb1W2jOFJ2BXnGRaTSpKBC7p8uGek41N+riDAdYHLzbbEE3V1ZWsktyuF0 UnhfjA0DR4yETm4OWS8MkO1sADGvQjgWsjtonEWqDXhOmt/38Z2ccsDtO8+z+Lzy+8zf AYyrIxy9e/zsSmRDKG8wRrUPSRENy1jqWLM1l27vU3+y0Y/tM9UNfi6EBTuzhrGYBa2f fBJ9HWHJdHioDRqRM6N+XEY1HpPSUsibA8TTHgbEHCfdasL+N71PIbM/4K2xDBlJCD9C hN+Hg1SmeXVZwFRLOYX0yBE07mHEzllS/VpKD3HVs9nhAB18LaPxQz5IiuyLHfcuCen2 6XcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JBtb+af4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e3si18818863pfa.155.2019.05.13.11.35.12; Mon, 13 May 2019 11:35:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JBtb+af4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730235AbfEMPAE (ORCPT + 99 others); Mon, 13 May 2019 11:00:04 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:46884 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728381AbfEMPAE (ORCPT ); Mon, 13 May 2019 11:00:04 -0400 Received: by mail-pf1-f195.google.com with SMTP id y11so7334358pfm.13 for ; Mon, 13 May 2019 08:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YI4apKyiwzoFZU9dVSAV6s8pxksTddQsWQQ+ARnfARM=; b=JBtb+af429BMLQX05LwJk8JyOCUcuisqVMvds2IepDPWQ4T7iQPRmjoxCt+OzbTyZA 0OzkFc8aVQDvX8kZDPvpWf4bCLcg3KesiorRr38oxdLqSD+B00cwewrGLz62bHlIpKUc TMCN7hCmIYAe3sIpuihGBXXQgciC2o59CibnfIgrDHmFQn4vD/G9H5OiXqA5XRCj2QDS 9X7aU7C35jI+R16YqXYqvNvuF0VcbkLTK5kAgod/EdCsJVluWmQsu8HeDr6smtazlAND /pM51IjnI4tDc26JdRz6qjBm71/PeQ5CEFBbgIkiRNe/tNw2h73hJ9XX4WtrJ3xpRXxs WkgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YI4apKyiwzoFZU9dVSAV6s8pxksTddQsWQQ+ARnfARM=; b=rcFjOaW/s+KEHdvDHcnoHa1AhIE3uYesvRZ2Iklu3ogRfeXIg7H/WnSE4E0892q3JC XTBj3G811Fh9zZnWSHU0Yl86eD28zqx3jUBSm12h/VvmTplpNF9ReTwkSQIlbALxN/Yh A4MHGz17V+zEKwTJs2io4S7mrcZVLJD/jLJdt3ac8V04f7dLkX+y5JcUdx5HZG5XMN/R rlmoIi5rsHZTR/pAvipnumu3k/ChVsVUUpVJhOC+HVg+TCqN2635pO4Z/441m4H/oCHJ /e/oBH2mE17iLtPcXpQerm6R3eerhbwuMOaPWu1PfOwhb6s0Jl1zABEYnAYXeouaPWLS gE0Q== X-Gm-Message-State: APjAAAUBLNwOMH9kXqbC763tMMi5dVVFewGbCGuGVOWictuHys67YfNn mO1iMEHxgTRc7DFiY5u0aeFabf4+QSpTmonVEpU= X-Received: by 2002:aa7:9214:: with SMTP id 20mr33381833pfo.202.1557759603675; Mon, 13 May 2019 08:00:03 -0700 (PDT) MIME-Version: 1.0 References: <1557676457-4195-1-git-send-email-akinobu.mita@gmail.com> <1557676457-4195-7-git-send-email-akinobu.mita@gmail.com> <20190513074120epcms2p54e3a031668274ac1ebace6c5edc0a3f7@epcms2p5> In-Reply-To: <20190513074120epcms2p54e3a031668274ac1ebace6c5edc0a3f7@epcms2p5> From: Akinobu Mita Date: Mon, 13 May 2019 23:59:52 +0900 Message-ID: Subject: Re: [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout To: minwoo.im@samsung.com Cc: "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Jens Axboe , Sagi Grimberg , Kenneth Heitke , Keith Busch , Minwoo Im , Johannes Berg , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2019=E5=B9=B45=E6=9C=8813=E6=97=A5(=E6=9C=88) 16:41 Minwoo Im : > > > -static void __maybe_unused nvme_coredump_init(struct nvme_dev *dev); > > -static void __maybe_unused nvme_coredump_logs(struct nvme_dev *dev); > > -static void __maybe_unused nvme_coredump_complete(struct nvme_dev > > *dev); > > +static void nvme_coredump_init(struct nvme_dev *dev); > > +static void nvme_coredump_logs(struct nvme_dev *dev); > > +static void nvme_coredump_complete(struct nvme_dev *dev); > > You just have added those three prototypes in previous patch. Did I miss > something here? These __maybe_unused are needed only in the patch 5/7. Because these functions are still unused before applying patch 6/7.