Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Akinobu Mita <akinobu.mita@gmail.com>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
        Kenneth Heitke <kenneth.heitke@intel.com>,
        Keith Busch <keith.busch@intel.com>,
        Minwoo Im <minwoo.im.dev@gmail.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 4/7] nvme: add basic facility to get telemetry log page
Thread-Topic: [PATCH v3 4/7] nvme: add basic facility to get telemetry log
 page
Thread-Index: AQHVCNsftCzLP1UjZkWS9UhDPRIwqQ==
Date:   Mon, 13 May 2019 15:34:15 +0000
Message-ID: <SN6PR04MB4527A2B52661330D519FD618860F0@SN6PR04MB4527.namprd04.prod.outlook.com>
References: <1557676457-4195-1-git-send-email-akinobu.mita@gmail.com>
 <1557676457-4195-5-git-send-email-akinobu.mita@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c687f9b-f3dd-4b9f-f67d-08d6d7b87534
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2019 15:34:15.8762
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4829
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/12/2019 08:55 AM, Akinobu Mita wrote:=0A=
> This adds the required definisions to get telemetry log page.=0A=
s/definisions/definitions/=0A=
> The telemetry log page structure and identifier are copied from nvme-cli.=
=0A=
>=0A=
> We also need a facility to check log page attributes in order to know=0A=
> the controller supports the telemetry log pages and log page offset field=
=0A=
> for the Get Log Page command.  The telemetry data area could be larger=0A=
> than maximum data transfer size, so we may need to split into multiple=0A=
> transfers with incremental page offset.=0A=
>=0A=
> Cc: Johannes Berg <johannes@sipsolutions.net>=0A=
> Cc: Keith Busch <keith.busch@intel.com>=0A=
> Cc: Jens Axboe <axboe@fb.com>=0A=
> Cc: Christoph Hellwig <hch@lst.de>=0A=
> Cc: Sagi Grimberg <sagi@grimberg.me>=0A=
> Cc: Minwoo Im <minwoo.im.dev@gmail.com>=0A=
> Cc: Kenneth Heitke <kenneth.heitke@intel.com>=0A=
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>=0A=
> ---=0A=
> * v3=0A=
> - Merge 'add telemetry log page definisions' patch and 'add facility to=
=0A=
>    check log page attributes' patch=0A=
> - Copy struct nvme_telemetry_log_page_hdr from the latest nvme-cli=0A=
> - Add BUILD_BUG_ON for the size of struct nvme_telemetry_log_page_hdr=0A=
>=0A=
>   drivers/nvme/host/core.c |  2 ++=0A=
>   drivers/nvme/host/nvme.h |  1 +=0A=
>   include/linux/nvme.h     | 17 +++++++++++++++++=0A=
>   3 files changed, 20 insertions(+)=0A=
>=0A=
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c=0A=
> index a6644a2..0cea2a8 100644=0A=
> --- a/drivers/nvme/host/core.c=0A=
> +++ b/drivers/nvme/host/core.c=0A=
> @@ -2585,6 +2585,7 @@ int nvme_init_identify(struct nvme_ctrl *ctrl)=0A=
>   	} else=0A=
>   		ctrl->shutdown_timeout =3D shutdown_timeout;=0A=
>=0A=
> +	ctrl->lpa =3D id->lpa;=0A=
>   	ctrl->npss =3D id->npss;=0A=
>   	ctrl->apsta =3D id->apsta;=0A=
>   	prev_apst_enabled =3D ctrl->apst_enabled;=0A=
> @@ -3898,6 +3899,7 @@ static inline void _nvme_check_size(void)=0A=
>   	BUILD_BUG_ON(sizeof(struct nvme_id_ctrl) !=3D NVME_IDENTIFY_DATA_SIZE)=
;=0A=
>   	BUILD_BUG_ON(sizeof(struct nvme_id_ns) !=3D NVME_IDENTIFY_DATA_SIZE);=
=0A=
>   	BUILD_BUG_ON(sizeof(struct nvme_lba_range_type) !=3D 64);=0A=
> +	BUILD_BUG_ON(sizeof(struct nvme_telemetry_log_page_hdr) !=3D 512);=0A=
>   	BUILD_BUG_ON(sizeof(struct nvme_smart_log) !=3D 512);=0A=
>   	BUILD_BUG_ON(sizeof(struct nvme_dbbuf) !=3D 64);=0A=
>   	BUILD_BUG_ON(sizeof(struct nvme_directive_cmd) !=3D 64);=0A=
> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h=0A=
> index 5ee75b5..7f6f1fc 100644=0A=
> --- a/drivers/nvme/host/nvme.h=0A=
> +++ b/drivers/nvme/host/nvme.h=0A=
> @@ -195,6 +195,7 @@ struct nvme_ctrl {=0A=
>   	u32 vs;=0A=
>   	u32 sgls;=0A=
>   	u16 kas;=0A=
> +	u8 lpa;=0A=
>   	u8 npss;=0A=
>   	u8 apsta;=0A=
>   	u32 oaes;=0A=
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h=0A=
> index c40720c..8c0b29d 100644=0A=
> --- a/include/linux/nvme.h=0A=
> +++ b/include/linux/nvme.h=0A=
> @@ -294,6 +294,8 @@ enum {=0A=
>   	NVME_CTRL_OACS_DIRECTIVES		=3D 1 << 5,=0A=
>   	NVME_CTRL_OACS_DBBUF_SUPP		=3D 1 << 8,=0A=
>   	NVME_CTRL_LPA_CMD_EFFECTS_LOG		=3D 1 << 1,=0A=
> +	NVME_CTRL_LPA_EXTENDED_DATA		=3D 1 << 2,=0A=
> +	NVME_CTRL_LPA_TELEMETRY_LOG		=3D 1 << 3,=0A=
>   };=0A=
>=0A=
>   struct nvme_lbaf {=0A=
> @@ -396,6 +398,20 @@ enum {=0A=
>   	NVME_NIDT_UUID		=3D 0x03,=0A=
>   };=0A=
>=0A=
> +struct nvme_telemetry_log_page_hdr {=0A=
> +	__u8    lpi; /* Log page identifier */=0A=
> +	__u8    rsvd[4];=0A=
> +	__u8    iee_oui[3];=0A=
> +	__le16  dalb1; /* Data area 1 last block */=0A=
> +	__le16  dalb2; /* Data area 2 last block */=0A=
> +	__le16  dalb3; /* Data area 3 last block */=0A=
> +	__u8    rsvd1[368];=0A=
> +	__u8    ctrlavail; /* Controller initiated data avail?*/=0A=
> +	__u8    ctrldgn; /* Controller initiated telemetry Data Gen # */=0A=
> +	__u8    rsnident[128];=0A=
> +	__u8    telemetry_dataarea[0];=0A=
> +};=0A=
> +=0A=
=0A=
nit:- Thanks for adding the comments, can you please align all the above =
=0A=
comments like :-=0A=
=0A=
+struct nvme_telemetry_log_page_hdr {=0A=
+       __u8    lpi;            /* Log page identifier */=0A=
+       __u8    rsvd[4];=0A=
+       __u8    iee_oui[3];=0A=
+       __le16  dalb1;          /* Data area 1 last block */=0A=
+       __le16  dalb2;          /* Data area 2 last block */=0A=
+       __le16  dalb3;          /* Data area 3 last block */=0A=
+       __u8    rsvd1[368];=0A=
+       __u8    ctrlavail;      /* Controller initiated data avail?*/=0A=
+       __u8    ctrldgn;        /* Controller initiated telemetry Data =0A=
Gen # */=0A=
+       __u8    rsnident[128];=0A=
+       __u8    telemetry_dataarea[0];=0A=
+};=0A=
+=0A=
=0A=
=0A=
>   struct nvme_smart_log {=0A=
>   	__u8			critical_warning;=0A=
>   	__u8			temperature[2];=0A=
> @@ -832,6 +848,7 @@ enum {=0A=
>   	NVME_LOG_FW_SLOT	=3D 0x03,=0A=
>   	NVME_LOG_CHANGED_NS	=3D 0x04,=0A=
>   	NVME_LOG_CMD_EFFECTS	=3D 0x05,=0A=
> +	NVME_LOG_TELEMETRY_CTRL	=3D 0x08,=0A=
>   	NVME_LOG_ANA		=3D 0x0c,=0A=
>   	NVME_LOG_DISC		=3D 0x70,=0A=
>   	NVME_LOG_RESERVATION	=3D 0x80,=0A=
>=0A=
=0A=