Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5530295yba; Mon, 13 May 2019 12:29:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqx5Z6ZPtNSlK3JKHpccfGa8DgoDb3Svlpe/TCmn7YEb0u1Hj4aZ1uQZMy1Xm0I4zVF5E73X X-Received: by 2002:a62:7513:: with SMTP id q19mr35887609pfc.108.1557775787035; Mon, 13 May 2019 12:29:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557775787; cv=none; d=google.com; s=arc-20160816; b=1AglxFQdrJUx2DXM3Ey+ZRnSPl1tE+zXPChTZTG09DhRvdxMPTuM+ahCNdExomK554 MejPvrkFeKIUZfLPeskj5ieZXO3cE9Vvyb5UX7DcoMtUD4PFtzik3nfcvh5vCif644zn FgkzSRB+d5NoI4bXgVXb7ZIBwbzmNFVLB9AH3NxaeKkn3mT7apEdYspODBCZ9v78g8fn pvWKloMk7nT8t6rAFba4/hNl00gcdU7aVQ8I+wVQtonOhgv3cigu4TrfOcibdheTq9+P cUW7eKnqZxNIj1/3vMeWcD/KtvznHXo+eEwJYD+WMvdilxYUF60Om/ETSVy7xyOEOqzs WULQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=rRX4P43X1k/JI7ai/8EwAiwnCUdoSu2K3ItqlEhUbLA=; b=MR9fXLulAh43zvFIeWHP/Juuis/cH5HviBlnXSrtmIV1xnQrfO6EjRuSHU7apBXSIT +a0DMk9H3cudvOmcvgsRjiRAUpx2e3dPkbJcS/RsnM3BLNbEMB6upXweq5z9pOPvev8H W7WKdCdRJRUIwoKKFSuBNq34igoEDYxJ7nyuukdkwC2rnaMN3OsP277YETqndE6joZM5 W/IvvbJJPiqCAw4vP6U0PRdou/EerZsF3hMMUM4t5INwhPAIfq1cfOutmUqDLBY1Rq5l HU00V2GkRmLxzRupLj9dbP+b1ivn0r0wDFI8itrwJlGpyE+sRGbVWbWQ6uhpgKzd1ZDP qKCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h190si6317817pgc.248.2019.05.13.12.29.31; Mon, 13 May 2019 12:29:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728261AbfEMQqf (ORCPT + 99 others); Mon, 13 May 2019 12:46:35 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:39898 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728347AbfEMQqd (ORCPT ); Mon, 13 May 2019 12:46:33 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3747314E266A1; Mon, 13 May 2019 09:46:33 -0700 (PDT) Date: Mon, 13 May 2019 09:46:32 -0700 (PDT) Message-Id: <20190513.094632.2251179341102416171.davem@davemloft.net> To: jay.vosburgh@canonical.com Cc: jarod@redhat.com, linux-kernel@vger.kernel.org, vfalico@gmail.com, andy@greyhouse.net, netdev@vger.kernel.org Subject: Re: [PATCH] bonding: fix arp_validate toggling in active-backup mode From: David Miller In-Reply-To: <6720.1557765810@famine> References: <26675.1557528809@famine> <2033e768-9e35-ac89-c526-4c28fc3f747e@redhat.com> <6720.1557765810@famine> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 13 May 2019 09:46:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jay Vosburgh Date: Mon, 13 May 2019 09:43:30 -0700 > That would be my preference, as the 29c4948293bf commit looks to > be the change actually being fixed. Sorry I pushed the original commit message out :-( But isn't the Fixes: tag he choose the one where the logic actually causes problems? That's kind of my real criteria for Fixes: tags.