Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roy Pledge <roy.pledge@nxp.com>
To:     "jocke@infinera.com" <joakim.tjernlund@infinera.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Leo Li <leoyang.li@nxp.com>
CC:     Madalin-cristian Bucur <madalin.bucur@nxp.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>
Subject: Re: [PATCH v1 4/8] soc/fsl/qbman: Use index when accessing device
 tree properties
Thread-Topic: [PATCH v1 4/8] soc/fsl/qbman: Use index when accessing device
 tree properties
Thread-Index: AQHVCaZIiomHQCI79kqjC6Wc0PXpqw==
Date:   Mon, 13 May 2019 17:40:46 +0000
Message-ID: <DB6PR0402MB27278B23001A8965AE493CE3860F0@DB6PR0402MB2727.eurprd04.prod.outlook.com>
References: <1557763756-24118-1-git-send-email-roy.pledge@nxp.com>
 <1557763756-24118-5-git-send-email-roy.pledge@nxp.com>
 <1afd837287cebccfc1dd68365870d0f5d1cf27f7.camel@infinera.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a06044f-cc39-4f81-0e58-08d6d7ca216a
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2019 17:40:46.1976
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2870
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/13/2019 12:40 PM, Joakim Tjernlund wrote:=0A=
> On Mon, 2019-05-13 at 16:09 +0000, Roy Pledge wrote:=0A=
>> The index value should be passed to the of_parse_phandle()=0A=
>> function to ensure the correct property is read.=0A=
> Is this a bug fix? Maybe for stable too?=0A=
>=0A=
>  Jocke=0A=
Yes this could go to stable.  I will include stable@vger.kernel.org when=0A=
I send the next version.=0A=
>=0A=
>> Signed-off-by: Roy Pledge <roy.pledge@nxp.com>=0A=
>> ---=0A=
>>  drivers/soc/fsl/qbman/dpaa_sys.c | 2 +-=0A=
>>  1 file changed, 1 insertion(+), 1 deletion(-)=0A=
>>=0A=
>> diff --git a/drivers/soc/fsl/qbman/dpaa_sys.c b/drivers/soc/fsl/qbman/dp=
aa_sys.c=0A=
>> index 3e0a7f3..0b901a8 100644=0A=
>> --- a/drivers/soc/fsl/qbman/dpaa_sys.c=0A=
>> +++ b/drivers/soc/fsl/qbman/dpaa_sys.c=0A=
>> @@ -49,7 +49,7 @@ int qbman_init_private_mem(struct device *dev, int idx=
, dma_addr_t *addr,=0A=
>>                         idx, ret);=0A=
>>                 return -ENODEV;=0A=
>>         }=0A=
>> -       mem_node =3D of_parse_phandle(dev->of_node, "memory-region", 0);=
=0A=
>> +       mem_node =3D of_parse_phandle(dev->of_node, "memory-region", idx=
);=0A=
>>         if (mem_node) {=0A=
>>                 ret =3D of_property_read_u64(mem_node, "size", &size64);=
=0A=
>>                 if (ret) {=0A=
>> --=0A=
>> 2.7.4=0A=
>>=0A=
>=0A=
=0A=