Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5534341yba; Mon, 13 May 2019 12:33:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqyNw0Yer2S5WCZyAthjxaAoUTt/uhJPETSPVYbh6J1o5jb0IFBX8IqCT2tJbhO4zw5/lKSa X-Received: by 2002:a17:902:8a83:: with SMTP id p3mr33567234plo.88.1557776026595; Mon, 13 May 2019 12:33:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557776026; cv=none; d=google.com; s=arc-20160816; b=VRg/vPHCb3tNCVfE/BhsrB9wxtjAxwj9SHN46+/OurrVmmxfVAkRl/AFjoQtU/b5Q9 hDeZ1VZ/q5NLrNEb+ZMcusy+YGAHZer6pQVwHFDNEhOHkaR6+RBE6GBo88/VwsvNygEq T5UBaGn4NYLKZqXeoJ04tXYNb/35YEi4Gp8cd2vVhz25UTVFbrQf8zWUZousFdCKUaVA spFl3zd8xX/9/VCvSsYfLinhjrArAkwg4kegwMrRCN/wyMpr9jXnXSERaKdwWEFFVicr ElK3PUxEGhzINC0ff54J2Ex0zvJ6QELHWux2m6YMlyFZEooWEODx430b37b356iAoELg orAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=YwJlqsMKC/jDBqQsyBEKgt5enCla/m+iqS9EplHy9DU=; b=Pp+HJymxEnngcVfhIAxYwFmA6hLKX3lxEb2a+H+I373Y4Ocy6ZtlfL3fF6AM+XvU8h uCFSJYjGZweu7EOUxPoHaI6g+suMn/BFWiyQVk31VWlHWcxfkmaHme1Od90J0wrFgdEo MPovgwt8aISVK186qqk+ubCMH9h9vxYxYoQnb0tcVbJReu2dfi2jEIabCPVfSwLvYMH+ 1EzIKEToNa6724FTij2BnJPivM7zn4rpXRP9sD6evxXkNyXaj3ArUvuQGolI0Bekd2xq e0o6RtMGMRXtmoyOxWSyl3LnNpnTjxp0a7yFgznkLS0rMIyyJkoIJNXW85cYY/2n18Vu hpKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r3si18836548pgh.162.2019.05.13.12.33.30; Mon, 13 May 2019 12:33:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730820AbfEMR3a (ORCPT + 99 others); Mon, 13 May 2019 13:29:30 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:34229 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729262AbfEMR3a (ORCPT ); Mon, 13 May 2019 13:29:30 -0400 Received: by mail-ed1-f67.google.com with SMTP id p27so18727005eda.1 for ; Mon, 13 May 2019 10:29:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YwJlqsMKC/jDBqQsyBEKgt5enCla/m+iqS9EplHy9DU=; b=iCig2h+4uNOZ5tNXpLFw6PPanUpt7JN85Bf2e8H79TI3pXW819QxxtHXkttMGpk0bC gySnrLVUIRdktTKDgZT+96VxJU+MVkP/2BPo4TpuEpCkFqs8Rlkff4EjYYoNClaTj+il GCAnuk0WN/P3UzBwxH4P96bhlrXBShPnLNlQqeyozsGzdIa1eJ/VppNy0fAYMYY0+C2A RY99CNEXPfxzllhu2xoCu2G+Z22QPbuGAHXgRLOEQnMjdMv5s5Q0P4LFAfRphyz++bEj ocJhu68NdOdQMCtvJo+Q23lhaQ5uUE02oICHQjQS3lUaYgTZYmOwsCzD3ckvkVe7bdo/ oPEA== X-Gm-Message-State: APjAAAWxeIqeu0kS7IvY5j3RArvONPxnFuJ9tZhf5Qcw4A+dtbgoUDr+ //k4igKRIbCN5q4TzsfC729SkphVz0jw329UpQc= X-Received: by 2002:a17:906:8318:: with SMTP id j24mr10804860ejx.182.1557768569090; Mon, 13 May 2019 10:29:29 -0700 (PDT) MIME-Version: 1.0 References: <6f53f0e494d743c79e18f6e3a98085711e6ddd0c.1557177585.git.len.brown@intel.com> <9f57786ba08d4d5e913cd21693aadb0ccdba72b2.1557177585.git.len.brown@intel.com> <06e134aa-943a-dff9-4d33-e0bc8449f284@linux.intel.com> In-Reply-To: <06e134aa-943a-dff9-4d33-e0bc8449f284@linux.intel.com> From: Len Brown Date: Mon, 13 May 2019 13:29:17 -0400 Message-ID: Subject: Re: [PATCH 22/22] perf/x86/intel/rapl: rename internal variables in response to multi-die/pkg support To: "Liang, Kan" Cc: X86 ML , linux-kernel@vger.kernel.org, Len Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 9, 2019 at 11:04 AM Liang, Kan wrote: > The perf rapl "pmu" in the code is cross the pkg/die. We only register > one rapl pmu for whole system for now. > I think it may be better use "die" to replace the "pkg" as well. > How about the patch as below? Fine with me! I've replaced my patch with yours in the series. thanks, Len Brown, Intel Open Source Technology Center