Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5548814yba; Mon, 13 May 2019 12:49:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqwUixMSs166bal4swOa74PsHEhZjkGfuddvAa1ZOQI/yITcn98ONn6IzqSudLsnR4Gl3gB5 X-Received: by 2002:a62:e00e:: with SMTP id f14mr35764914pfh.257.1557776972730; Mon, 13 May 2019 12:49:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557776972; cv=none; d=google.com; s=arc-20160816; b=HaLqhvM5RnsVHp4tbWApOMaxIijvNYfzQdnUvZziO8imDgTktCdBdF4tOhsdjjObJU Q2LgTV6dVVVtoYjrLytmNbZqBr9aZMLSKDzhnvrgjOjAqc7xxKV77b8mMWkxmyO6JNnw EkligKf6VBz5Yv5yutc6T9gftw7O+/NS3svhKMnbxw9NtNfXh5l4O0YNnrafOWaMF6rO 9uhEsTpRF4NcJ3o+tSAgI7X5+6qt3/zvy4mAIw+2wi5Cc5I8CO6AZCP51gzfKqtRFvTr Bl+xMJ5cxjNUny1lOFwSCxxzZ9b6YOxPObMoP9frLN81AEuEClKAJv/z/rCIH9suExBk 7H0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=SJLyfFIRYnOVNp0SlPoS4T96zE9hZc1405NjIie2IfA=; b=WVFeZo9A36XwJRiuXb2ZgJAgjpyDhM0PtnsVNpUpL5/VabbG0SYAC1H+WkJ4rkPdwK faddWE9mVqveix+Z+GA42RYGffwfkStbb13hoo0qfmZkHkNrlmyWt9bipmAufFgYVyvx E2J55VmhiV3fhmx4kJRjrRXt1FQIDqvfXsrA30F3Hnns1VQUM+PmFWpz2MKFB61gS0P3 u2WJbJYfhSUus3nRuPE9Ri4ZXkCsunI8mw5TWYYfZ0ni101xmE9w/FAspPWh3TO1XgLT erBlO9XPgGMROBDwosIOIJ1t97BXicC3zn+Eg9Wo8MzsSbWpZiEnka6f4B7Y1amtEDhQ pIyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cp6si4823292plb.273.2019.05.13.12.49.16; Mon, 13 May 2019 12:49:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726613AbfEMSVl (ORCPT + 99 others); Mon, 13 May 2019 14:21:41 -0400 Received: from mga01.intel.com ([192.55.52.88]:10239 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbfEMSVl (ORCPT ); Mon, 13 May 2019 14:21:41 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 May 2019 11:21:40 -0700 X-ExtLoop1: 1 Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga007.jf.intel.com with ESMTP; 13 May 2019 11:21:40 -0700 Date: Mon, 13 May 2019 12:16:18 -0600 From: Keith Busch To: Kai-Heng Feng Cc: sagi@grimberg.me, rafael@kernel.org, linux-pm@vger.kernel.org, Mario.Limonciello@dell.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, keith.busch@intel.com, Christoph Hellwig Subject: Re: [PATCH] nvme/pci: Use host managed power state for suspend Message-ID: <20190513181618.GD15437@localhost.localdomain> References: <20190510212937.11661-1-keith.busch@intel.com> <0080aaff18e5445dabca509d4113eca8@AUSX13MPC105.AMER.DELL.COM> <955722d8fc16425dbba0698c4806f8fd@AUSX13MPC105.AMER.DELL.COM> <20190513143754.GE15318@localhost.localdomain> <7ab8274ef1ce46fcae54a50abc76ae4a@AUSX13MPC105.AMER.DELL.COM> <20190513145708.GA25897@lst.de> <20190513151652.GB15437@localhost.localdomain> <9AE4A3E7-CDB8-4730-8B4E-43C93FC0C47F@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9AE4A3E7-CDB8-4730-8B4E-43C93FC0C47F@canonical.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 14, 2019 at 01:16:22AM +0800, Kai-Heng Feng wrote: > Disabling HMB prior suspend makes my original patch work without memory > barrier. > > However, using the same trick on this patch still freezes the system during > S2I. Could you post your code, please?