Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190510032144.15060-1-yuehaibing@huawei.com>
In-Reply-To: <20190510032144.15060-1-yuehaibing@huawei.com>
From:   Richard Weinberger <richard.weinberger@gmail.com>
Date:   Mon, 13 May 2019 23:40:58 +0200
Message-ID: <CAFLxGvz4awNWpnb_hFxwpYy4X_w6Z6+aLqUZ5Zxu6fJKXsbJ9A@mail.gmail.com>
Subject: Re: [PATCH] ubifs: Fix build error without CONFIG_UBIFS_FS_XATTR
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Artem Bityutskiy <dedekind1@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-mtd@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 10, 2019 at 5:22 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fix gcc build error while CONFIG_UBIFS_FS_XATTR
> is not set
>
> fs/ubifs/dir.o: In function `ubifs_unlink':
> dir.c:(.text+0x260): undefined reference to `ubifs_purge_xattrs'
> fs/ubifs/dir.o: In function `do_rename':
> dir.c:(.text+0x1edc): undefined reference to `ubifs_purge_xattrs'
> fs/ubifs/dir.o: In function `ubifs_rmdir':
> dir.c:(.text+0x2638): undefined reference to `ubifs_purge_xattrs'
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 9ca2d7326444 ("ubifs: Limit number of xattrs per inode")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  fs/ubifs/ubifs.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ubifs/ubifs.h b/fs/ubifs/ubifs.h
> index 379b9f7..fd7f399 100644
> --- a/fs/ubifs/ubifs.h
> +++ b/fs/ubifs/ubifs.h
> @@ -2015,13 +2015,17 @@ int ubifs_xattr_set(struct inode *host, const char *name, const void *value,
>                     size_t size, int flags, bool check_lock);
>  ssize_t ubifs_xattr_get(struct inode *host, const char *name, void *buf,
>                         size_t size);
> -int ubifs_purge_xattrs(struct inode *host);
>
>  #ifdef CONFIG_UBIFS_FS_XATTR
>  void ubifs_evict_xattr_inode(struct ubifs_info *c, ino_t xattr_inum);
> +int ubifs_purge_xattrs(struct inode *host);
>  #else
>  static inline void ubifs_evict_xattr_inode(struct ubifs_info *c,
>                                            ino_t xattr_inum) { }
> +static inline int ubifs_purge_xattrs(struct inode *host)
> +{
> +       return 0;
> +}
>  #endif
>
>  #ifdef CONFIG_UBIFS_FS_SECURITY
> --

Applied.

-- 
Thanks,
//richard