Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6001606yba; Mon, 13 May 2019 23:15:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqylFKeQ0PeYKDfBedNq/ckEfRBMervh6/ztifeijWW49T5FSjh0tj/9tq4GfXjkWWQs68nV X-Received: by 2002:a17:902:7486:: with SMTP id h6mr35539008pll.58.1557814535300; Mon, 13 May 2019 23:15:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557814535; cv=none; d=google.com; s=arc-20160816; b=cCuWjJ/V2HA+f6Eh8eOWZlKn5C5bGx1Uz3m0j0Oea0ZvtmRRdcfl/OuMwNi133EEbM gP66jY1VnJ+NfwMrgjoO47B+DsUgRZQyEMCGah5aniGdswwSE6Ng75rTQ42XoVRFp0p7 F13MAJWjbqn+L6tWkNwjeN0G0vwip2rU6T6jGnskMXU5yh5+fhzkJCxE53DIhjPgWK4y pXZZcTv7lgap8WLiKd1izJcLjMSM1x6vfDnZM6VwM697tfJBM2KS827UQJGUNkAwnrNz Vn0wjygafcPYnW0+U9zIkP9FQb5ChBLMIX/psNKgar5eZ4NY4/VClQWMjr+XZ+PtV+zy a9jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=r8+h7xUFAnJNc+SuY2O/2amHQiZnO4BQNQ0NLGFbizY=; b=nAj4/nmD8Lk6P1jHgUSsNXEJCHVPyZ01Vda4U8REhKlEj5wVw/PET/00d08OUhtmd6 IF0Nju7Juw1/6QZ893YDrrPS+LxG/gzScmWWLRVceLh+ka0Ep6/pHA9k9j8mJtzCLa0m XS6hS2TD/e6aQbbt6uAkbYCB6bOz0BuwWQ/M0d09MeGSTgg5h5YMOsklE8Hqx1bEFjVI BYVsDlKCm4Q0EJFxoG4ssIWxtPyzXM2Mi2YEnRfRsTEpqgc+CcbsRM/kHkz7XUaFkC4w z66K8fcKkzOS06Kihy+fxaJ3ZDLTTQo6kg0A2wstCGrBA04x0ShJVZsucsXSEFG8yNqZ LNiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3si19084091plp.435.2019.05.13.23.15.20; Mon, 13 May 2019 23:15:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726580AbfENGOS (ORCPT + 99 others); Tue, 14 May 2019 02:14:18 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:12311 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726369AbfENGOI (ORCPT ); Tue, 14 May 2019 02:14:08 -0400 X-UUID: 62bf8201188e4b89a77600afbef2a306-20190514 X-UUID: 62bf8201188e4b89a77600afbef2a306-20190514 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 2053767142; Tue, 14 May 2019 14:13:57 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs03n2.mediatek.inc (172.21.101.182) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 14 May 2019 14:13:56 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 14 May 2019 14:13:55 +0800 From: Stu Hsieh To: Mauro Carvalho Chehab , Rob Herring , CK Hu CC: Mark Rutland , Matthias Brugger , Stu Hsieh , , , , , , Subject: [PATCH v3 13/13] [media] mtk-mipicsi: add debugfs for mipicsi driver Date: Tue, 14 May 2019 14:13:50 +0800 Message-ID: <1557814430-9675-14-git-send-email-stu.hsieh@mediatek.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1557814430-9675-1-git-send-email-stu.hsieh@mediatek.com> References: <1557814430-9675-1-git-send-email-stu.hsieh@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-SNTS-SMTP: CDF3EB988DABE039B2641AA95D6392CF9BF315A6D47140D27D15623F11EF166C2000:8 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch add debugfs for mipicsi driver. Signed-off-by: Stu Hsieh --- .../media/platform/mtk-mipicsi/mtk_mipicsi.c | 65 +++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c b/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c index c1cbeb3c60e1..b6abd5a35752 100644 --- a/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c +++ b/drivers/media/platform/mtk-mipicsi/mtk_mipicsi.c @@ -49,6 +49,7 @@ #include #include #include +#include #define MTK_MIPICSI_DRV_NAME "mtk-mipicsi" #define MTK_PLATFORM_STR "platform:mt2712" @@ -83,6 +84,7 @@ #define SENINF_NCSI2_INT_EN 0xB0 #define SENINF_NCSI2_INT_STATUS 0xB4 #define SENINF_NCSI2_DBG_SEL 0xB8 +#define SENINF_NCSI2_DBG_PORT 0xBC #define SENINF_NCSI2_HSRX_DBG 0xD8 #define SENINF_NCSI2_DI 0xDC #define SENINF_NCSI2_DI_CTRL 0xE4 @@ -92,6 +94,7 @@ #define SENINF_TOP_MUX 0x08 #define SENINF_MUX_CTRL 0x00 +#define SENINF_MUX_DEBUG_2 0x14 #define CAMSV_MODULE_EN 0x10 #define CAMSV_FMT_SEL 0x14 @@ -114,6 +117,7 @@ #define DMA_FRAME_HEADER_EN 0xE00 #define SerDes_support 1 +#define CONFIG_DEBUG_FS 1 static int mtk_mipicsi_dbg_level; #define mtk_mipicsi_dbg(level, fmt, args...) \ @@ -165,6 +169,9 @@ struct mtk_mipicsi_dev { u32 width; u32 height; u32 bytesperline; +#ifdef CONFIG_DEBUG_FS + struct dentry *mtk_mipicsi_debugfs; +#endif }; static const struct soc_mbus_lookup mtk_mipicsi_formats[] = { @@ -220,6 +227,49 @@ static const struct soc_mbus_lookup mtk_mipicsi_formats[] = { V4L2_MBUS_PCLK_SAMPLE_FALLING | \ V4L2_MBUS_DATA_ACTIVE_HIGH) +#ifdef CONFIG_DEBUG_FS +static ssize_t mtk_mipicsi_debug_read(struct file *file, char __user *user_buf, + size_t count, loff_t *ppos) +{ + struct device *dev = file->private_data; + struct soc_camera_host *soc_host = to_soc_camera_host(dev); + struct mtk_mipicsi_dev *mipicsi = soc_host->priv; + u32 int_val; + u32 dbg_port; + u32 cnt_val; + u32 hcnt; + u32 vcnt; + char buf[256]; + char cnt_info[150]; + int i; + + int_val = readl(mipicsi->seninf + SENINF_NCSI2_INT_STATUS); + dbg_port = readl(mipicsi->seninf + SENINF_NCSI2_DBG_PORT); + memset(buf, 0, sizeof(buf)); + snprintf(buf, sizeof(buf), "%s\nSENINF_NCSI2_INT_STATUS: 0x%X\n" + "SENINF_NCSI2_DBG_PORT: 0x%X\n", + dev_name(dev), int_val, dbg_port); + + for (i = 0; i < mipicsi->camsv_num; ++i) { + cnt_val = readl(mipicsi->seninf_mux[i] + SENINF_MUX_DEBUG_2); + hcnt = (cnt_val >> 16) & 0xFFFF; + vcnt = cnt_val & 0xFFFF; + memset(cnt_info, 0, sizeof(cnt_info)); + snprintf(cnt_info, sizeof(cnt_info), + "HCNT[%d]: 0x%X\n" + "VCNT[%d]: 0x%X\n", + i, hcnt, i, vcnt); + strcat(buf, cnt_info); + } + + return simple_read_from_buffer(user_buf, count, ppos, buf, strlen(buf)); +} +static const struct file_operations mtk_mipicsi_debug_fops = { + .open = simple_open, + .read = mtk_mipicsi_debug_read, +}; +#endif /* CONFIG_DEBUG_FS */ + static void mtk_mipicsi_ana_clk_enable(void __iomem *base, bool enable) { if (enable) { @@ -1521,6 +1571,16 @@ static int mtk_mipicsi_probe(struct platform_device *pdev) goto clean; } +#ifdef CONFIG_DEBUG_FS + mipicsi->mtk_mipicsi_debugfs = + debugfs_create_file(mipicsi->drv_name, 0444, NULL, + (void *)(&pdev->dev), &mtk_mipicsi_debug_fops); + if (mipicsi->mtk_mipicsi_debugfs == NULL) { + dev_err(&pdev->dev, "debugfs_create_file fail\n"); + goto clean; + } +#endif + dev_set_drvdata(&pdev->dev, mipicsi); dev_info(&pdev->dev, "probe done\n"); @@ -1535,6 +1595,11 @@ static int mtk_mipicsi_remove(struct platform_device *pdev) { struct soc_camera_host *soc_host = to_soc_camera_host(&pdev->dev); +#ifdef CONFIG_DEBUG_FS + struct mtk_mipicsi_dev *mipicsi = soc_host->priv; + + debugfs_remove(mipicsi->mtk_mipicsi_debugfs); +#endif soc_camera_host_unregister(soc_host); pm_runtime_disable(&pdev->dev); -- 2.18.0