Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <ecdb8da5f00a8f5bd5d5ec125e2aa162e0091728.camel@ndufresne.ca>
Subject: Re: [PATCH v2] media/doc: Allow sizeimage to be set by v4l clients
From:   Nicolas Dufresne <nicolas@ndufresne.ca>
To:     Hans Verkuil <hverkuil@xs4all.nl>,
        Stanimir Varbanov <stanimir.varbanov@linaro.org>,
        linux-media@vger.kernel.org
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 14 May 2019 08:19:34 -0400
In-Reply-To: <a1807c37-99cf-d1fa-bcb9-67af2935abaf@xs4all.nl>
References: <20190412155915.16849-1-stanimir.varbanov@linaro.org>
         <a1807c37-99cf-d1fa-bcb9-67af2935abaf@xs4all.nl>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.32.1 (3.32.1-1.fc30) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le mardi 14 mai 2019 à 10:54 +0200, Hans Verkuil a écrit :
> Hi Stanimir,
> 
> On 4/12/19 5:59 PM, Stanimir Varbanov wrote:
> > This changes v4l2_pix_format and v4l2_plane_pix_format sizeimage
> > field description to allow v4l clients to set bigger image size
> > in case of variable length compressed data.
> 
> I've been reconsidering this change. The sizeimage value in the format
> is the minimum size a buffer should have in order to store the data of
> an image of the width and height as described in the format.

Should this read as the minimum size for the specific (returned by
driver) width/height/bytesperline ?

> 
> But there is nothing that prevents userspace from calling VIDIOC_CREATEBUFS
> instead of VIDIOC_REQBUFS to allocate larger buffers.
> 
> So do we really need this change?
> 
> The more I think about this, the more uncomfortable I become with this change.
> 
> Regards,
> 
> 	Hans
> 
> > Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> > ---
> >  Documentation/media/uapi/v4l/pixfmt-v4l2-mplane.rst | 13 ++++++++++++-
> >  Documentation/media/uapi/v4l/pixfmt-v4l2.rst        | 11 ++++++++++-
> >  2 files changed, 22 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/media/uapi/v4l/pixfmt-v4l2-mplane.rst b/Documentation/media/uapi/v4l/pixfmt-v4l2-mplane.rst
> > index 5688c816e334..005428a8121e 100644
> > --- a/Documentation/media/uapi/v4l/pixfmt-v4l2-mplane.rst
> > +++ b/Documentation/media/uapi/v4l/pixfmt-v4l2-mplane.rst
> > @@ -31,7 +31,18 @@ describing all planes of that format.
> >  
> >      * - __u32
> >        - ``sizeimage``
> > -      - Maximum size in bytes required for image data in this plane.
> > +      - Maximum size in bytes required for image data in this plane,
> > +	set by the driver. When the image consists of variable length
> > +	compressed data this is the number of bytes required by the
> > +	codec to support the worst-case compression scenario.
> > +
> > +	For uncompressed images the driver will set the value. For
> > +	variable length compressed data clients are allowed to set
> > +	the sizeimage field, but the driver may ignore it and set the
> > +	value itself, or it may modify the provided value based on
> > +	alignment requirements or minimum/maximum size requirements.
> > +	If the client wants to leave this to the driver, then it should
> > +	set sizeimage to 0.
> >      * - __u32
> >        - ``bytesperline``
> >        - Distance in bytes between the leftmost pixels in two adjacent
> > diff --git a/Documentation/media/uapi/v4l/pixfmt-v4l2.rst b/Documentation/media/uapi/v4l/pixfmt-v4l2.rst
> > index 71eebfc6d853..0f7771151db9 100644
> > --- a/Documentation/media/uapi/v4l/pixfmt-v4l2.rst
> > +++ b/Documentation/media/uapi/v4l/pixfmt-v4l2.rst
> > @@ -89,7 +89,16 @@ Single-planar format structure
> >        - Size in bytes of the buffer to hold a complete image, set by the
> >  	driver. Usually this is ``bytesperline`` times ``height``. When
> >  	the image consists of variable length compressed data this is the
> > -	maximum number of bytes required to hold an image.
> > +	number of bytes required by the codec to support the worst-case
> > +	compression scenario.
> > +
> > +	For uncompressed images the driver will set the value. For
> > +	variable length compressed data clients are allowed to set
> > +	the sizeimage field, but the driver may ignore it and set the
> > +	value itself, or it may modify the provided value based on
> > +	alignment requirements or minimum/maximum size requirements.
> > +	If the client wants to leave this to the driver, then it should
> > +	set sizeimage to 0.
> >      * - __u32
> >        - ``colorspace``
> >        - Image colorspace, from enum :c:type:`v4l2_colorspace`.
> >