Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V4] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI
 is available
To:     Julien Grall <julien.grall@arm.com>,
        linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     horms@verge.net.au, magnus.damm@gmail.com, linux@armlinux.org.uk,
        geert@linux-m68k.org,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
References: <1557850012-16612-1-git-send-email-olekstysh@gmail.com>
 <4e712484-d6a4-e358-ea66-51dfcee18b0d@arm.com>
From:   Oleksandr <olekstysh@gmail.com>
Message-ID: <c45a056f-80d5-187d-e865-fb66d514830a@gmail.com>
Date:   Tue, 14 May 2019 19:51:30 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <4e712484-d6a4-e358-ea66-51dfcee18b0d@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 14.05.19 19:13, Julien Grall wrote:
> Hi,

Hi Julien


>
> On 14/05/2019 17:06, Oleksandr Tyshchenko wrote:
>> diff --git a/arch/arm/mach-shmobile/setup-rcar-gen2.c 
>> b/arch/arm/mach-shmobile/setup-rcar-gen2.c
>> index eea60b2..64e3abd 100644
>> --- a/arch/arm/mach-shmobile/setup-rcar-gen2.c
>> +++ b/arch/arm/mach-shmobile/setup-rcar-gen2.c
>> @@ -17,6 +17,7 @@
>>   #include <linux/of.h>
>>   #include <linux/of_fdt.h>
>>   #include <linux/of_platform.h>
>> +#include <linux/psci.h>
>>   #include <asm/mach/arch.h>
>>   #include <asm/secure_cntvoff.h>
>>   #include "common.h"
>> @@ -63,6 +64,15 @@ void __init rcar_gen2_timer_init(void)
>>       void __iomem *base;
>>       u32 freq;
>>   +    /*
>> +     * If PSCI is available then most likely we are running on 
>> PSCI-enabled
>> +     * U-Boot which, we assume, has already taken care of resetting 
>> CNTVOFF
>> +     * and updating counter module before switching to non-secure mode
>> +     * and we don't need to.
>> +     */
>> +    if (psci_ops.cpu_on) > +        goto skip_update;
> Are you sure this is working when ARM_PSCI_FW is not selected? Is it 
> possible to have a .config for RCAR without ARM_PSCI_FW?

Oh, my fault. Mainline shmobile_defconfig has PSCI stuff disabled.

I should have checked for the PSCI operation to be available only if 
CONFIG_ARM_PSCI_FW is defined.

Thank you for pointing this out.


>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko