Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6702659yba; Tue, 14 May 2019 12:04:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqwMhhORo77N7KlKBQ4i9WRtOoj5HVn29oqj7QLFXjca7APp4TZiyj+SE/ciwFmrqgAtuj48 X-Received: by 2002:a17:902:46a:: with SMTP id 97mr11327496ple.66.1557860665553; Tue, 14 May 2019 12:04:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557860665; cv=none; d=google.com; s=arc-20160816; b=jMBTRqLIRB9X2uhAEDFqNo6w+XkIiJP4gdreGoTge016h5G602TU2Ph2bDoDI4bUnG tCTEIW+qxfyIv2YaTQ45Ym5SUd3Otryx+SKfT44yYtErydxRX3stAieKrLftGJxb3pd7 FO6tDLs2j4JDtszaNYfN0dqctecBdVJAftra4Pdupag/K8oi6RwJ1V2B6vHaNfnMiAwD QiJp6itPl24D/zxBKhP4rdb6oDn4OhWMCTMPyjY4pVGKe7S8cvchn2tqWMH0aArk8KNg BmvoTlAxel1MsFzqkFEZFP/Ca03MCTNgu8ijCvLl1JFZOKyOg+fS2/4av4Ib7fWzGLhs o4Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:from:subject:dkim-signature; bh=yKJtRNLjUlsE2AHcVMIA1x07TU3dSlb+s1DhsyS3+wE=; b=NtTw5BlP7/5rs2OuRburHxe7Z6vkeY0vgvR1qkZl7II3yJYh8G2rfpzSSjxTvqVNyz Y0ynwvd1UN2MTz6FRVncD2zmu1vTzYMzl7AxYzt+8UV7sH80318eH6hjCD8u7vX5cI+U fxJww4F7sFql6eDJ1VPmk2HmaYc+czwj7urRIxbwZ74mHblDLCCi2zxYIswkv8PhaxAl MPgrQr8F71Uu3P2rm2p1HJEetS5/2q8+mq5UAyxKtEzrZx6bFtdgAKg0j6EFDvgE2r9C UI/74b220i4sjlDuQsBRcqbMoF/szM+7YZWTrhJmWtJDrVMG2wYKmnsKg9EVHS/hwac4 TmTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iJPtOyES; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y24si21709273pgh.372.2019.05.14.12.04.05; Tue, 14 May 2019 12:04:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iJPtOyES; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727734AbfENTBb (ORCPT + 99 others); Tue, 14 May 2019 15:01:31 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:55977 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbfENTBb (ORCPT ); Tue, 14 May 2019 15:01:31 -0400 Received: by mail-wm1-f68.google.com with SMTP id x64so170338wmb.5; Tue, 14 May 2019 12:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:cc:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=yKJtRNLjUlsE2AHcVMIA1x07TU3dSlb+s1DhsyS3+wE=; b=iJPtOyESOdvx9dnZIhnOoGHJy0PYv+xOrJEg5/QfqQuGBvfiuepkt7Zu3dmXEA58Ef wpq1aXA5AEYjRQpu/i4NjYlMZ9x+9+Ukzlo5f4OgIfnOAHjyjIeODV2zSqCqvqH6xZrg Gdqa/Bm73NZli+seeDAvdqDYYCGoZ9WpwN5gGYwIZYiVQDPUNkM0lCGXbEk0pLZTDDzb 8oC9Sb6myG8oYripgTZUJUZGEGHYqLrB8pk73D2SkxP3PxGWuT+NhTkAjQBJXnmauN8/ 8QHY8svdTpYIGrvb3K/qe+cuSeT6M/wgUIslnm8mDNadJ7peGWUNyQhdMAxtt0oONvOw Vh8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yKJtRNLjUlsE2AHcVMIA1x07TU3dSlb+s1DhsyS3+wE=; b=IlDr1gaUp+vSZ/CQMEtORuqOMhxgc80sumWr+EVywfoYFwVL7mhb7FM3P5xKJvf4/9 zLkLa/A9l17xsUoH4oeJDOZ0nIGIA0+RZjWTwqWGk8+oCDn3cuEicBZM9WQ2xoANNhkY 49WTzwCii6UbB83yH9k6mNfb6A02Z3Sa0s+oi6Jhl4pTcqpO1Qsma+Jn7rfYdKxzQpda 7H6FB+Tis4SebGOWBKTzBxHGZXRCp9jIPlCLZZan/V4FEmP86iG23qdDOdWjn9niqbYR Cs5riSiunhRb3BVJy1SGaSpGKlmX9qjNfFq+Tf/JITzdb7MJ6ap6sWmDxfTvy7Cclo9q l8zA== X-Gm-Message-State: APjAAAXVF5LfMAxc8vxTqeODi+j6kFh5jkCtLYEp9JDWiJEwH19+NXjX 5GrbB9lEUnfZTDmHGWzjZ0A7Vocr X-Received: by 2002:a1c:3c2:: with SMTP id 185mr3024200wmd.91.1557860487478; Tue, 14 May 2019 12:01:27 -0700 (PDT) Received: from [192.168.20.141] ([194.99.104.18]) by smtp.gmail.com with ESMTPSA id z13sm2565466wrw.42.2019.05.14.12.01.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 May 2019 12:01:27 -0700 (PDT) Subject: [PATCH v4 06/13] platform/x86: asus-wmi: Refactor WMI event handling From: Yurii Pavlovskyi Cc: Corentin Chary , Darren Hart , Andy Shevchenko , Daniel Drake , Chris Chiu , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: Message-ID: <6a62a746-6c0d-e786-1edc-febbfc083a64@gmail.com> Date: Tue, 14 May 2019 21:01:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Refactor WMI event handling into separate functions for getting the event code and handling the retrieved event code as a preparation for introduction of WMI event queue support. Signed-off-by: Yurii Pavlovskyi --- drivers/platform/x86/asus-wmi.c | 66 +++++++++++++++++++++------------ 1 file changed, 42 insertions(+), 24 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index 5bdb4ffdbee3..ed7c7857012e 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -85,6 +85,8 @@ MODULE_LICENSE("GPL"); #define ASUS_ACPI_UID_ASUSWMI "ASUSWMI" +#define WMI_EVENT_MASK 0xFFFF + static const char * const ashs_ids[] = { "ATK4001", "ATK4002", NULL }; static bool ashs_present(void) @@ -1651,83 +1653,99 @@ static void asus_wmi_fnlock_update(struct asus_wmi *asus) asus_wmi_set_devstate(ASUS_WMI_DEVID_FNLOCK, mode, NULL); } -static void asus_wmi_notify(u32 value, void *context) +static int asus_wmi_get_event_code(u32 value) { - struct asus_wmi *asus = context; struct acpi_buffer response = { ACPI_ALLOCATE_BUFFER, NULL }; union acpi_object *obj; acpi_status status; int code; - int orig_code; - unsigned int key_value = 1; - bool autorelease = 1; status = wmi_get_event_data(value, &response); - if (status != AE_OK) { - pr_err("bad event status 0x%x\n", status); - return; + if (ACPI_FAILURE(status)) { + pr_warn("Failed to get WMI notify code: %s\n", + acpi_format_exception(status)); + return -EIO; } obj = (union acpi_object *)response.pointer; - if (!obj || obj->type != ACPI_TYPE_INTEGER) - goto exit; + if (obj && obj->type == ACPI_TYPE_INTEGER) + code = (int)(obj->integer.value & WMI_EVENT_MASK); + else + code = -EIO; + + kfree(obj); + return code; +} + +static void asus_wmi_handle_event_code(int code, struct asus_wmi *asus) +{ + int orig_code; + unsigned int key_value = 1; + bool autorelease = 1; - code = obj->integer.value; orig_code = code; if (asus->driver->key_filter) { asus->driver->key_filter(asus->driver, &code, &key_value, &autorelease); if (code == ASUS_WMI_KEY_IGNORE) - goto exit; + return; } if (code >= NOTIFY_BRNUP_MIN && code <= NOTIFY_BRNUP_MAX) code = ASUS_WMI_BRN_UP; - else if (code >= NOTIFY_BRNDOWN_MIN && - code <= NOTIFY_BRNDOWN_MAX) + else if (code >= NOTIFY_BRNDOWN_MIN && code <= NOTIFY_BRNDOWN_MAX) code = ASUS_WMI_BRN_DOWN; if (code == ASUS_WMI_BRN_DOWN || code == ASUS_WMI_BRN_UP) { if (acpi_video_get_backlight_type() == acpi_backlight_vendor) { asus_wmi_backlight_notify(asus, orig_code); - goto exit; + return; } } if (code == NOTIFY_KBD_BRTUP) { kbd_led_set_by_kbd(asus, asus->kbd_led_wk + 1); - goto exit; + return; } if (code == NOTIFY_KBD_BRTDWN) { kbd_led_set_by_kbd(asus, asus->kbd_led_wk - 1); - goto exit; + return; } if (code == NOTIFY_KBD_BRTTOGGLE) { if (asus->kbd_led_wk == asus->kbd_led.max_brightness) kbd_led_set_by_kbd(asus, 0); else kbd_led_set_by_kbd(asus, asus->kbd_led_wk + 1); - goto exit; + return; } if (code == NOTIFY_FNLOCK_TOGGLE) { asus->fnlock_locked = !asus->fnlock_locked; asus_wmi_fnlock_update(asus); - goto exit; + return; } - if (is_display_toggle(code) && - asus->driver->quirks->no_display_toggle) - goto exit; + if (is_display_toggle(code) && asus->driver->quirks->no_display_toggle) + return; if (!sparse_keymap_report_event(asus->inputdev, code, key_value, autorelease)) pr_info("Unknown key %x pressed\n", code); +} -exit: - kfree(obj); +static void asus_wmi_notify(u32 value, void *context) +{ + struct asus_wmi *asus = context; + int code = asus_wmi_get_event_code(value); + + if (code < 0) { + pr_warn("Failed to get notify code: %d\n", code); + return; + } + + asus_wmi_handle_event_code(code, asus); } /* -- 2.17.1