Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG
To:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Schrempf Frieder <frieder.schrempf@kontron.de>
Cc:     Boris Brezillon <bbrezillon@kernel.org>,
        Richard Weinberger <richard@nod.at>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Marek Vasut <marek.vasut@gmail.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>
References: <20190510121727.29834-1-lede@allycomm.com>
 <3cb32209-f246-e562-2aee-fdf566a60b30@kontron.de>
 <1023ba21-b188-1dcc-3ecc-c563d4cb8a67@allycomm.com>
 <e53a0569-6eca-4385-007d-baffc3f5c7ea@kontron.de>
 <20190514220136.5f4624ee@xps13>
From:   Jeff Kletsky <lede@allycomm.com>
Message-ID: <e38f0f4b-1881-0e2f-22ad-5f5c4fccaa4b@allycomm.com>
Date:   Tue, 14 May 2019 15:08:06 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190514220136.5f4624ee@xps13>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/14/19 1:01 PM, Miquel Raynal wrote:

> Hi Schrempf,
>
> Schrempf Frieder <frieder.schrempf@kontron.de> wrote on Tue, 14 May
> 2019 16:11:28 +0000:
>
>> Hi Jeff,
>>
>> On 14.05.19 17:42, Jeff Kletsky wrote:
>>> On 5/13/19 6:56 AM, Schrempf Frieder wrote:
>>>    
>>>> Hi Jeff,
>>>>
>>>> [...]
>>>> Maybe it would be better to split this patch into three parts:
>>>> * Add support for two-byte device IDs
>>>> * Add #define-s for three-byte addressing for read ops
>>>> * Add support for GD5F1GQ4UFxxG
>>>>
>>>> Anyway the content looks good to me, so:
>>>>
>>>> Reviewed-by: Frieder Schrempf<frieder.schrempf@kontron.de>
>>>>
>>>> [...]
>>> [...]
> I agree with Frieder, if you don't mind, please split this commit in
> three.
>
> Thanks,
> Miquèl
>
Split and superseded by
https://patchwork.ozlabs.org/project/linux-mtd/list/?series=107874

Jeff