Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp6881931yba; Tue, 14 May 2019 15:44:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqyewWaqdUXQ1Aexui8Q0ijvShsrUMQIO6O8wlZVXsOOzWpL6cBihXIkSJNXTULpyp7PHZcL X-Received: by 2002:a62:65c1:: with SMTP id z184mr24020786pfb.130.1557873873603; Tue, 14 May 2019 15:44:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557873873; cv=none; d=google.com; s=arc-20160816; b=LPPDXEL+7BFgUhvwdmbKV+xVhZCG2crQ0rBRPEBpjgVBliZiha+iQ+t7+bDNK7P4LY NSn23CyMqwUBeW3QiNoCB2h0bE2+61Vf29g+rcL0oBhqTYArpNHLALBn9LhbCLCdrqnl iU92fJaGos8usNXhH/7P2kb44pnZYf20RK1XNw30miVYIjvvj9MGq8f9vOzX5COWObxH 6w1ECOX7lC5CkpIdlIse1zCzAQ0PVi0HuKDnU28sP3ngtqBrqCENI2cJ0p4x7RDaXGer D6UJG83ETU0C6KSFsvDPDAU5Y07Uo5FoIqV+DbIdwZHIDLvDTsskVPckjmQmJAWP56GK 2kjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=gJ667IRdi/PpJXcuRFHnE9KHxeDxSnPEsQ+zqfpabXs=; b=tN/GAo54YlPITw7g69cYR6Op4oQinoUwVKAJKqWsk9YhpTOs+03t3h1Zt4baH8aaO8 nzl+QPfHpmr71Pi8Ly4mJT1l/nzAnKqzmoScJK02mrIfYpzawnoeRRgqKR1RQZ0zEfh8 grBMMzTng0vhO1XP7buLwhrK1B+7kYqnRmWlf3beNCnJHcIAEVL04/kMmfxcIdqeV1/O t+4l3oE/vaBJ6r4ruNaeLE2WINTItSCAcpbILM0einY1YEQpaeCFQl1B4xKxzjiZMGR3 jCaP64wJsHK+QWGtq3hTPdbJalkAacDjRDmRMw6bWJpnouy8CpwTIE76/G+LbcjSrV9n OFzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p68si136198pgp.193.2019.05.14.15.44.19; Tue, 14 May 2019 15:44:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbfENWmi (ORCPT + 99 others); Tue, 14 May 2019 18:42:38 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:59788 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726148AbfENWmh (ORCPT ); Tue, 14 May 2019 18:42:37 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 01A9414C048B7; Tue, 14 May 2019 15:42:36 -0700 (PDT) Date: Tue, 14 May 2019 15:42:36 -0700 (PDT) Message-Id: <20190514.154236.2269798493150074980.davem@davemloft.net> To: yuehaibing@huawei.com Cc: paulus@samba.org, gnault@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2] ppp: deflate: Fix possible crash in deflate_init From: David Miller In-Reply-To: <20190514145532.21932-1-yuehaibing@huawei.com> References: <20190514074300.42588-1-yuehaibing@huawei.com> <20190514145532.21932-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 14 May 2019 15:42:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Tue, 14 May 2019 22:55:32 +0800 > BUG: unable to handle kernel paging request at ffffffffa018f000 ... > If ppp_deflate fails to register in deflate_init, > module initialization failed out, however > ppp_deflate_draft may has been regiestred and not > unregistered before return. > Then the seconed modprobe will trigger crash like this. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > v2: also check ppp_deflate_draft registration Applied and queued up for -stable, thanks.