Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1556234531-108228-1-git-send-email-yang.shi@linux.alibaba.com> <66e2f965-4f4d-a755-69b3-5342aa761ff3@linux.alibaba.com>
In-Reply-To: <66e2f965-4f4d-a755-69b3-5342aa761ff3@linux.alibaba.com>
From:   Yang Shi <shy828301@gmail.com>
Date:   Tue, 14 May 2019 15:50:07 -0700
Message-ID: <CAHbLzkqU=O9JmE9Fnie1MzRB_fbD1=3turBtmaRwX-p=PMHHXw@mail.gmail.com>
Subject: Re: [PATCH] mm: filemap: correct the comment about VM_FAULT_RETRY
To:     Yang Shi <yang.shi@linux.alibaba.com>
Cc:     josef@toxicpanda.com, Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Josef,

Any comment on this patch? I switched to my personal email since the
mail may get bounced back with my work email sometime.


On Wed, May 8, 2019 at 9:55 AM Yang Shi <yang.shi@linux.alibaba.com> wrote:
>
> Ping.
>
>
> Josef, any comment on this one?
>
>
> Thanks,
>
> Yang
>
>
>
> On 4/25/19 4:22 PM, Yang Shi wrote:
> > The commit 6b4c9f446981 ("filemap: drop the mmap_sem for all blocking
> > operations") changed when mmap_sem is dropped during filemap page fault
> > and when returning VM_FAULT_RETRY.
> >
> > Correct the comment to reflect the change.
> >
> > Cc: Josef Bacik <josef@toxicpanda.com>
> > Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> > ---
> >   mm/filemap.c | 6 ++----
> >   1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/mm/filemap.c b/mm/filemap.c
> > index d78f577..f0d6250 100644
> > --- a/mm/filemap.c
> > +++ b/mm/filemap.c
> > @@ -2545,10 +2545,8 @@ static struct file *do_async_mmap_readahead(struct vm_fault *vmf,
> >    *
> >    * vma->vm_mm->mmap_sem must be held on entry.
> >    *
> > - * If our return value has VM_FAULT_RETRY set, it's because
> > - * lock_page_or_retry() returned 0.
> > - * The mmap_sem has usually been released in this case.
> > - * See __lock_page_or_retry() for the exception.
> > + * If our return value has VM_FAULT_RETRY set, it's because the mmap_sem
> > + * may be dropped before doing I/O or by lock_page_maybe_drop_mmap().
> >    *
> >    * If our return value does not have VM_FAULT_RETRY set, the mmap_sem
> >    * has not been released.
>