Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp207267yba; Tue, 14 May 2019 23:12:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzp2rNXCQO9VMuWAFbRfC+XY5oSxqSCKYs+S7cqeX+sp2U8VMnGIkP2LNP6vcSGDCWszELM X-Received: by 2002:a63:1e5b:: with SMTP id p27mr41137126pgm.213.1557900762917; Tue, 14 May 2019 23:12:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557900762; cv=none; d=google.com; s=arc-20160816; b=k+TMEIe0ocZPMiDzESEJhXl5TcQQz88LjqMWg8iUTYLKCf14m+VeK4q0kvuE5xS3Km RDV28S+eB1uWb9Samh0eqF6d4Pc+JHVuXa9KmfN1lmDWrRUYF2uWFAT7kk9G4CBtPdI9 VGoZJ3wyeQD22HJ0Prqz3na6mOS1owwXO/j7xCHdc+slpNAMNfTgLRioEfDa7uLVbeMm WcsSMbmLksJ8ShpceZUIZxpLtFMw7K1t2WIDM09r/fwZvr8KoUYnLALaAw/jo7OEh3bE FIjQdOC9FBYb/5GrqrF9y63g+SoP2UeduICKykiftWmWXmmxVvsCtoWymqwBKBJ2GWCH a5rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=pHe2hUma/kLcAZIwajK8cIzRAgTrAAvvfSE29xa1Q1s=; b=D15WGi5lDpbnQyqnhvSp3DKWxSILXn3Fv6lyi+UKAAVgaxVJJJcGbWPHQD/tbYX72S dVi68PpDC2MIJ9qm80EH9hBI6u/liuJ8ontp3pj5ouTnNckwYhleGhMgc2N40Mir/BNs b0zv3ftdOB4X4h6r3Jh1XBSX3IfeYGvrwbokpYOQyB3UpWiJKQZzJAwIT5g4gjF/i3vv tzksJWNj3zO3BS6KGUFkn2MWVuHO5ZwTyyZBzjBLetDti6QuiFOXN6groYS9HOH1T/14 zZ5U9PYwalqxnYPLLzOvi0dw0i8r4xuhkjFX3YF59/9yUK4ZwSuRFGPYn8A15aj09V+/ TnHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p19si966451pgm.175.2019.05.14.23.12.27; Tue, 14 May 2019 23:12:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726290AbfEOGKy (ORCPT + 99 others); Wed, 15 May 2019 02:10:54 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:49700 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725857AbfEOGKy (ORCPT ); Wed, 15 May 2019 02:10:54 -0400 X-IronPort-AV: E=Sophos;i="5.60,471,1549926000"; d="scan'208";a="383210622" Received: from abo-218-110-68.mrs.modulonet.fr (HELO hadrien) ([85.68.110.218]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2019 08:10:52 +0200 Date: Wed, 15 May 2019 08:10:52 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: Julia Lawall , Gilles Muller , Masahiro Yamada , Michal Marek , Nicolas Palix , Wen Yang , Coccinelle , LKML , Yi Wang Subject: Re: [1/3] Coccinelle: pci_free_consistent: Use formatted strings directly in SmPL rules In-Reply-To: <94e36a1e-0550-2782-aefc-4ac0b858c843@web.de> Message-ID: References: <94e36a1e-0550-2782-aefc-4ac0b858c843@web.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 May 2019, Markus Elfring wrote: > > NACK. If the code is going to change, I would rather it come closer to > > staying within 80 characters. > > Do you really prefer then to deviate from the Linux coding style > at such source code places? > > Would you like to split affected string literals over multiple lines? No, I want msg = ... so that the string starts earlier and ends earlier. julia