Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp255178yba; Wed, 15 May 2019 00:19:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqz0fYKr1A8GHYqSc1fad7/o/ZD9ngeNIN6Gx1sMg7Xt5cFJOMvHUjQkeSTfboIRL26/zeVt X-Received: by 2002:a17:902:7610:: with SMTP id k16mr6883147pll.177.1557904755621; Wed, 15 May 2019 00:19:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557904755; cv=none; d=google.com; s=arc-20160816; b=MVX1M0baGwbAMAnMl4RdmUnemKR7CjNtRrU9vgRzi9mJ+TTkpKAc9+qltqRtITPnJW cvYt5fyiTSpvsu7xlT2xss7y+4JS+rIZmyPxBzfLWxWjoEYZ3V9KLR6FrovfdWwzIUUD 3eSTvUuPRoC4m1lMxaj+hcvw9X7VMs7czwtGDd0ppjR6ZcvmPCOATxum+cdHyhFoWc7O cIJ8xamOcjR49xowk1dx5oxiB58A9rZu4Ot8Y6DAJXX0oLW9Mnwf5Q9wn7tCdDx9uKgM 1cKN+l0tDFvgUorEOM7uTxClrKdOm4yjJGtb2h/GwER0tscMxeLR4ffPJ76pVRddlA5E v8qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bmyHjZNyHivUvoK23ukxv4Nj9Dp9vXFDiA73FJcaCvw=; b=xBv/WacLYeMwnfjVck+1nXnY+wkhirI07T954uq67U9SGzcA6YmDqtyVkYqzVQUiWS FAHGGEK7qOJHVHCfO0+aV/UxA5to5m/+qzsQ1MuQQsjxGP73fZRZIXEgfKdXyxHYQ2id WRdfOHwN5wqXn6Ayp8+Y7qrRnpLmemQTN1cjW/lrEY+l8vj25OlNjOMBj/69opgx7wK9 ZfqzsvOm9V1pD+FBmnlX/dSLnUUqNinK2EdwzNy03M3g09UXWfxw4XDCq/LygGx5SGmj ErybiaXpb5buUeSzYHwJIOEbm8HZBPpePIc2r7POcwXgBU2c47YMri1gMLVZySK4FraK dtOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Nx5hfMDZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p7si1077947pgi.276.2019.05.15.00.19.00; Wed, 15 May 2019 00:19:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Nx5hfMDZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726330AbfEOHQM (ORCPT + 99 others); Wed, 15 May 2019 03:16:12 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:51342 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfEOHQG (ORCPT ); Wed, 15 May 2019 03:16:06 -0400 Received: by mail-wm1-f68.google.com with SMTP id o189so1437569wmb.1 for ; Wed, 15 May 2019 00:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=bmyHjZNyHivUvoK23ukxv4Nj9Dp9vXFDiA73FJcaCvw=; b=Nx5hfMDZKgnefIIAgQs8SbUtsBCrRfHUUmK1JNJVo0XJCP3elPtIQ6RSayZ/oFUTRo 7/AtzjH3EswrK4+R7pP5bEiH+g09w0ptv1SJB7g1VvDQhOa5ULSmouhI70Rv4KtRdvF9 ma4Wp88E+xiD5YYSA6QV8rrqIQORAZN/w9cvwCJND5j6Hnn5V30UaYeGUaKnsSsCVQcb j0en7BYL45JLvOLpaBmH7FP1mQY4+PRs+LiIUfVm0HL/65tmJeJ2mjOD8+kmjpJF/adj 6xFahwnhKyE+Wbd3vI6nS1OTdlZv2CluVIECy2Nmng5uvw1dVQjFGlz5vAuPQWpN2r4o kR/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=bmyHjZNyHivUvoK23ukxv4Nj9Dp9vXFDiA73FJcaCvw=; b=rYqL557OZf2I34cbntibb3lenlJx9wO6yzTw8ja2nfnrcAHV6vL4bNR688W1GfIKnc h7Yc1lmAasW111U0cy6aH0tq7f6VO41sfuYieOalR9Wzo8XlbzEcXPwGgb7bFLy5lqo4 1ZO9sChmZJQdHCoW8sZ9gCDD9kXwtdZdqdmXmUMn+f1nC8DqYMcHnWKs3vc9JZm4gl+g uWvbe3KEQsi/7xCl/KsUSOOr2On7lMkEOPS6QyCWHTGPeD6RAVZ0DwRefAdZtozPXW3T qAvFKWqPoUMzodLKrbzI84NyNkVtD3o9gJBqjHZab5qCNSaVNpNLGzP13Eo7Ku7YrJY5 +r8w== X-Gm-Message-State: APjAAAWH2Pth4mIW6q/sJIY15DJqSBhm1wbcCW/k0bj/y64Lw3/f9WvW /1O/QRh3l4e6ZpTt90a/tuLEfs8K5DU= X-Received: by 2002:a1c:c5c3:: with SMTP id v186mr17138769wmf.60.1557904564394; Wed, 15 May 2019 00:16:04 -0700 (PDT) Received: from dell ([2.27.167.43]) by smtp.gmail.com with ESMTPSA id i15sm1290359wre.30.2019.05.15.00.16.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 May 2019 00:16:03 -0700 (PDT) Date: Wed, 15 May 2019 08:16:01 +0100 From: Lee Jones To: masonccyang@mxic.com.tw Cc: bbrezillon@kernel.org, broonie@kernel.org, devicetree@vger.kernel.org, Geert Uytterhoeven , Simon Horman , juliensu@mxic.com.tw, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-spi@vger.kernel.org, marek.vasut@gmail.com, mark.rutland@arm.com, robh+dt@kernel.org, sergei.shtylyov@cogentembedded.com, zhengxunli@mxic.com.tw Subject: Re: [PATCH v12 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver Message-ID: <20190515071601.GQ4319@dell> References: <1556092536-17095-1-git-send-email-masonccyang@mxic.com.tw> <1556092536-17095-3-git-send-email-masonccyang@mxic.com.tw> <20190514065216.GL4319@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 May 2019, masonccyang@mxic.com.tw wrote: > Hi Jones, > > > > > + > > > +struct rpc_spi { > > > + struct rpc_mfd *mfd; > > > > The term MFD isn't a real thing. What you're obtaining below is > > driver data and is normally articulated as 'ddata' in drivers. > > yes, it's just imply that data is from MFD. > > Should I rename "mfd" ? Yes please. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog