Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp334231yba; Wed, 15 May 2019 02:06:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZLDC+i+HDbmLZF3AGFDUPlCpwtPW7dF0rjqEglg+N8TSYb1kIx+ZNCw3YN5lTNgwrC61g X-Received: by 2002:a62:d286:: with SMTP id c128mr46913166pfg.159.1557911204075; Wed, 15 May 2019 02:06:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557911204; cv=none; d=google.com; s=arc-20160816; b=EBdqmhvf1jvy0V47m9MmYB5bcZIcffBy/5zPC6igrNi6Gsd/A/sN9MeJg6UbglC0Ar doJBu44He4F/APOWh6ry+0dg1Nm+AyIJDBqVPef4p9E4BzD6Gsv39sgguadbt9Sw0FNS Gmq8cQO54/YlHoonRtN9qj+hX+vo3KWZ17NPEMFHDvnx1OUYXVlX+XgZa7fImLZ+cKmX e+U3q/+74bDUBBz5IMY6ZjSpFWDQqebsbUrUqsp/taAJ6nO68BDvnbzTa0DmvcL+EBqt 9Pncj3ecmQ3cHHjKjOiX1+Bbur/5qIT6XLDuM79Om67NIVn6B8E4iLY+4Wu/XTkNE2+/ m2MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=dsiZB9nVEVR8ihY/V7TPcVlkfDTLZU7ZnIyB9Kdlm0s=; b=pdbjM2u4rt4Fo1holAMtQtu7+KhUHsp7kZLgQQOY6JN22XBwfotD754dpYfgDSYuL+ zpn+rhUPOhm7Ym7KrPI+WWAF6fknTC7AgmfVrk/fw9wl3yR11o5hOXdHwJBKRiMr7xYO IfzjOAZeUjSr3le2SD41gOd57xgaYos9rTuv1mg9A0zPxdGwTNqgwJGeIfCXOKzAdrk2 YnLizxwKcEImyzGr9zwJXy3sAU6Aabz/yOad6LZbqYsWGRHOooZOVi89sIKtk7qxNdu+ aYOgtUQvkekCAnQObYz2fakhuaWmosBXwLgjuSxO5AEMUlHNy3vi5h9bkmR8h1gaUiK5 dWQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fe53eolI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q3si1268576plb.266.2019.05.15.02.06.28; Wed, 15 May 2019 02:06:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fe53eolI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726260AbfEOJFV (ORCPT + 99 others); Wed, 15 May 2019 05:05:21 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:38792 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725902AbfEOJFV (ORCPT ); Wed, 15 May 2019 05:05:21 -0400 Received: by mail-lf1-f66.google.com with SMTP id y19so1392580lfy.5 for ; Wed, 15 May 2019 02:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dsiZB9nVEVR8ihY/V7TPcVlkfDTLZU7ZnIyB9Kdlm0s=; b=fe53eolIL/3iYiMnsq+1fXzykGVvwxyKevubcWnZKt5EOSxiBQCaqTTbU78kF7PCXa +wvCfluF3bI+I5OUGCPYwR+gay2dlzf3EpA7is3C+xg78U4Pqkq7xLZzxfpfk9lHHCJy 0SyuK1T0jYk4EsY4slOaWmzfR1U8cFZoZisIiYr4DgnAonBW8ltQIGkSPq5QxQa7d3tS D6oohPDjEAy9t/Z4APcbjRMzuXxiNWlEewbgc+fLtQM8MIQI7oeuAHZ65SbYeQnzru/U tx+dU3PcZ10l8JzPDzWlmj/y2BXvWX5DVtSnGknVSVfo3/FX0vfTIIAqxPAs+oNHOv8W IxmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dsiZB9nVEVR8ihY/V7TPcVlkfDTLZU7ZnIyB9Kdlm0s=; b=TbN/7k/ERPSkInSb2fZJo8uh9PPVFYwhkldrQZcuKELxrRedWkZEHdKY4V2q1kEpqT t15XVZ0Qa0xkgtXKCuCPhEJnaXX8Yg8QevC+96Uq8U81y3uukpEGpWcr8KfBcFnU6GYV cB+I35x12xQ8R+1mhCu1VIDcazOyDG27/ZEvDvqzq5nT888CaDqy5F6aNawa+8ki22Y1 ub3fiakhop1kgZDI0qGVEgyd3Sv4QBYlz6/fL4KlJb23BO3nuFlRI/uB9xpKhnI9/SA7 vK3N6PBK/qKHwlOtLVFDugC9L+7iYI1GvVE5jQSxc3uXrX+tPq0stI9QzGO14GIJKtZY iccg== X-Gm-Message-State: APjAAAUNbbKyk22MU7S5iy3mjNeRP+6IPlx/aoQD77IBi86PL2Fei+lD V1k+VRk96bmeutzzgVmiWKQ= X-Received: by 2002:a19:711e:: with SMTP id m30mr17636859lfc.106.1557911119589; Wed, 15 May 2019 02:05:19 -0700 (PDT) Received: from uranus.localdomain ([5.18.103.226]) by smtp.gmail.com with ESMTPSA id f11sm272370lfa.48.2019.05.15.02.05.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 May 2019 02:05:18 -0700 (PDT) Received: by uranus.localdomain (Postfix, from userid 1000) id 807AD460442; Wed, 15 May 2019 12:05:16 +0300 (MSK) Date: Wed, 15 May 2019 12:05:16 +0300 From: Cyrill Gorcunov To: Konstantin Khlebnikov Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Kirill Tkhai , Al Viro Subject: Re: [PATCH 1/5] proc: use down_read_killable for /proc/pid/maps Message-ID: <20190515090516.GB2952@uranus.lan> References: <155790967258.1319.11531787078240675602.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <155790967258.1319.11531787078240675602.stgit@buzz> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2019 at 11:41:12AM +0300, Konstantin Khlebnikov wrote: > Do not stuck forever if something wrong. > This function also used for /proc/pid/smaps. > > Signed-off-by: Konstantin Khlebnikov All patches in series look ok to me (actually I thought if there is a scenario where might_sleep may trigger a warning, and didn't find one, so should be safe). Reviewed-by: Cyrill Gorcunov