Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp337481yba; Wed, 15 May 2019 02:10:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqwdqTVGRtqNm3YdlT0Io5YO8/JURCIJ+4FXiXN0J1kjSvoA7egbXoA2Fwl/UYk5xa0+mH65 X-Received: by 2002:a65:5086:: with SMTP id r6mr43640953pgp.301.1557911433644; Wed, 15 May 2019 02:10:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557911433; cv=none; d=google.com; s=arc-20160816; b=tmSrMkzL1kL0mUv7hCLAKnn0pxUTBI10isIzae7GUvXAgeJnvUCsrMlTObs7DC47Py w2VhV7HIZELZbHFlvpDv4+So2lwhZIiDd7x6emun8HchJUZf3tfS2eZhqjV6a+O7IkaB OiEkOzwSDcJ1h1Z1dENWHlU78KemvEfJ7s0l0mVYIMF1beeUbqJA7VEOWx+RQBZ1jD60 nKeifjFdS/B/joTe2wbHj1yAWOv8PYzlNMolrkKdQMYuc6IetT3/XGvpiW6OcHXw5QLp tNpWEgILct6GjYpWutyH2JqRiimlWOUFSWCbsgjgLNTG7veD381NSTTTri89o9/Z0rxJ Fzlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=QzKWRK6NBMbQhyE5irhebHpSXfQiq/oIHcfVwvxA9Y4=; b=VETgJS06OckEyd2oimJ0wyjqx9I1hBLdiaOYyw11GVH0j6Wf6DX0J6p/oQYICxaKN8 60R7uXR/7Uw5bc6BRbvxLFtmiBRaMicfZYj/L+qqHW/8KPjEeKnyAK/k2g2kguMSaOHM azfJfdRP2KKtvIPgxQOEmyr7QM0KV/cgk1eSEVxuhVhoCaBsBQvviCb0g+WSjM7cOCmn 99ubBtREqCpQcQKjKGbgDzZZo6Hm1e53HJxlLYWFyZbye7+7WhTFnunc2pqwABYFdRVN nWpWF8A5EHprQlCugakFpYe56SWNELlM8uDwOVYepG9VQoXqAxeqaY2/H8585yTEbnQE wTjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=X4g8Gcvp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u12si1360119pgj.145.2019.05.15.02.10.18; Wed, 15 May 2019 02:10:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=X4g8Gcvp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726501AbfEOJIi (ORCPT + 99 others); Wed, 15 May 2019 05:08:38 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38179 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726084AbfEOJIh (ORCPT ); Wed, 15 May 2019 05:08:37 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id BC9412585C; Wed, 15 May 2019 05:08:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 15 May 2019 05:08:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QzKWRK6NBMbQhyE5i rhebHpSXfQiq/oIHcfVwvxA9Y4=; b=X4g8GcvpmrFXvz4Gj+kjjbvd4BPxDWmlu mNe90vPHAMVXSibDmqRNLZb64qEOgU228oZwvNPD74T9V6CdAUsZ6J55nusBzdhC 4vFb40XprJhib+5m3b0NFw65vVO1G0ZCPv+n+1STYqckkhDn+rNNvdhk1/PnIXng 3B1bBP8iZhS+0AdcJ1Ih54UKFoX152+nrRB2/2lrqICOFdKpfzo6o5OLm0ScRsGN fqBu+46x5v7yePLyzOWBN7Xw48SwYG9nrUAAxAJc9zUiCLxDL9xm2zQQEFW7AcPb h2ju5oVCv1bJFlQqq6owvWKHsWkrIK0iT0cqgRml0610dGsw4qK4Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleekgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepfdfvohgsihhnucev rdcujfgrrhguihhnghdfuceothhosghinheskhgvrhhnvghlrdhorhhgqeenucfkphepud dvuddrgeegrddvvdefrddvuddunecurfgrrhgrmhepmhgrihhlfhhrohhmpehtohgsihhn sehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from eros.localdomain (ppp121-44-223-211.bras1.syd2.internode.on.net [121.44.223.211]) by mail.messagingengine.com (Postfix) with ESMTPA id 1E8C81037C; Wed, 15 May 2019 05:08:32 -0400 (EDT) From: "Tobin C. Harding" To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: "Tobin C. Harding" , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] powerpc: Remove double free Date: Wed, 15 May 2019 19:07:50 +1000 Message-Id: <20190515090750.30647-1-tobin@kernel.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kfree() after kobject_put(). Who ever wrote this was on crack. Fixes: 7e8039795a80 ("powerpc/cacheinfo: Fix kobject memleak") Signed-off-by: Tobin C. Harding --- FTR git log --pretty=format:"%h%x09%an%x09%ad%x09%s" | grep 7e8039795a80 7e8039795a80 Tobin C. Harding Tue Apr 30 11:09:23 2019 +1000 powerpc/cacheinfo: Fix kobject memleak arch/powerpc/kernel/cacheinfo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kernel/cacheinfo.c b/arch/powerpc/kernel/cacheinfo.c index f2ed3ef4b129..862e2890bd3d 100644 --- a/arch/powerpc/kernel/cacheinfo.c +++ b/arch/powerpc/kernel/cacheinfo.c @@ -767,7 +767,6 @@ static void cacheinfo_create_index_dir(struct cache *cache, int index, cache_dir->kobj, "index%d", index); if (rc) { kobject_put(&index_dir->kobj); - kfree(index_dir); return; } -- 2.21.0