Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp365816yba; Wed, 15 May 2019 02:47:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLryk/4i4SAW0Yt1BtI7qZgbh5zg4OxNM1YMCZG/gWFXJRAVBtmsmiE3vJ5vbckwZsQN+a X-Received: by 2002:a63:ed03:: with SMTP id d3mr42993798pgi.7.1557913678988; Wed, 15 May 2019 02:47:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557913678; cv=none; d=google.com; s=arc-20160816; b=nhD9XtUz1Q8M/TC4gKVZtpK9brhyv+jTOWnpedCAIjNvLfxxtZyoYquCwCvCOgUQFm 7BdfXG1J00TU893dWMjxeF4Za9qPD0UtjgMmZrnfK1dXPoeO4rm7gRwKxlR9j5XF4gZs GWPyU37Z/O5702fC/H+yjHJMze9n19xRTD1DSroiN4Eb+wv7I9MH4fvHBF/UkrXhKEHK 2o/2V3xfiOiWjtcz45q4+geCaii+6iRMnuN0oy2RBLAz6HeZOyjyVDg4qCFzjts37lFk ZdKnvqOlPiiX8bJNffFzzb8VW8LRHulwbbtnrF1ydyIBja9pnzcxmNXqARkLI6h9P+5L /hSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Dx6cmdRuKwu44bi05vU5trNrvnMjATBfl1Zq/vLB1pI=; b=wBvitQIkng+vu2WEuUJditZYnYnYNlj+GVNhfi9v4oGcV/RdBiT3wBnYbzmMut8FaR V2Arg/sbfte4XWeYYRLIThmBQimXEGUOwvCPoeA0L9bdK1PX/byIEzTStbfWSW18sClJ fGGz0PUML3QyFgLrxJLqgbE1uXgkBDl7439R2aPHXSMNQVd0bR5ZVLngIhPozF+8PmZ1 lmI5Fks9NkwjYX9AFkKOjABSskkaLd6Gd8YwWxShQWUR1NVAVMk8P9DnRGgNTRk0M+2c /UmGtuTNiyXHtLLAMPFx72UHDeegc7qJHgasWnDG+R2DpO6xhQLgJdMS53KWzzrwYxdF a7tA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h12si1400222pgs.151.2019.05.15.02.47.44; Wed, 15 May 2019 02:47:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726412AbfEOJpa (ORCPT + 99 others); Wed, 15 May 2019 05:45:30 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:39204 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbfEOJpa (ORCPT ); Wed, 15 May 2019 05:45:30 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9092DA78; Wed, 15 May 2019 02:45:29 -0700 (PDT) Received: from e110439-lin.cambridge.arm.com (e110439-lin.cambridge.arm.com [10.1.194.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7841F3F703; Wed, 15 May 2019 02:45:26 -0700 (PDT) From: Patrick Bellasi To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-api@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Tejun Heo , "Rafael J . Wysocki" , Vincent Guittot , Viresh Kumar , Paul Turner , Quentin Perret , Dietmar Eggemann , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle , Suren Baghdasaryan Subject: [PATCH v9 00/16] Add utilization clamping support Date: Wed, 15 May 2019 10:44:43 +0100 Message-Id: <20190515094459.10317-1-patrick.bellasi@arm.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, this is a respin of: https://lore.kernel.org/lkml/20190402104153.25404-1-patrick.bellasi@arm.com/ which includes the following main changes: - fix "max local update" by moving into uclamp_rq_inc_id() - use for_each_clamp_id() and uclamp_se_set() to make code less fragile - rename sysfs node: s/sched_uclamp_util_{min,max}/sched_util_clamp_{min,max}/ - removed not used uclamp_eff_bucket_id() - move uclamp_bucket_base_value() definition into patch using it - get rid of not necessary SCHED_POLICY_MAX define - update sched_setattr() syscall to just force the current policy on SCHED_FLAG_KEEP_POLICY - return EOPNOTSUPP from uclamp_validate() on !CONFIG_UCLAMP_TASK - make alloc_uclamp_sched_group() a void function - simplify bits_per() definition - add rq's lockdep assert to uclamp_rq_{inc,dec}_id() With the above, I think we captured all the major inputs from Peter [1]. Thus, this v9 is likely the right version to unlock Tejun's review [2] on the remaining cgroup related bits, i.e. patches [12-16]. Cheers Patrick Series Organization =================== The series is organized into these main sections: - Patches [01-07]: Per task (primary) API - Patches [08-09]: Schedutil integration for FAIR and RT tasks - Patches [10-11]: Integration with EAS's energy_compute() - Patches [12-16]: Per task group (secondary) API It is based on today's tip/sched/core and the full tree is available here: git://linux-arm.org/linux-pb.git lkml/utilclamp_v9 http://www.linux-arm.org/git?p=linux-pb.git;a=shortlog;h=refs/heads/lkml/utilclamp_v9 Newcomer's Short Abstract ========================= The Linux scheduler tracks a "utilization" signal for each scheduling entity (SE), e.g. tasks, to know how much CPU time they use. This signal allows the scheduler to know how "big" a task is and, in principle, it can support advanced task placement strategies by selecting the best CPU to run a task. Some of these strategies are represented by the Energy Aware Scheduler [3]. When the schedutil cpufreq governor is in use, the utilization signal allows the Linux scheduler to also drive frequency selection. The CPU utilization signal, which represents the aggregated utilization of tasks scheduled on that CPU, is used to select the frequency which best fits the workload generated by the tasks. The current translation of utilization values into a frequency selection is simple: we go to max for RT tasks or to the minimum frequency which can accommodate the utilization of DL+FAIR tasks. However, utilization values by themselves cannot convey the desired power/performance behaviors of each task as intended by user-space. As such they are not ideally suited for task placement decisions. Task placement and frequency selection policies in the kernel can be improved by taking into consideration hints coming from authorized user-space elements, like for example the Android middleware or more generally any "System Management Software" (SMS) framework. Utilization clamping is a mechanism which allows to "clamp" (i.e. filter) the utilization generated by RT and FAIR tasks within a range defined by user-space. The clamped utilization value can then be used, for example, to enforce a minimum and/or maximum frequency depending on which tasks are active on a CPU. The main use-cases for utilization clamping are: - boosting: better interactive response for small tasks which are affecting the user experience. Consider for example the case of a small control thread for an external accelerator (e.g. GPU, DSP, other devices). Here, from the task utilization the scheduler does not have a complete view of what the task's requirements are and, if it's a small utilization task, it keeps selecting a more energy efficient CPU, with smaller capacity and lower frequency, thus negatively impacting the overall time required to complete task activations. - capping: increase energy efficiency for background tasks not affecting the user experience. Since running on a lower capacity CPU at a lower frequency is more energy efficient, when the completion time is not a main goal, then capping the utilization considered for certain (maybe big) tasks can have positive effects, both on energy consumption and thermal headroom. This feature allows also to make RT tasks more energy friendly on mobile systems where running them on high capacity CPUs and at the maximum frequency is not required. From these two use-cases, it's worth noticing that frequency selection biasing, introduced by patches 9 and 10 of this series, is just one possible usage of utilization clamping. Another compelling extension of utilization clamping is in helping the scheduler in making tasks placement decisions. Utilization is (also) a task specific property the scheduler uses to know how much CPU bandwidth a task requires, at least as long as there is idle time. Thus, the utilization clamp values, defined either per-task or per-task_group, can represent tasks to the scheduler as being bigger (or smaller) than what they actually are. Utilization clamping thus enables interesting additional optimizations, for example on asymmetric capacity systems like Arm big.LITTLE and DynamIQ CPUs, where: - boosting: try to run small/foreground tasks on higher-capacity CPUs to complete them faster despite being less energy efficient. - capping: try to run big/background tasks on low-capacity CPUs to save power and thermal headroom for more important tasks This series does not present this additional usage of utilization clamping but it's an integral part of the EAS feature set, where [4] is one of its main components. Android kernels use SchedTune, a solution similar to utilization clamping, to bias both 'frequency selection' and 'task placement'. This series provides the foundation to add similar features to mainline while focusing, for the time being, just on schedutil integration. References ========== [1] Message-ID: <20190509130215.GV2623@hirez.programming.kicks-ass.net> https://lore.kernel.org/lkml/20190509130215.GV2623@hirez.programming.kicks-ass.net/ [2] Message-ID: <20180911162827.GJ1100574@devbig004.ftw2.facebook.com> https://lore.kernel.org/lkml/20180911162827.GJ1100574@devbig004.ftw2.facebook.com/ [3] Energy Aware Scheduling https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/scheduler/sched-energy.txt?h=v5.1 [4] Expressing per-task/per-cgroup performance hints Linux Plumbers Conference 2018 https://linuxplumbersconf.org/event/2/contributions/128/ Patrick Bellasi (16): sched/core: uclamp: Add CPU's clamp buckets refcounting sched/core: uclamp: Add bucket local max tracking sched/core: uclamp: Enforce last task's UCLAMP_MAX sched/core: uclamp: Add system default clamps sched/core: Allow sched_setattr() to use the current policy sched/core: uclamp: Extend sched_setattr() to support utilization clamping sched/core: uclamp: Reset uclamp values on RESET_ON_FORK sched/core: uclamp: Set default clamps for RT tasks sched/cpufreq: uclamp: Add clamps for FAIR and RT tasks sched/core: uclamp: Add uclamp_util_with() sched/fair: uclamp: Add uclamp support to energy_compute() sched/core: uclamp: Extend CPU's cgroup controller sched/core: uclamp: Propagate parent clamps sched/core: uclamp: Propagate system defaults to root group sched/core: uclamp: Use TG's clamps to restrict TASK's clamps sched/core: uclamp: Update CPU's refcount on TG's clamp changes Documentation/admin-guide/cgroup-v2.rst | 46 ++ include/linux/log2.h | 34 ++ include/linux/sched.h | 58 ++ include/linux/sched/sysctl.h | 11 + include/linux/sched/topology.h | 6 - include/uapi/linux/sched.h | 14 +- include/uapi/linux/sched/types.h | 66 ++- init/Kconfig | 75 +++ kernel/sched/core.c | 754 +++++++++++++++++++++++- kernel/sched/cpufreq_schedutil.c | 22 +- kernel/sched/fair.c | 44 +- kernel/sched/rt.c | 4 + kernel/sched/sched.h | 123 +++- kernel/sysctl.c | 16 + 14 files changed, 1229 insertions(+), 44 deletions(-) -- 2.21.0