Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] Staging: vc04_services: Fix kernel type 'u32' over
 'uint32_t'
To:     Madhumitha Prabakaran <madhumithabiw@gmail.com>, eric@anholt.net,
        gregkh@linuxfoundation.org, f.fainelli@gmail.com,
        rjui@broadcom.com, sbranden@broadcom.com,
        bcm-kernel-feedback-list@broadcom.com,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
References: <20190514160207.11573-1-madhumithabiw@gmail.com>
From:   Stefan Wahren <stefan.wahren@i2se.com>
Message-ID: <43fc8207-6b5b-1caa-3d19-f44074fffd0b@i2se.com>
Date:   Wed, 15 May 2019 12:03:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190514160207.11573-1-madhumithabiw@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Madhumitha,

On 14.05.19 18:02, Madhumitha Prabakaran wrote:
> Fix the warning issued by checkpatch
> Prefer kernel type 'u32' over 'uint32_t'

grepping the sources within vc04_services shows a lot more occurences.

I suggest to fix this style issue at least for the whole camera driver
and name the patch like

staging: bcm2835-camera: prefer kernel types

Regards
Stefan

>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
>  drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h b/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h
> index d1c57edbe2b8..90793c9f9a0f 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h
> +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h
> @@ -309,7 +309,7 @@ struct mmal_msg_port_parameter_set {
>  	u32 port_handle;      /* port */
>  	u32 id;     /* Parameter ID  */
>  	u32 size;      /* Parameter size */
> -	uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE];
> +	u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE];
>  };
>  
>  struct mmal_msg_port_parameter_set_reply {
> @@ -331,7 +331,7 @@ struct mmal_msg_port_parameter_get_reply {
>  	u32 status;           /* Status of mmal_port_parameter_get call */
>  	u32 id;     /* Parameter ID  */
>  	u32 size;      /* Parameter size */
> -	uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE];
> +	u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE];
>  };
>  
>  /* event messages */