Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 15 May 2019 12:19:13 +0200 (CEST)
From:   Julia Lawall <julia.lawall@lip6.fr>
To:     Markus Elfring <Markus.Elfring@web.de>
cc:     Coccinelle <cocci@systeme.lip6.fr>,
        LKML <linux-kernel@vger.kernel.org>,
        Cheng Shengyu <cheng.shengyu@zte.com.cn>,
        Gilles Muller <Gilles.Muller@lip6.fr>,
        Ma Jiang <ma.jiang@zte.com.cn>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Michal Marek <michal.lkml@markovi.net>,
        Nicolas Palix <nicolas.palix@imag.fr>,
        Wen Yang <wen.yang99@zte.com.cn>,
        Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [3/3] Coccinelle: pci_free_consistent: Extend when constraints
 for two SmPL ellipses
In-Reply-To: <c53d5a80-7f80-535c-8394-a3289399feba@web.de>
Message-ID: <alpine.DEB.2.20.1905151217380.3231@hadrien>
References: <201905151043340243098@zte.com.cn> <alpine.DEB.2.21.1905150808180.2591@hadrien> <bfde9b91-0c5d-31a0-4b1b-5f675152b2f8@web.de> <alpine.DEB.2.20.1905151119070.3231@hadrien> <c53d5a80-7f80-535c-8394-a3289399feba@web.de>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-210433361-1557915553=:3231"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--8323329-210433361-1557915553=:3231
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT


On Wed, 15 May 2019, Markus Elfring wrote:

> >>> On the other hand, I do care about causing false negatives.
> >>
> >> Do you find the missing warning after the addition of such an exclusion
> >> specification interesting?
> >
> > I already suggested how to improve the code.
>
> I find that the idea “e2->fld” needs further clarification.
> Such a SmPL specification will be resolved also to an expression,
> won't it?

Saving in a local variable doesn't impact the need to free the object.  A
field is the most obvious case where the object may not need freeing.  But
there are many expressions that e2->fld will not match.

julia
--8323329-210433361-1557915553=:3231--