Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp434803yba; Wed, 15 May 2019 04:03:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqxUcl1I/CeGiy5UgJmmGvjP/mrE9NElZVnOQaYAYWg4iDuiGqh14xRUMw1HSaeq7ZqCnyj7 X-Received: by 2002:aa7:8c1a:: with SMTP id c26mr46127376pfd.25.1557918230514; Wed, 15 May 2019 04:03:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557918230; cv=none; d=google.com; s=arc-20160816; b=U0n8B6pqgCsugBlVFJLJQw9yQ7Ssw9YjWBN7X3lFV+4afNgy139sSrtpTM0dOEJnwX qWzjvziBhv4uK6vi2Set828SQMmJtZYOgfqjYSzj7hQLZXH3D8+QdtKBGu0sEmHu+o5T hM01s2UQBoEl1Fb9CtbZXwYdanlCtOjMhwR6hJIH/mPth2YQStwhbDDBXc+rgztiSj+y zNdd4IlGScuhUfIWZsXDBhPUKUew7iBayvygZ6OAhsl/uOUT54GdGK6VU7VJg9JCInmD A3XlVPRVLgnckoEuf3TnYocVJbkngL5OMIQjDvcI5zfR2k/5shmVU+koJJfj4jE0iP8h 1q7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UeCKm2kvVleobsJ3WlCST8M3q+NS3KAr/4l0whSfNEQ=; b=EEu9OIBLZ3eWLQ4WyVA9MywBpeYPAF5VglO7fmIouw0FgLLKlN+5OYKIFWCRywM6mY LxnoxYAyyXkJHs1J0YFXM0HllO90hH9Xh/l4YDUmQzATI4IrX4UT09PhgYAlCFR+IkSl 5QaPSagvedBznTwd9yaomqFpoWFmfVwuzbQt7VneBFiyWliPHy8kfSkv9nCv4/cF8HZE ks4GTNwg7V5UkW2udh+pbRHlm18zmFKyAvo19Cf2tNUKVOCn+OTaU93MrM0vQgFC24NX 1/DOD+lDdmVXwsP99QJicD/Fu8yGbt+6lCAyU3wwF2XBDS7vyH1GMTrpEOj0BOEdAsEt qNvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dEeMhc6H; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h96si1526527plb.281.2019.05.15.04.03.26; Wed, 15 May 2019 04:03:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dEeMhc6H; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727558AbfEOLAx (ORCPT + 99 others); Wed, 15 May 2019 07:00:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:57698 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727527AbfEOLAs (ORCPT ); Wed, 15 May 2019 07:00:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B8BC21743; Wed, 15 May 2019 11:00:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557918047; bh=kHUJUhAQ67GBD0lgTRXpqfQtUNbpcSom31zkWP96Q8A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dEeMhc6HnIsm8V197Y/DXtp4RKOVBE3VXAV1Rc1hFZaJg0CeFmiaVx0VB40DyFosd 5flLNn+wkQSYGlnjiyZPseWGykB9fs/MG+mn9zk6oAJT1AjBSEgCZ65+1fTTCmDBYD jPsF1bZMl0xyMHw/Oq5Jg73pKm5NfRBPRYiE7ggA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Po-Hsu Lin , "David S. Miller" , Sasha Levin Subject: [PATCH 3.18 73/86] selftests/net: correct the return value for run_netsocktests Date: Wed, 15 May 2019 12:55:50 +0200 Message-Id: <20190515090655.210699311@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090642.339346723@linuxfoundation.org> References: <20190515090642.339346723@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 30c04d796b693e22405c38e9b78e9a364e4c77e6 ] The run_netsocktests will be marked as passed regardless the actual test result from the ./socket: selftests: net: run_netsocktests ======================================== -------------------- running socket test -------------------- [FAIL] ok 1..6 selftests: net: run_netsocktests [PASS] This is because the test script itself has been successfully executed. Fix this by exit 1 when the test failed. Signed-off-by: Po-Hsu Lin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- tools/testing/selftests/net/run_netsocktests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/run_netsocktests b/tools/testing/selftests/net/run_netsocktests index c09a682df56ae..19486dab2379e 100644 --- a/tools/testing/selftests/net/run_netsocktests +++ b/tools/testing/selftests/net/run_netsocktests @@ -6,7 +6,7 @@ echo "--------------------" ./socket if [ $? -ne 0 ]; then echo "[FAIL]" + exit 1 else echo "[PASS]" fi - -- 2.20.1