Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp457847yba; Wed, 15 May 2019 04:27:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqzPYYpDvogUZ+4kL72TKnv3er+dzKma7mtHC2J5i7UD0K83Kukrj7i9kqlhEHy1tHtWPYKJ X-Received: by 2002:a17:902:2884:: with SMTP id f4mr15591388plb.230.1557919649133; Wed, 15 May 2019 04:27:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557919649; cv=none; d=google.com; s=arc-20160816; b=lpa/pZ9g+kaMU7D6kABzkFe59VHN0A+ecspzeyZeeN8oNs+wR6TZ9XkKofedW+NlqL PBgrKoaExyMeQedSbUaZAP4on/B8bfS1AXsGUENPz01zmqeJTz6/QNX/hals3VY3/NN4 YFn7B0GlRgeb16FxUqcb+qEh1rYVPRalIYCGsykoJNx+Ww/XYgnzxukYutwPBO93wRX0 q/XZu3UKYdnLQk2NNRoCil8sLw93r7hTMzvSFDebe/8SN2Y5fYYBCerktiPl4qiB613B 8V51X87DcTvz8PvEONPi4hmY/UnmVtHTitlgq5ewlaPB8TNjXed+w6OWQrl47ldOLstM uaCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=okIvu2JHG7BFVEvNoYRUxpO82NzlNK+cm5Vt/CTtGbE=; b=Lm23R9X1o3idjickkY6oLyimzUahFF5spFo284XysIl89nI6pOCd22Qs2asVtaPlW3 W+aCTW+NGW1UHH1K8S5fBGH8Yn2s0AfKo+6yO4WgvPIUwes5AX8vF5dy+EYCDPwq3ir0 4YrPmOrx+iDFIRg0lBT/XT7FRRGz26OyjthrNFZmqwbbyZI1eCEr1z0x/SRznp4b075K +QYKonyzc5mZhgTfxpMJrpVlxRg4kC4Zyc+jFLMr0VhrnH82tOIyomGSIG+5yPCLeo8k nvPr+cf3lXTCs3tq/E8srYEXCLe3yIv/gn7AMM1GCmV7znKhh7s9VbdLpLRnqa6ALkAK OS9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=s40kOWwP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31si1564972plz.198.2019.05.15.04.27.14; Wed, 15 May 2019 04:27:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=s40kOWwP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732048AbfEOLZt (ORCPT + 99 others); Wed, 15 May 2019 07:25:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:36540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732039AbfEOLZo (ORCPT ); Wed, 15 May 2019 07:25:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45F90206BF; Wed, 15 May 2019 11:25:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557919543; bh=JDCjz2uejUGz1Wl/+wSooTpOrcmdF/YYT9dMSQKOIF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=s40kOWwPflBqEnDHrp/CUExCnxGwkOoAAc2D+0UwwF9K9bOm1YFi9lfCldGuDv679 /ISYl7JlTOwP4+sea/9sYwTTLSGY3MxBBewGO0KDNJg/i3946IKitkTTzOlG8o03T4 35U1HdWehz1iP42Scy9nS0MV4Eito3qNGcUUxmiE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Laurentiu Tudor , Madalin Bucur , "David S. Miller" Subject: [PATCH 4.19 090/113] dpaa_eth: fix SG frame cleanup Date: Wed, 15 May 2019 12:56:21 +0200 Message-Id: <20190515090700.466456129@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090652.640988966@linuxfoundation.org> References: <20190515090652.640988966@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurentiu Tudor [ Upstream commit 17170e6570c082717c142733d9a638bcd20551f8 ] Fix issue with the entry indexing in the sg frame cleanup code being off-by-1. This problem showed up when doing some basic iperf tests and manifested in traffic coming to a halt. Signed-off-by: Laurentiu Tudor Acked-by: Madalin Bucur Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -1648,7 +1648,7 @@ static struct sk_buff *dpaa_cleanup_tx_f qm_sg_entry_get_len(&sgt[0]), dma_dir); /* remaining pages were mapped with skb_frag_dma_map() */ - for (i = 1; i < nr_frags; i++) { + for (i = 1; i <= nr_frags; i++) { WARN_ON(qm_sg_entry_is_ext(&sgt[i])); dma_unmap_page(dev, qm_sg_addr(&sgt[i]),