Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp463485yba; Wed, 15 May 2019 04:33:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJGw5pasql+Ohe3uiuiRKZ5dji9/vD62dtm7ZRktvOTfGQYjMkhg9iJ6Fl9YpCyEL/b4A1 X-Received: by 2002:a17:902:b184:: with SMTP id s4mr5458105plr.46.1557920025515; Wed, 15 May 2019 04:33:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557920025; cv=none; d=google.com; s=arc-20160816; b=O+4FtHG0aSedWZ8uxRofwnpUoOO8kyVHNojwja3ofQdq0SvbMYMDmJEOxzrxdu9it0 n7VgU+mGeWKfpMuF2j84erX3pj4QevslyUXQMOsTZkTvn40L3AogscdTwe4xOVM7bZdQ WbPo5G+S2zUIxMQ1Vg6KxdP6nA2lbkmYgkRTRDvF4a3hANsn57UQD0B1NuRNr9TqVFZs HhHUNO3IxOu5UdbSJMlRTIflv2x2f0bSin2uEsiVT0laBwL7a+AYGCKtHyvPE5xYL5OL 8ZJy6vmCAnpHVLCzLnp/MgH+5Aflioyj+rud6rSPLo13TrOJDAVN8j/+WLZ9BMGYilJg /ZhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=okIvu2JHG7BFVEvNoYRUxpO82NzlNK+cm5Vt/CTtGbE=; b=niKI4+PT41P+IL5XFV9tagx6sjsZTD3CFxCtvT+C+HGcmBzlYhpBdsIS4z8as38FAN otILsgsBO1fFjNOuaLbP0I3RCiwqZRvme++3jzgS5B9TsCdvX3gechjBHvxkU3pW0WE7 eDHJg+j2BBc/Djs+hI61Omm5KUi0gkp0hZGPLrGbr6bsxKTPv9BsH/pnPFJ5jBEy12ig 4wNVRYfDz8/yHRu65DwbQeQ7Ci1SDunnV0Ey/gBnaW48PWnpYrA12eYumE2yi+b/GyVl wsJF/cxn+JEa1PjnJTsi0DTXQLP0qON57UShRfc15YU4WBCAnMI13e3EW5MEgrarICKv 2VpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qJphTH4a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x21si1567225pln.224.2019.05.15.04.33.31; Wed, 15 May 2019 04:33:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qJphTH4a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732731AbfEOLa3 (ORCPT + 99 others); Wed, 15 May 2019 07:30:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:41990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732722AbfEOLa0 (ORCPT ); Wed, 15 May 2019 07:30:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D10E20843; Wed, 15 May 2019 11:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557919825; bh=JDCjz2uejUGz1Wl/+wSooTpOrcmdF/YYT9dMSQKOIF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qJphTH4aw5YX6A6+kZFVtmY2WKcFGDCbVYHTZ73EDeBiSAD5Rl/tNIx4YIVRKDg77 kIKRZ0TZWOX501za6V7OY5HgU+U0TfmgS2jyPf5nz/Bmap58LbglIEZ1aSl1HRkdsr XzYqS4eSck6yKDrFz9QDwedLKZRjvlR89A8LOgJw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Laurentiu Tudor , Madalin Bucur , "David S. Miller" Subject: [PATCH 5.0 107/137] dpaa_eth: fix SG frame cleanup Date: Wed, 15 May 2019 12:56:28 +0200 Message-Id: <20190515090701.337352286@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090651.633556783@linuxfoundation.org> References: <20190515090651.633556783@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurentiu Tudor [ Upstream commit 17170e6570c082717c142733d9a638bcd20551f8 ] Fix issue with the entry indexing in the sg frame cleanup code being off-by-1. This problem showed up when doing some basic iperf tests and manifested in traffic coming to a halt. Signed-off-by: Laurentiu Tudor Acked-by: Madalin Bucur Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -1648,7 +1648,7 @@ static struct sk_buff *dpaa_cleanup_tx_f qm_sg_entry_get_len(&sgt[0]), dma_dir); /* remaining pages were mapped with skb_frag_dma_map() */ - for (i = 1; i < nr_frags; i++) { + for (i = 1; i <= nr_frags; i++) { WARN_ON(qm_sg_entry_is_ext(&sgt[i])); dma_unmap_page(dev, qm_sg_addr(&sgt[i]),