Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp476569yba; Wed, 15 May 2019 04:49:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqzoi4Ml5J2Bl3VIHt0reanHdnV13yEegoqx+JhdZlgKiBRco5JhlLhkjaENj/28Sb/NB23+ X-Received: by 2002:a63:d252:: with SMTP id t18mr44254792pgi.131.1557920995855; Wed, 15 May 2019 04:49:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557920995; cv=none; d=google.com; s=arc-20160816; b=vOtB2ANmjegOnl/CidmVl1YfvpE5c2wwktKDBBHpOA5RX6RgCxbN5LYjpRIj+KIwQW hb8H/t9ClECO5ueOMxSpw692vl5vQPEiiEvrTnZ5CeAbw+rDaTlx7oX5nnXE65Fs4Yt0 OlWAZla4coTKZH/ufZEc6klTVgt0ldnN3Ff+N6irp2Z2/GCE6fZxMfLFeD0TGiLbqDFz K+zIy1pWQHHzu/hRYBiQOk6Ijt4EkhoNodqbm6lmQjxIkXsO2JkRL9wcwbRcrksOjXdD dz8xuVzAMW2LfaIZ1bZjnaZiysycHOPEttYU+XvIng66r1QT1de5zR4jMFSQ+jsBuR8A ixog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nYizJbJvrGU3NlGmhPjmDHNxnMBzTJH+i4cYNjhF18g=; b=JR+17UXzG12KY4Hh3v6cxSu9ETMWmDchqPfr6EH4MWwnBQOLqa+QdXJCneuUbUB32J BhQzG1GlBT32cZlQhsNBgoR8ixwOpTbwFeLYWtkrIF8CPg1KJUqvOfA7jVO52s/Ea/8s Mph1VqKfyfUtzGvyEv/250X76IHOd1+nkWQhnwgrXy/mNgup3j+wFO/vrnkhVxa5H1Qb 8yQSDcGpxcZNWRq3BTVHLHMIYHgbMn0PTIRCDJeW0Bfo9X4Pf9XMe7y6D5QeJjck9t23 ejH8SQC1BDat1JV10G/A0aT8WYBFRE3RKyAc/H5N8aXaw7TkuGl3eYlhWdnioPew4njP +hrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GG6THTIz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s14si1949555pfa.91.2019.05.15.04.49.41; Wed, 15 May 2019 04:49:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GG6THTIz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731703AbfEOLXp (ORCPT + 99 others); Wed, 15 May 2019 07:23:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:34166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731694AbfEOLXn (ORCPT ); Wed, 15 May 2019 07:23:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 156A520862; Wed, 15 May 2019 11:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557919422; bh=sArjO93LdjXnGm7f5fCgwScBap13y8eJduemGfPgfn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GG6THTIzDABEUTvVGbftWogPaBzTNhibcZzq7e4AqEl7ZWHHkGFDtbCzjE+cbquLz iUoiIkCjfwZ3Z8AwQAn09jc4BWAWaS6OdRH9zPc8/ILaweZPFWVmZoHqhamJCcsm3G qALKnliX7s9id0lx/6zCYZDO42khRZaMQY7SErAU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Claudiu Manoil , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 042/113] ocelot: Dont sleep in atomic context (irqs_disabled()) Date: Wed, 15 May 2019 12:55:33 +0200 Message-Id: <20190515090656.813206864@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090652.640988966@linuxfoundation.org> References: <20190515090652.640988966@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit a8fd48b50deaa20808bbf0f6685f6f1acba6a64c ] Preemption disabled at: [] dev_set_rx_mode+0x1c/0x38 Call trace: [] dump_backtrace+0x0/0x3d0 [] show_stack+0x14/0x20 [] dump_stack+0xac/0xe4 [] ___might_sleep+0x164/0x238 [] __might_sleep+0x50/0x88 [] kmem_cache_alloc+0x17c/0x1d0 [] ocelot_set_rx_mode+0x108/0x188 [mscc_ocelot_common] [] __dev_set_rx_mode+0x58/0xa0 [] dev_set_rx_mode+0x24/0x38 Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") Signed-off-by: Claudiu Manoil Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/mscc/ocelot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c index 0bdd3c400c92f..10291198decd6 100644 --- a/drivers/net/ethernet/mscc/ocelot.c +++ b/drivers/net/ethernet/mscc/ocelot.c @@ -605,7 +605,7 @@ static int ocelot_mact_mc_add(struct ocelot_port *port, struct netdev_hw_addr *hw_addr) { struct ocelot *ocelot = port->ocelot; - struct netdev_hw_addr *ha = kzalloc(sizeof(*ha), GFP_KERNEL); + struct netdev_hw_addr *ha = kzalloc(sizeof(*ha), GFP_ATOMIC); if (!ha) return -ENOMEM; -- 2.20.1