Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp477276yba; Wed, 15 May 2019 04:50:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqyRW/ZgKh2r/JYZAnk6BIRDSzvmvPJzS94q9nrT5cYtzcN9AXNbZJJjxVTxc5Z0ko3G1Ph+ X-Received: by 2002:a62:2b82:: with SMTP id r124mr38128016pfr.235.1557921046611; Wed, 15 May 2019 04:50:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557921046; cv=none; d=google.com; s=arc-20160816; b=ZbIStDRXgkmdVojSvzCMtL8v9ifE2xxlQh9wRJssnahM/xRAlAz6xd82h+L0cznUCh PyLh5pq1R7TF/FVjYSKjTpWdk9igm/3HxKzyu+bgkGpAIp9k4ZVJI21zS7WaMUvvwmXE NE4Q2Gbg1jVBGX3hIemYTn8O4RSoAtDyzoQQhXn7PuUUG0n7pi9F3HOn4QQMpPBFQjne obXvJOdNChEC2apfmjI9TzuQQNc8RGqNyGtXjaoqpV7mohRNOebXv+qSM72872w0iKK8 iZP1RkymojbdagfrSKq5cqpHy9oXxyetpFWLeXe/STyyIZTsIyGjwqsTGISMApAq02/0 qSHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dnJ2LFmhU9jAPGHilTMo/ue9N0XgFsZLcB06YO/RW5c=; b=Q3RAe+V5lfybfHv4bv3Llz0BiUM7N6wExZ64cffmYS2KvyVyqCxatEAJI2YM9XyBZt 1ijL28/gQ3hxycitUFso7RsEtTeqe4OzrhhpD2fBvgrJAxDyEnqjD4YhkZFGX8Tsd/i5 kB9d3IakEw0EwQ26BwXE8iVqrMbCs/5gxbwapmiiZKYvHasVg4fE6Qu/7Pf9O39Ny9pH XrOz1Pb0SF4vR54cgj78+l2UoTuyzC+23N8zRD5capGInjHgzwVZXWeg+pA+x5sPgHoc Q4YSdvo1P5WfvrGRWpN+bbU4WPyIeO1izhSYQNo3RHjGnwS0dBIr8HeVOtE2ytWXRRdc gXEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LJN8gOJH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x64si1559936pgd.20.2019.05.15.04.50.32; Wed, 15 May 2019 04:50:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LJN8gOJH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731751AbfEOLYD (ORCPT + 99 others); Wed, 15 May 2019 07:24:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:34506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727636AbfEOLX7 (ORCPT ); Wed, 15 May 2019 07:23:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DEE9E20818; Wed, 15 May 2019 11:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557919438; bh=z1DY0QMRuBq/BmTsAMZFu6BRozpB8OSNs9uPgTFFqWk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LJN8gOJHHLTVMf0b/l+sKjdfqTgEiX75+isB3u4nMcqwdLsNPMKhSejYs6f+s105r TKhpazPCuSaXVStNQmYydAyBh6/PK8hl/t9wg7EJkWe6645UW9oEY2FLei5fnlRT9Q 8y9jP4TfoKy9vX7Gay9xMZcK4ENg1C6qCN2Bkg3E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ido Schimmel , Jiri Pirko , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 074/113] mlxsw: core: Do not use WQ_MEM_RECLAIM for EMAD workqueue Date: Wed, 15 May 2019 12:56:05 +0200 Message-Id: <20190515090659.157653104@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090652.640988966@linuxfoundation.org> References: <20190515090652.640988966@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit a8c133b06183c529c51cd0d54eb57d6b7078370c ] The EMAD workqueue is used to handle retransmission of EMAD packets that contain configuration data for the device's firmware. Given the workers need to allocate these packets and that the code is not called as part of memory reclaim path, remove the WQ_MEM_RECLAIM flag. Fixes: d965465b60ba ("mlxsw: core: Fix possible deadlock") Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlxsw/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c index f7154f358f276..426aea8ad72c4 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/core.c +++ b/drivers/net/ethernet/mellanox/mlxsw/core.c @@ -568,7 +568,7 @@ static int mlxsw_emad_init(struct mlxsw_core *mlxsw_core) if (!(mlxsw_core->bus->features & MLXSW_BUS_F_TXRX)) return 0; - emad_wq = alloc_workqueue("mlxsw_core_emad", WQ_MEM_RECLAIM, 0); + emad_wq = alloc_workqueue("mlxsw_core_emad", 0, 0); if (!emad_wq) return -ENOMEM; mlxsw_core->emad_wq = emad_wq; -- 2.20.1