Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp509885yba; Wed, 15 May 2019 05:23:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqyq9SHFs3NewuqvU40TsqosxhEDV+pXdsln0OO+/bmHUjFO06LKLC2q/sE1xUg+lPwJWmpU X-Received: by 2002:a63:1650:: with SMTP id 16mr44136918pgw.164.1557922993102; Wed, 15 May 2019 05:23:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557922993; cv=none; d=google.com; s=arc-20160816; b=tvy8bG4R4PcEZzFoV8USEUNaUtd3fWYzuIl1/zlS6/EmTzD7+rRQKMOMtUayAQQIOE DPuWdfhGdUF8x499eCJxIqutN7FvDGUDHdcwNnSHCivnA6rBsEQ+4lbq1x2n+s+A46Ef NhFvKjefK/qQX6kE09aZzsL8IfS05ltbHvApt8KrFa8ePzLvNf04q7FLtu2k8zDQPU7t OwJ4+fefvo5c+hXauD6/DMOwvSgq5amvlva0OBOdeG1KvomIEh2VAq+ZQwXxScudWdSa Fzm0B3gd5vJcP7SlKWK85ZvBxFb/ZSsIn7mbunk3wa0TYBodf+3I0JwNKAJcm6I51s34 b4Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kr8L61o3GV0krx+sGzDfnIN3Q4Lhxl76WC+a9wyeAek=; b=xpLcILokv7XOeKrNKEXmFZx8joEDaD/u/yse3uE7eBSteH97hA9CIHPoYfgxo1FMxt phCje/M73PDhbmmJNeMHpvCuOOOwJtveO86Xi6JMb5XJxTXM/nz52HesRz4amMEPenBr SpA1TUCTrPFE5L6bqbq0Pw+aNn0IgnEXVhSQcgUrkJ9HhxCETqZ6nSfGW1r/Nl35xQqs 1WCHJ3L9LDHik8VsfdlZU0IvXbQC7FIwm0eYaw6uTSXtq6NVV0niEztI+QhHTUZRhe0s uNaVZeuapVvlH358FHka3Qxc14sS8MTEwExoGmJYpFgikar3AB5ejWTfHkJ7Xfs/VWih Zy6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QAplHc3F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n16si1593169plp.130.2019.05.15.05.22.58; Wed, 15 May 2019 05:23:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QAplHc3F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbfEOK6N (ORCPT + 99 others); Wed, 15 May 2019 06:58:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:54322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726554AbfEOK6K (ORCPT ); Wed, 15 May 2019 06:58:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE2E92084E; Wed, 15 May 2019 10:58:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557917890; bh=gaXPwypWFs2EK0kOMSYhLWkH/Kn8KmJVLLdo5p7KngU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QAplHc3Fyxam/bYJSTukKw6EvMI2NZMUcHkjj1O4zvgmHmfmk3woLTozcEZ12qIWP qtqR136fsVnUQ278xeBqtiWjmdCDoitCg80qSP4atTvMDJtEghJA6WG1hq5J6T+hvU uITNylPjXJ/pSS68nKwupcN52k3rT+5O6ed4M0oE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aditya Pakki , "David S. Miller" , "Sasha Levin (Microsoft)" Subject: [PATCH 3.18 14/86] qlcnic: Avoid potential NULL pointer dereference Date: Wed, 15 May 2019 12:54:51 +0200 Message-Id: <20190515090645.396837204@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190515090642.339346723@linuxfoundation.org> References: <20190515090642.339346723@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 5bf7295fe34a5251b1d241b9736af4697b590670 ] netdev_alloc_skb can fail and return a NULL pointer which is dereferenced without a check. The patch avoids such a scenario. Signed-off-by: Aditya Pakki Signed-off-by: David S. Miller Signed-off-by: Sasha Levin (Microsoft) --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c index 0a2318cad34d..63ebc491057b 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c @@ -1038,6 +1038,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode) for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) { skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE); + if (!skb) + break; qlcnic_create_loopback_buff(skb->data, adapter->mac_addr); skb_put(skb, QLCNIC_ILB_PKT_SIZE); adapter->ahw->diag_cnt = 0; -- 2.19.1