Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 15 May 2019 14:33:19 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: Add rtl8821ce PCIe WiFi driver
Message-ID: <20190515123319.GA435@kroah.com>
References: <20190515112401.15373-1-kai.heng.feng@canonical.com>
 <20190515114022.GA18824@kroah.com>
 <6D5557B8-8140-48A8-BED7-9587936902D8@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6D5557B8-8140-48A8-BED7-9587936902D8@canonical.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 15, 2019 at 07:54:58PM +0800, Kai-Heng Feng wrote:
> at 19:40, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> > On Wed, May 15, 2019 at 07:24:01PM +0800, Kai-Heng Feng wrote:
> > > The rtl8821ce can be found on many HP and Lenovo laptops.
> > > Users have been using out-of-tree module for a while,
> > > 
> > > The new Realtek WiFi driver, rtw88, will support rtl8821ce in 2020 or
> > > later.
> > 
> > Where is that driver, and why is it going to take so long to get merged?
> 
> rtw88 is in 5.2 now, but it doesn’t support 8821ce yet.
> 
> They plan to add the support in 2020.

Who is "they" and what is needed to support this device and why wait a
full year?

> > > 296 files changed, 206166 insertions(+)
> > 
> > Ugh, why do we keep having to add the whole mess for every single one of
> > these devices?
> 
> Because Realtek devices are unfortunately ubiquitous so the support is
> better come from kernel.

That's not the issue here.  The issue is that we keep adding the same
huge driver files to the kernel tree, over and over, with no real change
at all.  We have seen almost all of these files in other realtek
drivers, right?  Why not use the ones we already have?

But better yet, why not add proper support for this hardware and not use
a staging driver?

thanks,

greg k-h