Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp548078yba; Wed, 15 May 2019 06:02:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqwyogex5+JNlTYOHvP970HWDm/0klLyUoE8jtToM51EtKN438fjt2dKlqC0nf3233VqX2rv X-Received: by 2002:a17:902:868c:: with SMTP id g12mr26362089plo.323.1557925375891; Wed, 15 May 2019 06:02:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557925375; cv=none; d=google.com; s=arc-20160816; b=aCJn7eahppU3nWrFfTwOiTsaFptq0ViVdkALxobXaOI+WI7044vaIcGy9Jfl+r3A59 +3mfgA2etnzBhD0uuboIJv5ozFolr/cpLBd6V4THFt2r2nPktFLnZyN9ToKL4rZnodfm dgS0zOFQ0umo0HOeUTahClIX8IzRG3V4AclVGsKHGJZ8qe34M6PpCoiTLjZoUZ/67VCb YpDR9HpuMIlvQ985LpMvqwjGYBJZPl8a7j60WatBwJGogKQWo2WpjykN5LSiIAJyiZNc 25bagrpSn4O42CvGNj1igueXrJVg9i/J5GoVDUwy+DeDdeWRU0j0Ak0Y2lSZsqeb11+Q BAVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=C6stu1BoyR0Py1ij+5CdCfvokpPNHmVdpSihS15+YWg=; b=cnAKe+0thi5Gu1lYwRK+SijOCQfOCmwwHRn7h7MCzwTidsy7EWjaL+M/4VPKp7v7H3 vdKi5wnVAXfyI0iJ2Zt75Co9I6uhF4YBepNzhjgJJdXEfFJy82WvePfXtgqiKSkuzeF1 KAn3zvQSkqZYoBNBpNdmTr3GlRjYS/a4B1RLYZbLeHHGZinpi2uTXUMtqR4H9hOwghqM 5614qh/JHJR7kYe1uzxgXlM8Emiw3wr1oXZhOpdRJlxJ42sfppWcnTId2yMCrkoA3fLP gdLJ79HbfA04/Rd92NCvunm1p5xw69JotbMf+NN3XaLQNe8fbHJmjlbWc+wKDZF64bW5 DnSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bj5si1671160plb.406.2019.05.15.06.02.36; Wed, 15 May 2019 06:02:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727300AbfEONA1 (ORCPT + 99 others); Wed, 15 May 2019 09:00:27 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:59434 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbfEONA1 (ORCPT ); Wed, 15 May 2019 09:00:27 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id EC2FE27BA8D Subject: Re: [PATCH v3 1/2] platform/chrome: wilco_ec: Add Boot on AC support To: Nick Crews , Enric Balletbo Serra Cc: Benson Leung , linux-kernel , Duncan Laurie , Daniel Erat , Dmitry Torokhov , Simon Glass , bartfab@chromium.org, Oleh Lamzin , Jason Wong References: <20190417012048.87977-1-ncrews@chromium.org> From: Enric Balletbo i Serra Message-ID: <7c672532-e1f4-0e10-94a0-728a7fe575cb@collabora.com> Date: Wed, 15 May 2019 15:00:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/5/19 18:09, Nick Crews wrote: > Thanks for the review Enric! > > I can resend the patch with the fixes, or if you think the fixes are > simple enough, you could tweak them as you apply them. Let > me know if you want me to resend a clean version. > No need to resend, I tweaked them. The patch is queued to the for-next branch for the autobuilders to play with, if all goes well I'll add the patch for 5.3 when current merge window closes. Thanks, Enric >>> + >>> +static DEVICE_ATTR_WO(boot_on_ac); >> >> Is not possible to read the flag? From the API description seems that it is. > > It is not possible to read the flag. The API description is wrong, > I'll fix remove > the line about reading from the documentation. > >>> +void wilco_ec_remove_sysfs(struct wilco_ec_device *ec) >>> +{ >>> + sysfs_create_group(&ec->dev->kobj, &wilco_dev_attr_group); >> >> As Guenter pointed: sysfs_remove_group() > > Yes, exactly. >