Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp564914yba; Wed, 15 May 2019 06:17:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqwawL8Ho2gRq7jsZgG344yNGMoA+AxDqCUO0ek8Azq6mgIjeBICsVcAblAvElw28YfZH9/r X-Received: by 2002:a17:902:ab98:: with SMTP id f24mr42814614plr.223.1557926226707; Wed, 15 May 2019 06:17:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557926226; cv=none; d=google.com; s=arc-20160816; b=MluMGGiMj9lu1a9p4yFJl8mOu7zi9CWfJii+3Fm3yIgtRitU2gDdDQGDyYQXBkLBAk gaskmMW6yR6BvcHXwPFjr5tm/F9El7NYa6+qo4Pllwke+g7DbZpuIpYIFP8LVdhKJEOf CQsG8KVNXyXNpgQ1LoJd3GYRPjMYlRgRRgEt0jRwXIvcFlM1DMxoM3zfgKX0v2xocEbl itNMgrEyxe9C2uDPJQX58Nj/4IMwp1uNJJILnXGnrc2TtWHOO0ccXYOskzHU6ozurJZG HerqzlDe5/15xHS1w+1YM3FVHdG7J3YOXKM1Hp3IcO29/vBOjf0LF1HSdBG9SoHpziPX cgQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=AyFACiWTp3aKjfUBwEnUu0WG1DOJlwF3PCOsQcuUqWA=; b=cSxTABu1rxrQdm+54CH4Ju2uJVN0QJEGJlSdTapB/BRnUD4J3513zxak3SVNBRD0y8 H0boSnpnRafomv0NWkQYhy9lgfOX8jJ5w3r2tmSR8DmbZ+HqhAXiEFEsHsk+KZMJ4zIt j0tsL3j3mwnRZVTAMMi9GnLWJkBtT7K7LNqS7Z4hK25tLthw9Tu2vMIr8WHrvXPAHKyo RCHZ5rPe8mT6o2XYUgei3VDssU8rjT48IaYtSnzrOOhamqwVemPdIlvkHuhjqGUHlKFV DPqt/EQeIiYU9tNqLkVoVLp/1bmwDS7ifpZvEdKkI2Dc7kfV8FC8075rArt1pOpum4Lg H6bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YWZQTkhW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e3si2112941pfa.155.2019.05.15.06.16.50; Wed, 15 May 2019 06:17:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YWZQTkhW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbfEONPc (ORCPT + 99 others); Wed, 15 May 2019 09:15:32 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:36100 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726752AbfEONPc (ORCPT ); Wed, 15 May 2019 09:15:32 -0400 Received: by mail-pf1-f195.google.com with SMTP id v80so1367256pfa.3 for ; Wed, 15 May 2019 06:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=AyFACiWTp3aKjfUBwEnUu0WG1DOJlwF3PCOsQcuUqWA=; b=YWZQTkhWIqwZYS3NJiPxmflNVTDKBAgSM0ZG2CbE+UQZOeSt7jhlAR+znBPfjI6QmS wUlxiaK6skwmXDz5Rbv2RtDx+j5lyAZObR6S0CbC4T6h4baeF3fBEhRAReZUSpr1f2fI inYxaMfEBy8eAykUr2JXl78hAlpmvrYIvaTlVim3BzD3lR1WiyHT7Srf/q6HtIwnniJq TupTXlCE9dWa6PjctkfkPMQmfzj0WmekOEdOH7MUn3UVF/FUld/+AdVMVKySXOfx/vjx ErPmqVC9cSaI/2Nuq+05G+e7yXMKEdXh3p3mH04X3HT/BlE3R/rVKqSV4J5uChX94vlp hAdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AyFACiWTp3aKjfUBwEnUu0WG1DOJlwF3PCOsQcuUqWA=; b=kQoXw2pV5LNX5u3fXMQqHywrSKYSD0ntvZ+YyocHhJ/mFLeb4a5zbOAqUTDsK9oCm1 +FynrgPYssEblgtBuQ+uJVWyzhXp2dbpTLCzOwiVdLfXrKVDSyENdFk+piw7tTD9l26s EFCEeHFjJ++LEDuHG/jpEiN168fe2xaEgToUl6Ql/ubGnGidQps9BFiVzppy5JlR3MQ0 p5Y4fRIh1/gv09BOD6ZeNZH57vicVFVYMQrYmiCO+cxXJ3iV7ICV5d8/5zqldp3VTjSM g7BzJw7q+ThSjVf4D3icT8gSsrTWucjrtkA6loTDes6vS8tDTcToDRQlM3YXCwG7ayvQ r7qA== X-Gm-Message-State: APjAAAWInE8RFLOtJnlvP6//fckvUpxk2ZvqxHmky7HVHkJOajPOkZS4 uW9M8j/pFzvNE1gQ/EuLoX0= X-Received: by 2002:a63:318b:: with SMTP id x133mr44446918pgx.297.1557926131728; Wed, 15 May 2019 06:15:31 -0700 (PDT) Received: from hydra-Latitude-E5440.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id k26sm2687147pfi.136.2019.05.15.06.15.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 May 2019 06:15:30 -0700 (PDT) From: parna.naveenkumar@gmail.com To: arnd@arndb.de, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Naveen Kumar Parna Subject: [PATCH] bsr: do not use assignment in if condition Date: Wed, 15 May 2019 18:45:24 +0530 Message-Id: <20190515131524.26679-1-parna.naveenkumar@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Naveen Kumar Parna checkpatch.pl does not like assignment in if condition Signed-off-by: Naveen Kumar Parna --- drivers/char/bsr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c index a6cef548e01e..2b00748b83d2 100644 --- a/drivers/char/bsr.c +++ b/drivers/char/bsr.c @@ -322,7 +322,8 @@ static int __init bsr_init(void) goto out_err_2; } - if ((ret = bsr_create_devs(np)) < 0) { + ret = bsr_create_devs(np); + if (ret < 0) { np = NULL; goto out_err_3; } -- 2.17.1