Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp681440yba; Wed, 15 May 2019 08:11:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqzceXCslZ24baKvlwO8v0l6pRS66VLQVDL3TR/20VT62fxomc+VTbg213HwOSKQVF/nPHXy X-Received: by 2002:a17:902:b489:: with SMTP id y9mr42825905plr.70.1557933063397; Wed, 15 May 2019 08:11:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557933063; cv=none; d=google.com; s=arc-20160816; b=aoNBDaIuOEchJkeHF89bL6a9be8LAzDK4RSuXc7iLAyXJ7FgGXLykP/LxD/BZNtl/C nQayFGa245n42ThjpdPF8DVoV4gSu7LE+s5LOpWB/CgZkkrn82IYlThoBBjRKrUyfMlI rNbPCQf85CPrqCZj8mhMq9K4cK8q1/x8HSSV0SWSUHzdGIgJHEN5wZwrOv+VgsaR0ejv jtEHCQDx3trm82bLIVJMGULg98R+m+Wck+/W4Poyacpyn2KPhqjvqgkBlYTpNyTbbAoX urdGrJ7GTuMAJodI2WMsh5+WdRVAKov/uo4ROua5zTqBX7KujgVATPt8TJUtespE7vtz 9Q8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=FzdAY9eNLFH6q18HeEB4S9VM37pJLDSHQjylPsT3TbY=; b=qRuN+amHjbxKALb2YHh8usp7o39jhMZ7vEv70clrcPTGpcpRCfioW2ITAMAD0mA6UH i6+QyVgj/42QX16Spzp2v2steKwW4AXcNESbv0jntmLMRULbfR1fPEukAZO/NKVi0ar0 rScxNAguVKKlk6CrOE9rofeIggPHvqVYW0RpTW/mQj3gVES+arUkldQUD8OFCy1ZNspw oJJHNdqn3GGneAkbdIQ4KOTjJEniNDnTSWmqnSmOW2GUtV3dRG76fdIPNVGuHAcl1RfK TFgOMODtVu4kNh4/BdXTUFraYMqsWPREw2Yebxtm96jGaXx4QXs7jgkSMG+Z/E08G4Zr obAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MjJ+LF+8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h5si794734plt.232.2019.05.15.08.10.43; Wed, 15 May 2019 08:11:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MjJ+LF+8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727313AbfEOPJZ (ORCPT + 99 others); Wed, 15 May 2019 11:09:25 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:38484 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726572AbfEOPJY (ORCPT ); Wed, 15 May 2019 11:09:24 -0400 Received: by mail-oi1-f194.google.com with SMTP id u199so19153oie.5; Wed, 15 May 2019 08:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FzdAY9eNLFH6q18HeEB4S9VM37pJLDSHQjylPsT3TbY=; b=MjJ+LF+8pBMZJmrf/PUQGYzx6jkAIvZXVOaDkwDUy9j8LjnckyRKVimNt3qRpZ7QXs odt09gcUESirFG4LKGWD8wrs44NwvpmYA2lxf+ihQ7feGSSECN829NXz97xTZk1YqWok 35/lGba1azoqDEabJk9bWsU7/bkhsjO9nkRYDhC0oT9sbfj+MNtAHSqEKLAJhOF3S6Rs R+rUWZGYA0dVjK3uQ9i1dVZfPXcCRFzlBj3LZ2YdHmMedSaa4kOtX9v0QZ8SKRLyhu7Z yvA1skM2zKLs6y+yPy3x/+CSXqODR2VRcyLDYU2/3JhylYVvTFrpq49h0oyAJEL7ENkN jPtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FzdAY9eNLFH6q18HeEB4S9VM37pJLDSHQjylPsT3TbY=; b=rSQxCXZ7QavzWRWgkflSEk87bo14SgVlvLzbfqgB0pNmbsdXtnlvhhbQgYBNTv/Sx0 F3DP0/7XyPKgyLZ9jxa4H0TcQMuJERs7jSaiSZbCCOSkHBQAE235B2kqm3BhN8hcjdWb /U3QQZTKCMJ3y5G9vLUZZipX2uBSm/rrZdtFDFBk/UHhu0PBamd8FJHBJ7KYCSPoFzzv GTBo0lI9fnFkMt90Z9S6W/JtKkKTMyYHqy8e9ovsn8lpFOyqzrBOZp6Rnrn1ezgxMCnc raqC01dqPPqVhr/jMSln0jl/1wx6hYe3vVg+OIsoJbWdKJ/447hz8OvLBzEnrHu7GGoE WZJA== X-Gm-Message-State: APjAAAUhgiW2+wuUBRqtwYfSgvynFpNBA/dUtRIQI3n9ZbMaPH29aoDB 6EIgkk6YovpedHN99KIZpDrtsi5S14Ahqr4qKZ0= X-Received: by 2002:aca:240d:: with SMTP id n13mr6735433oic.145.1557932964018; Wed, 15 May 2019 08:09:24 -0700 (PDT) MIME-Version: 1.0 References: <20190514155911.6C0AC68B05@newverein.lst.de> <20190514160241.9EAC768C7B@newverein.lst.de> <20190515093141.41016b11@blackhole.lan> In-Reply-To: <20190515093141.41016b11@blackhole.lan> From: Vasily Khoruzhick Date: Wed, 15 May 2019 08:08:57 -0700 Message-ID: Subject: Re: [PATCH 4/4] arm64: DTS: allwinner: a64: enable ANX6345 bridge on Teres-I To: Torsten Duwe Cc: David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Thierry Reding , Maxime Ripard , Chen-Yu Tsai , Andrzej Hajda , Laurent Pinchart , Icenowy Zheng , Sean Paul , Harald Geyer , dri-devel , devicetree , arm-linux , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2019 at 12:32 AM Torsten Duwe wrote: > > On Tue, 14 May 2019 10:48:40 -0700 > Vasily Khoruzhick wrote: > > > > + anx6345: anx6345@38 { > > > + compatible = "analogix,anx6345"; > > > + reg = <0x38>; > > > + reset-gpios = <&pio 3 24 GPIO_ACTIVE_LOW>; /* PD24 > > > */ > > > + dvdd25-supply = <®_dldo2>; > > > + dvdd12-supply = <®_dldo3>; > > > + > > > + port { > > > + anx6345_in: endpoint { > > > + remote-endpoint = > > > <&tcon0_out_anx6345>; > > > + }; > > > + }; > > > > It doesn't comply with bindings document. You need to add out endpoint > > It does comply with the bindings. The ports are all optional. > As far as DT is concerned, the signal path ends here. This is also the > final component _required_ to get the Linux kernel DRI up and running. Ugh, then bindings should be fixed. It's not optional. It may work if bootloader enables power for you, but it won't if you disable display driver in u-boot. > > as well, and to do so you need to add bindings for eDP connector first > > and then implement panel driver. > > See Rob's suggestions here: http://patchwork.ozlabs.org/patch/1042593/ > > Well, one *could* extend the hardware description down to the actual > panel if necessary, but on the Teres-I it is not. I assume the panel > they ship provides proper EDID to the anx6345, because the display > works fine here with this DT. I guess you're testing it with older version of anx6345. Newer version that supports power management [1] needs startup delay for panel. Another issue that you're seeing is that backlight is not disabled on DPMS events. All in all, you need to describe panel in dts. [1] https://github.com/anarsoul/linux-2.6/commit/2fbf9c242419c8bda698e8331a02d4312143ae2c > Do I understand this correctly that the (3 different?) pinebook panels > are not that easy to handle? I try to include the pinebook wherever > possible, just because it's so similar, but here I'm a bit lost, so I > had to omit these parts. > > Should I also have added a Tested-by: ? ;-) I don't have Teres, so I haven't tested these. > > Torsten