Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp689370yba; Wed, 15 May 2019 08:18:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqw89eAtadFmzn2MZs1JsXqTU8Yy2M7MPIypRYFu23awzOR4NEMx2O2Hz7QqP2auOGnHt3Ur X-Received: by 2002:a63:7054:: with SMTP id a20mr30988925pgn.354.1557933487606; Wed, 15 May 2019 08:18:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557933487; cv=none; d=google.com; s=arc-20160816; b=xtgCTLRosCjGNn6oXGokHSwFhEH7nWfrfejzOS1EXDckoZDCKyHS1fGhaPanaqowYb JAJDFLGitA0Ekm0TCxLzCZeUse43Po0ADJ+AyAWvy2nFALljhZUIXcdO7iePmDbXHARg 0TkejrTyYE2iqTgWfIb2qBYcGNQHOcziAIoE2zmnhQx08Ih3ezr06AmgMBRE+eORTYqn Q9h+d8qkwWX9VjBCO1Fd5RZG3BP+niZ2yIL/Nf3trvNTDQRhtTUmQAOcJq/U+ND7X8jO a7FlB6T1HcB5vhHJS7RqX8qq0xNwKm849GWemZ3KFTZuqwSDsn104RVPmWa/fcTrIDKA PwUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=q9RT5GKRL4MaUdYf3zAn8WjPlL/IeoKRLWXVU5nD1oo=; b=kERIc38XZIEsDLYQQjxi8LBSeVFb6b/6aKRM4b0jNOt4nwj8d+/oJ/QquNLc64/osT N2RFmxzGl5NpMdUiHJW/OEkXDwI7zlyo36LQhLgx22CR/W47/5fBZ0K7Aj168JAxwnNT bMON2komDdk3nDdT6iLEWzpcXQbnFSByupfZNJhyiAbv/tgZplgxF2KgYOrKgLzIfEZ4 dFEmlb3S1Imxzm0eyezkTfWEtbUWUrQkhDiIQudWK01p4/+Q1RmSkg+s2x+9dzOVJdxI G8KFvX2LED6WB66SkBAzK9b2E3YT2IS7EsGG9TiTz3MxNftsLD5DQG7i92Ag8EDxseeB sGwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=roUMvtwT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si2290784pfn.66.2019.05.15.08.17.52; Wed, 15 May 2019 08:18:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=roUMvtwT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728383AbfEOPOe (ORCPT + 99 others); Wed, 15 May 2019 11:14:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:60458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727201AbfEOPOc (ORCPT ); Wed, 15 May 2019 11:14:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A49720862; Wed, 15 May 2019 15:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557933271; bh=wAXhv4H3xhTROOTCsRyszjk2olnSUxpBZuWpsvCIapY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=roUMvtwTq5trbCZEn1OhK4E8LzDyV6EeNPzfZGkP9fGGV4RNDZCaeYq8XigQMpZC3 AN4jYTTfg7g2HCqSqBtT9JbQDgQJVFJiQgZa0NDDpsxm+VMDp7vwz8fkqS4vLjk1j3 NAILRbyIcAbV+GK02RVeUxGa8XOHR7mhKte+ZDZ0= Date: Wed, 15 May 2019 17:14:26 +0200 From: Greg KH To: parna.naveenkumar@gmail.com Cc: arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] bsr: do not use assignment in if condition Message-ID: <20190515151426.GE23599@kroah.com> References: <20190515150952.28570-1-parna.naveenkumar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515150952.28570-1-parna.naveenkumar@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2019 at 08:39:52PM +0530, parna.naveenkumar@gmail.com wrote: > From: Naveen Kumar Parna > > checkpatch.pl does not like assignment in if condition > > Signed-off-by: Naveen Kumar Parna > --- > drivers/char/bsr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) If you do a v2, you always have to show below the --- line what changed from the previous version. v3? :) thanks, greg k-h