Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp768846yba; Wed, 15 May 2019 09:36:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqwjsfFM1r6NbeTaivYoIPtecpcUAa0eT1wEvm1bt6HBwLjurwuTVGNPwuzkMq9cgWyGT/8p X-Received: by 2002:a17:902:9007:: with SMTP id a7mr43888730plp.221.1557938166538; Wed, 15 May 2019 09:36:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557938166; cv=none; d=google.com; s=arc-20160816; b=fXWGlTwAeWkgIdnKPMWVB2mDddOF5uFbEw/prdwEBqLUhHCf8UmWFDTt7TQaeXTuX+ kLC+kxGADi8y2viJZrs7Dgd59AWKPPRiXxRj2ymnYQik2njxWBj0j+Hp9nNPl83WWu7Q gmKIvFpvF2HAeuWfSOsLjIs49jY4q44o9l8CuXY1JP2X+tC9VyXrNTahnWrdG3N1/Ktv Tg092j60p2nkkQaCi2qV0+80G0ujXcV8LXnBKhWKe0AayEQd6VPjgthmMXDJRRNZ9ZHK +sCoVo74irZoGoT7a6MNZiI7ZOSawm9ygM7zKhIIX7MXYYOzYHiQqGfYzCCc+kDyLtB6 Zujw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2C5ZLXS5pnK1SekssJfYLby68kNl/Hg91yqFVlQmDMw=; b=sVhEM9c6ZBixJ0SlO96ENjf0l4aCRI6BcY2YL60HV+zzyHTaue4zVr7lKPCEaQCZMh dgRI1Ze8M8JX88ObTEMYvlD87AT6FaNNGtHoJH2O4BqCYsRXSzzYZwNFKMvFzlov0/rf UZuDSiFtVWlE/yR75id3wq1P95cGIrriBPNVjgLUJAuWfPF5nQ0LFQJL+xz2kYcG5KCx tP60fXvJRkPgrR0dwGu82ZNKY6QJJRx8cKoghcA7kt2siNzRZrraIqFJPHYoMSQ8BN3Y LCPE6HIqQ8HLtShtzTHDnNF9VlY4/Ip3UpZKtrkO15cYqu37zkkmYTRqUmnWn2nkJW5Y 5E/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=nMdKe4p3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u19si2142644pgm.471.2019.05.15.09.35.51; Wed, 15 May 2019 09:36:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=nMdKe4p3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726709AbfEOQBu (ORCPT + 99 others); Wed, 15 May 2019 12:01:50 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:33740 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbfEOQBu (ORCPT ); Wed, 15 May 2019 12:01:50 -0400 Received: by mail-qt1-f196.google.com with SMTP id m32so305940qtf.0 for ; Wed, 15 May 2019 09:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2C5ZLXS5pnK1SekssJfYLby68kNl/Hg91yqFVlQmDMw=; b=nMdKe4p3aF+xVyxfSk0pT8Zlqzg6/bn0U+5PqM0uOEZbamU2dToVvVrtN1ODTZKa0X EFkVsBDayJ2NH3cs7kMkrA1sYkJSKH7rRTHYhXvjPOx9CTVgQgCWE7Lj2XmmrwVM9hf+ T5psHQVnACl/TqF+KUv18k3P/VR2QhgByTB1xwMGgmqa/mnfQD1M4JGZcuwvfOFFtxRz CItw9xiMnUyGWj6YFfe0jVyKELSEInBr+SoekmkF7yEPzwjMmBZHiTU7469kTxaRUd5x TN6749/HLAk/HJl7jGdpNlnbOhNeM5C7tzfPOwSxCOjB65QuEoEa8VHvIRnQfO/GWGLR o5TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2C5ZLXS5pnK1SekssJfYLby68kNl/Hg91yqFVlQmDMw=; b=GW/fKQX2eA8ZHIRhnapXKShPrQMG/pqDsg1t+Ez90Bxo3EOjpbwuOZu/nJjB4hhPaF /3QG1SjWhbQqu8OY8kQaqQQokoMVxJaOCWzqA3Mt0kCA0wUJaXiioheE58fNIwxFAap9 vjZkpLuu5bC+4sdasVim5H+byyw/+L3X2zjZhs8i51+u56biJmzXnYWO5nVRQAXqrQWJ jX2pJd1Dnv1AQgRcltZfA09dUxnmWTf+VHkasVTBOLARB1mOTBA4A46dDQJhCX9TvyUq e8lAPp5btHLjYZaEYGpFHFgoX0FGYBDu8IVvs+jd3Nx3VfcF7CzvJc8sCq3o+1esWZQ5 EZuA== X-Gm-Message-State: APjAAAVstU2lNS9ARpdsHp7mmML/ZfQJm77rGzA0wrW04LarkovJtfvU 03rENCM5gwch9MUCrzjmuGmNTQ== X-Received: by 2002:a0c:9ac8:: with SMTP id k8mr34276654qvf.132.1557936109209; Wed, 15 May 2019 09:01:49 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::bca1]) by smtp.gmail.com with ESMTPSA id z63sm1204403qkb.7.2019.05.15.09.01.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 May 2019 09:01:48 -0700 (PDT) Date: Wed, 15 May 2019 12:01:47 -0400 From: Josef Bacik To: Yang Shi Cc: josef@toxicpanda.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: filemap: correct the comment about VM_FAULT_RETRY Message-ID: <20190515160146.te5tpydtclguxs6a@macbook-pro-91.dhcp.thefacebook.com> References: <1556234531-108228-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556234531-108228-1-git-send-email-yang.shi@linux.alibaba.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 26, 2019 at 07:22:11AM +0800, Yang Shi wrote: > The commit 6b4c9f446981 ("filemap: drop the mmap_sem for all blocking > operations") changed when mmap_sem is dropped during filemap page fault > and when returning VM_FAULT_RETRY. > > Correct the comment to reflect the change. > > Cc: Josef Bacik > Signed-off-by: Yang Shi > --- Reviewed-by: Josef Bacik Thanks, Josef