Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Cyrill Gorcunov <gorcunov@gmail.com>,
        "Kirill Tkhai" <ktkhai@virtuozzo.com>,
        Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 5/5] proc: use down_read_killable for /proc/pid/map_files
Thread-Topic: [PATCH 5/5] proc: use down_read_killable for /proc/pid/map_files
Thread-Index: AQHVCvoDISknOLVQ6k6bg7diwORU3aZsaUuA
Date:   Wed, 15 May 2019 17:00:07 +0000
Message-ID: <20190515165956.GA7845@castle>
References: <155790967258.1319.11531787078240675602.stgit@buzz>
 <155790968346.1319.5754627575519802426.stgit@buzz>
In-Reply-To: <155790968346.1319.5754627575519802426.stgit@buzz>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:180::779]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 92b3c1fb-46a7-414f-fff4-08d6d956c863
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020);SRVR:BYAPR15MB3335;
x-ms-traffictypediagnostic: BYAPR15MB3335:
x-microsoft-antispam-prvs: <BYAPR15MB33358990A201ABE1D0176103BE090@BYAPR15MB3335.namprd15.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:299;
x-forefront-prvs: 0038DE95A2
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(366004)(136003)(346002)(376002)(39860400002)(396003)(189003)(199004)(6916009)(5660300002)(14444005)(256004)(14454004)(52116002)(73956011)(66946007)(1076003)(4744005)(66476007)(64756008)(66446008)(86362001)(7736002)(33656002)(33716001)(6436002)(2906002)(229853002)(54906003)(66556008)(9686003)(6512007)(4326008)(76176011)(305945005)(99286004)(6486002)(25786009)(476003)(68736007)(102836004)(446003)(53936002)(81156014)(11346002)(6246003)(6506007)(71190400001)(8936002)(386003)(71200400001)(486006)(316002)(6116002)(46003)(478600001)(186003)(81166006)(8676002);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR15MB3335;H:BYAPR15MB2631.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 6/RELJ0RRVug8wSQJMo+82B8MKiw/XhwU9vW+V9iWxDtK7NiN4HF/jEeL+y2YFLZwH1BuDrLJRHufY6kuk8JGHqDafV8sTgw5G43jD4q/FZm8YYQWm6vKu7HfsIHheqmi/USG8iHr43aL4UCTQ6hvCHidgYjvUPpao1kB0gBTdbvK3NCMjhCNjZMATiYbVImGYGA41j7SdbIDhJG7W68uX0YamVF9xJE7a5wcvpLRIKm0QyUSbZkC6W1ylQJNkoUMWohJwJTHp/z1o/v+1/Dgb9s9VM7aNcIBt0W0f5quMvHszHzggTsjg8ekA34LNrVmXlkY7U45D3sR9fjjED6fzl2Vr1gIxt8Gtt9pIH/hQfsfInwooXo6avluymLy8guYokv2pSYMwWfeYrQVXP0ZX+HMW5e9U1tUKGHpqOcMZo=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6D5C73FF056CC549AE708161877DEBF7@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 92b3c1fb-46a7-414f-fff4-08d6d956c863
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2019 17:00:07.5053
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3335
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-15_11:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 15, 2019 at 11:41:23AM +0300, Konstantin Khlebnikov wrote:
> It seems ->d_revalidate() could return any error (except ECHILD) to
> abort validation and pass error as result of lookup sequence.
>=20
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> ---
>  fs/proc/base.c |   27 +++++++++++++++++++++------
>  1 file changed, 21 insertions(+), 6 deletions(-)

Hi!

The series looks good to me!

Reviewed-by: Roman Gushchin <guro@fb.com>
for all patches in the set.

The only thing, you need to add a bit more detailed commit messages
to patches 2 and 3.

Thanks!