Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [v1] drm/arm/mali-dp: Disable checking for required pixel clock
 rate
To:     Wen He <wen.he_1@nxp.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "liviu.dudau@arm.com" <liviu.dudau@arm.com>
Cc:     Leo Li <leoyang.li@nxp.com>
References: <20190515024348.43642-1-wen.he_1@nxp.com>
From:   Robin Murphy <robin.murphy@arm.com>
Message-ID: <3f87b2a7-c7e8-0597-2f62-d421aa6ccaa5@arm.com>
Date:   Wed, 15 May 2019 18:14:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190515024348.43642-1-wen.he_1@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 15/05/2019 03:42, Wen He wrote:
> Disable checking for required pixel clock rate if ARCH_LAYERSCPAE
> is enable.
> 
> Signed-off-by: Alison Wang <alison.wang@nxp.com>
> Signed-off-by: Wen He <wen.he_1@nxp.com>
> ---
> change in description:
> 	- This check that only supported one pixel clock required clock rate
> 	compare with dts node value. but we have supports 4 pixel clock
> 	for ls1028a board.
>   drivers/gpu/drm/arm/malidp_crtc.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
> index 56aad288666e..bb79223d9981 100644
> --- a/drivers/gpu/drm/arm/malidp_crtc.c
> +++ b/drivers/gpu/drm/arm/malidp_crtc.c
> @@ -36,11 +36,13 @@ static enum drm_mode_status malidp_crtc_mode_valid(struct drm_crtc *crtc,
>   
>   	if (req_rate) {
>   		rate = clk_round_rate(hwdev->pxlclk, req_rate);
> +#ifndef CONFIG_ARCH_LAYERSCAPE

What about multiplatform builds? The kernel config doesn't tell you what 
hardware you're actually running on.

Robin.

>   		if (rate != req_rate) {
>   			DRM_DEBUG_DRIVER("pxlclk doesn't support %ld Hz\n",
>   					 req_rate);
>   			return MODE_NOCLOCK;
>   		}
> +#endif
>   	}
>   
>   	return MODE_OK;
>