Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp899011yba; Wed, 15 May 2019 11:55:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqzEvHAysocQm6kEbrJrKK4Bx3WPFXqXwgJWySc5Af8/TsaykPv7qWASFlMTcTw+HJYR+T+W X-Received: by 2002:a63:5c25:: with SMTP id q37mr46717032pgb.263.1557946538188; Wed, 15 May 2019 11:55:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557946538; cv=none; d=google.com; s=arc-20160816; b=lANODZVOfW35zzu6XhKdrY9wn97pBegHvrSqSoqS6IHm6JZgkr/9+jhY2ppMiIxQKb nVsIqOZ9c+QbT2zrE8/rViknOiqsyJUAbQTEHJROWERTRZ1Dj0X3asypkDF2dyzLHV85 41fs4W8We09+6ZkFoXs7jsrU4bk5XwAJgrC9V/hgUGGozUNeelFmCv1kQ5qjsM8yjQY8 7nAPlCon3BTLpa4UZjrUUvR8hY+hfbALf/4now4NJkdpUsEYomD8FFKLv9dnoLka+qMo BKRPdocv6C1sds4fypXO14evawwtGekWUvDylO234XQBRUCj2TSbnHMminaNCj8V5GPO 0xgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=F+uKuYKH8D9C30taRndDf2f3BiyObetVuhxljsMhA+w=; b=C7rGtJxl17jeRvc2w+1E+8HPLiP2dW+fL6fsAZ/Xd3hg1BSJhKQQ7hmo7zHHEth3OD YYhbfQ+OmBKS0HlNBLhumyAD3jllOyOnFpTw/U5+FdZ4GrhdJpaH518HoTdZNkR2mcZ8 Ills13PyDPE4TRiSHKQebKhowngMTS2sWR8WacCi5F09aaQE7DVHDQb45JHXswbXAXMx 0e9VTBwbEevaBH+rk0CjpZ6pPuG1RghgNi8wXEGBXdvG5o9AjAOEk0+MHEI64i67m63C XRPhpNvr+mBQ9lMts7ZACJSIvKSpPDwExsvpziPCha/rKOFDPoqSUmg/Xos+spVLFArc pdKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si2464070plr.156.2019.05.15.11.55.22; Wed, 15 May 2019 11:55:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727084AbfEOSxC (ORCPT + 99 others); Wed, 15 May 2019 14:53:02 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:36555 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726392AbfEOSxC (ORCPT ); Wed, 15 May 2019 14:53:02 -0400 Received: by mail-ot1-f68.google.com with SMTP id c3so1036655otr.3 for ; Wed, 15 May 2019 11:53:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=F+uKuYKH8D9C30taRndDf2f3BiyObetVuhxljsMhA+w=; b=dTqiLoCH2iQkNJUPDJknBnM3tDtd768jhXToiFyVq4ug5i6Vakk6P0sQk/1fhqy7W4 kX0YLPugcPJcC2Pv8v10vwL1hm+3Ju3gROtHO3i2yI/HMlOW8GXAc4J3ae8ELir4o/Ui RrYh1KWyfn6+NYgfqyUCHK6XxkFl2nKO8w/JqpQXpdpPT5212hUXuZmt/bAkT6MH5dzi NIyWVJlddrSiHpwv6eCX/OVVXZpsAfPduSGCjqweBBKvy2pGI/pyXMnEoPdKM2bYO0Xm cjAaN8mhTuZyN3yoQdVG4Du6zHIHCdC4TTFcINrEvttd+efVT6quenheBcGiJUrwqiZ0 mbSA== X-Gm-Message-State: APjAAAXxAkT9T1zP7yX2/EnBHY3R+oTMFl8bCjLlxnDXWNoJx+JeTfcH 52L8CkaQRZVpp6Ha4s+oJqc= X-Received: by 2002:a9d:7643:: with SMTP id o3mr17247096otl.129.1557946381574; Wed, 15 May 2019 11:53:01 -0700 (PDT) Received: from sultan-box.localdomain ([107.193.118.89]) by smtp.gmail.com with ESMTPSA id h23sm1062735oic.10.2019.05.15.11.52.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 May 2019 11:53:01 -0700 (PDT) Date: Wed, 15 May 2019 11:52:57 -0700 From: Sultan Alsawaf To: Steven Rostedt Cc: Oleg Nesterov , Christian Brauner , Daniel Colascione , Suren Baghdasaryan , Tim Murray , Michal Hocko , Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Ingo Molnar , Peter Zijlstra , LKML , "open list:ANDROID DRIVERS" , linux-mm , kernel-team , Andy Lutomirski , "Serge E. Hallyn" , Kees Cook , Joel Fernandes Subject: Re: [RFC] simple_lmk: Introduce Simple Low Memory Killer for Android Message-ID: <20190515185257.GC2888@sultan-box.localdomain> References: <20190507021622.GA27300@sultan-box.localdomain> <20190507153154.GA5750@redhat.com> <20190507163520.GA1131@sultan-box.localdomain> <20190509155646.GB24526@redhat.com> <20190509183353.GA13018@sultan-box.localdomain> <20190510151024.GA21421@redhat.com> <20190513164555.GA30128@sultan-box.localdomain> <20190515145831.GD18892@redhat.com> <20190515172728.GA14047@sultan-box.localdomain> <20190515143248.17b827d0@oasis.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515143248.17b827d0@oasis.local.home> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2019 at 02:32:48PM -0400, Steven Rostedt wrote: > I'm confused why you did this? Oleg said that debug_locks_off() could've been called and thus prevented lockdep complaints about simple_lmk from appearing. To eliminate any possibility of that, I disabled debug_locks_off(). Oleg also said that __lock_acquire() could return early if lock debugging were somehow turned off after lockdep reported one bug. To mitigate any possibility of that as well, I threw in the BUG_ON() for good measure. I think at this point it's pretty clear that lockdep truly isn't complaining about simple_lmk's locking pattern, and that lockdep's lack of complaints isn't due to it being mysteriously turned off... Sultan