Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1001628yba; Wed, 15 May 2019 13:52:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxeZGgrmuwXvbSrl2aGjRFoL7utTgwA5CTgo+jodhJIjgOcCJOJNXQ1821kWNcmRail+xru X-Received: by 2002:a63:4820:: with SMTP id v32mr45820075pga.89.1557953522398; Wed, 15 May 2019 13:52:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557953522; cv=none; d=google.com; s=arc-20160816; b=zJ8siga8omr81B8zqPmHbJbfxpCazXy1sF2XeuRBhMm6oVonDRbrmikFILXh7l7TDM DC20AfvfF21pxCMdYICyYChDHe5ASIYP0z2jvIdZ1e6VJbkXMlJ6zy1SQ7hPIbFWRJCD V9hGLw+7CTXvrLH0CNTqcO65O9Bnbh/MN6YFqlPObo0ijkaCmyo+tLASyL646tqv7gC/ T1aPJ6F4Ll/CKNeOAuqdOXfTGeoQaTwOSv7vaRCFB2KovTM8t7kkWHuh8N2c3e6QX0vM aluHHpCj6cpfCxYiPdyKFtluOFDBLZ/shQmmYYT3zmYD2PSei1AlS08sIaOO2w4Br8KH /inA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=4DYWIxOWx2bjSXKtJq2DIJnjfb07mluDbIFzNb7XWk8=; b=HLYXUcifhZwBHUguq0GzVqJ9FnNoIuful+yIrNCDJjAYUx8ZV/qka3ah1pEdPibJtW r+zbjmkXvdGFl6kSSP9B8RflM3KllbjVkkkIG63txLIiqFDU2D8R341q6IWG49O26J8p YImYBWNf6tXZ3kko6JFDfMTXXdKGlUC8nDCorXvlTDWq53SRLHN7ngkLvJqIPl2CKnUu DPHGdQOKgmF0OlI0VRYsfLDYA7ofDR35KvOydNa1Zwqt2GW/L/N5u5LmSiYdXlTcbrc8 dmAW07Av8JGk26u8I+VQvUusuUXsa6Sxq1vghphIs8ZVqlFFiuEVzRsAmyBaQkgXs27P X10Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tobin.cc header.s=fm3 header.b="BL/5yuWi"; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=Iv6AjPuO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 185si3274546pfa.180.2019.05.15.13.51.47; Wed, 15 May 2019 13:52:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@tobin.cc header.s=fm3 header.b="BL/5yuWi"; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=Iv6AjPuO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727716AbfEOUtS (ORCPT + 99 others); Wed, 15 May 2019 16:49:18 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57887 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726290AbfEOUtS (ORCPT ); Wed, 15 May 2019 16:49:18 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 409052438C; Wed, 15 May 2019 16:49:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 15 May 2019 16:49:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobin.cc; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=4DYWIxOWx2bjSXKtJq2DIJnjfb0 7mluDbIFzNb7XWk8=; b=BL/5yuWiNwjOvU4jFHmI7rLvnAomYbuItkmAV2xzV6U +HMTmQX067H0vRmAG/6UgabVOQBTSp+cKOacnbNdRQ/OLgArR0IHAApHf2gOlX8a ZYHIV3+/vyZp9UBpDfb/+zsUNivC7uSTiH2CCMVqFskfPG7KoUQCDmg/Z0/hXdVE /mEj8xMWkOh12s36Nuhzy7CNCpnW/uIdiO9Zo70cx/mlt4blc0bVeQHfw4KMPq1N 2Tum8dmoL/oEkqYRZauFuC2wXFkWPj+QnVMlx7ar7+o/uLTwz6BiquzArRHRpFYu lsetzqibTGMosxAWaV5F1bsMKybx2kjqFGoTVEfhj3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=4DYWIx OWx2bjSXKtJq2DIJnjfb07mluDbIFzNb7XWk8=; b=Iv6AjPuOCaeYwZEnLxDmhY KIYmpK+gncszduGeAwu1YCDrj5lmJm2HEzAy2gZiBgqwSi2j8eD1RmZWrFoB9xUf ZKdauatKTGYGH2Njb9+MEnZK0ZnnOgiRmwjpDZCoTwue4BVWGtJK/6RN/P63unr5 YgFbdXUosJIIiB7m4/fZMw18yBD7USuRybZrWao6ut/VE01y3yVzuKsREW4w0yiW Wd1PPIn9GtsShnBNeZxIYbnF5WmCDSzAlvgTBAoP9FGaG+z16jfvg7dnSxF2Pq9q K0kbf4w894WBo+2Mql0nsZDqy/tV1DBhJuCG+pWgSl+S4YRccGDR+qLDC/nZcDuQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleekgddugeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgfofgesthdtredt ofervdenucfhrhhomhepfdfvohgsihhnucevrdcujfgrrhguihhnghdfuceomhgvsehtoh gsihhnrdgttgeqnecukfhppeduvddurdeggedrvddvkedrvdefheenucfrrghrrghmpehm rghilhhfrhhomhepmhgvsehtohgsihhnrdgttgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (ppp121-44-228-235.bras2.syd2.internode.on.net [121.44.228.235]) by mail.messagingengine.com (Postfix) with ESMTPA id 2133210378; Wed, 15 May 2019 16:49:15 -0400 (EDT) Date: Thu, 16 May 2019 06:48:40 +1000 From: "Tobin C. Harding" To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Tobin C. Harding" , "David S. Miller" Subject: Re: [PATCH 3.18 78/86] bridge: Fix error path for kobject_init_and_add() Message-ID: <20190515204840.GE11749@eros.localdomain> References: <20190515090642.339346723@linuxfoundation.org> <20190515090655.622147146@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515090655.622147146@linuxfoundation.org> X-Mailer: Mutt 1.11.4 (2019-03-13) User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2019 at 12:55:55PM +0200, Greg Kroah-Hartman wrote: > From: "Tobin C. Harding" > > [ Upstream commit bdfad5aec1392b93495b77b864d58d7f101dc1c1 ] Greg you are not going to back port all of these kobject fixes are you? There is going to be a _lot_ of them. I'm not super comfortable generating all this work for you. And besides that, I keep making mistakes (reference to last nights find of double free in powerpc that you reviewed already), then we have to back port those too. For the record I've been going through all uses of kobject and splitting them into categories 1. Broken 2. Too complex to immediately tell 3. Done correctly I'm not getting many in category #3, let's hope that some in #1 and #2 are my misunderstanding and that many in #2 should be in #3. I'm having fun fixing them but I shudder at making life hard for other people. Cheers, Tobin.