Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [RESEND PATCH] nvdimm: fix some compilation warnings
From:   Qian Cai <cai@lca.pw>
In-Reply-To: <CAPcyv4gGwyPf0j4rXRM3JjsjGSHB6bGdZfwg+v2y8NQ6hNVK8g@mail.gmail.com>
Date:   Wed, 15 May 2019 20:31:31 -0400
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Vishal L Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Keith Busch <keith.busch@intel.com>,
        "Weiny, Ira" <ira.weiny@intel.com>,
        linux-nvdimm <linux-nvdimm@lists.01.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3D0A6725-A738-4778-BB5B-1617B6184337@lca.pw>
References: <20190514150735.39625-1-cai@lca.pw>
 <CAPcyv4gGwyPf0j4rXRM3JjsjGSHB6bGdZfwg+v2y8NQ6hNVK8g@mail.gmail.com>
To:     Dan Williams <dan.j.williams@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


>>                }
>>=20
>> diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
>> index 7ff684159f29..2eb6a6cfe9e4 100644
>> --- a/drivers/nvdimm/bus.c
>> +++ b/drivers/nvdimm/bus.c
>> @@ -642,7 +642,7 @@ static struct attribute *nd_device_attributes[] =3D=
 {
>>        NULL,
>> };
>>=20
>> -/**
>> +/*
>>  * nd_device_attribute_group - generic attributes for all devices on =
an nd bus
>>  */
>> struct attribute_group nd_device_attribute_group =3D {
>> @@ -671,7 +671,7 @@ static umode_t nd_numa_attr_visible(struct =
kobject *kobj, struct attribute *a,
>>        return a->mode;
>> }
>>=20
>> -/**
>> +/*
>>  * nd_numa_attribute_group - NUMA attributes for all devices on an nd =
bus
>>  */
>=20
> Lets just fix this to be a valid kernel-doc format for a struct.
>=20
> @@ -672,7 +672,7 @@ static umode_t nd_numa_attr_visible(struct kobject
> *kobj, struct attribute *a,
> }
>=20
> /**
> - * nd_numa_attribute_group - NUMA attributes for all devices on an nd =
bus
> + * struct nd_numa_attribute_group - NUMA attributes for all devices
> on an nd bus
>  */
> struct attribute_group nd_numa_attribute_group =3D {
>        .attrs =3D nd_numa_attributes,

This won=E2=80=99t work because kernel-doc is to explain a struct =
definition, but this is a just an assignment.
The "struct attribute_group=E2=80=9D kernel-doc is in =
include/linux/sysfs.h.=