Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D1E2E6076A
Subject: Re: [PATCH v3 1/1] bsr: do not use assignment in if condition
To:     parna.naveenkumar@gmail.com, arnd@arndb.de,
        gregkh@linuxfoundation.org
Cc:     linux-kernel@vger.kernel.org
References: <20190515161746.29034-1-parna.naveenkumar@gmail.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <8f969496-c895-088f-eef2-ec6a70e19505@codeaurora.org>
Date:   Thu, 16 May 2019 13:28:50 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190515161746.29034-1-parna.naveenkumar@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 5/15/2019 9:47 PM, parna.naveenkumar@gmail.com wrote:
> From: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
>
> checkpatch.pl does not like assignment in if condition
>
> Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@gmail.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

> ---
> Changes in v3:
> The first patch has an extra space in if statement, so fixed it in v2 but
> forgot add what changed from the previous version. In v3 added the
> complete change history.
>
>   drivers/char/bsr.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
> index a6cef548e01e..70de334554a8 100644
> --- a/drivers/char/bsr.c
> +++ b/drivers/char/bsr.c
> @@ -322,7 +322,8 @@ static int __init bsr_init(void)
>   		goto out_err_2;
>   	}
>   
> -	if ((ret = bsr_create_devs(np)) < 0) {
> +	ret = bsr_create_devs(np);
> +	if (ret < 0) {
>   		np = NULL;
>   		goto out_err_3;
>   	}