Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp362113yba; Thu, 16 May 2019 02:00:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqx13qJqrHVnRtbnTxTFdPSvpKYauVJ7Y+52sfndl7E0Qdx7Ct/9S1xt9xZofpvt97AZ8yKH X-Received: by 2002:a63:5211:: with SMTP id g17mr20379184pgb.405.1557997230474; Thu, 16 May 2019 02:00:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557997230; cv=none; d=google.com; s=arc-20160816; b=C3Vxx5wC+sZnFlN0tR8R2lIWePuUhV0LPMTjHuiTY6rx2//0dFntfOkWAqeRa+91ap 9qNCkJCOxdkVqmSRO5Ukw7ZFONOXMr9kojwnWYDhoNzVtu6c+RdB+Quv+bjkuqvXjFt3 Kls629/QGUBeB7MhRbSn7iBP1/H9iRY6gWtDOqskZ9zQiWNL5zokjX25sFaYWGMXVzBu 5S1u56JsMF/9WZBfiv0wsCq4CkdpqtfkzCzfb72txHCXAraV4glCs8vySrlUh1Vb1qi5 VKjI2MQSKCXOZ7uCwSj5hvn9SwouWbZOrUpzTSopNodHG/pUvQfNu/6yAGw1U/QnbOMm yLCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from; bh=ZoUkTQRkJGvXTdSoCAhY6PQllrL4tk2NjwDuF1wPMBo=; b=H0hGilHqGvMxU52EObak8cs9AuJhW2nu6SrXu4tEFAucGUchGqIbJYY8uAq9WcAAlj pCWw0AyESyHAE78cQCkc74NaG9fsiP6O6sJellt1+udWbnzg0S/+S/ap4REyf1zNnq/S u9Rnogu1FCIRNzOBg9ROJgY08GB8+RSHmwpSq56YqLxuXBHli8WXYjzPHYA66NrOawSL f9kdCKgdZKaS+vHruvkLRCFk7Py9lL7ifKpEWYXUjjnvqLpUUMitI2myVWxjY2mwGmjR BOIRVQuTr3loU7YTl3Vse+SBu7+Fad3oBNRJeWSOOd8QIeAYRJ0TGxwyjbKUuvomePVK wRVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s14si4260995pgs.343.2019.05.16.02.00.15; Thu, 16 May 2019 02:00:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727135AbfEPI6x (ORCPT + 99 others); Thu, 16 May 2019 04:58:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:34964 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726917AbfEPI62 (ORCPT ); Thu, 16 May 2019 04:58:28 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B23B0AF92; Thu, 16 May 2019 08:58:27 +0000 (UTC) From: Roman Penyaev Cc: Azat Khuzhin , Roman Penyaev , Andrew Morton , Al Viro , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 12/13] epoll: support mapping for epfd when polled from userspace Date: Thu, 16 May 2019 10:58:09 +0200 Message-Id: <20190516085810.31077-13-rpenyaev@suse.de> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190516085810.31077-1-rpenyaev@suse.de> References: <20190516085810.31077-1-rpenyaev@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org User has to mmap user_header and user_index vmalloce'd pointers in order to consume events from userspace. Also we do not let any copies of vma on fork(). Signed-off-by: Roman Penyaev Cc: Andrew Morton Cc: Al Viro Cc: Linus Torvalds Cc: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 20c94587488f..9ff666ce7cb5 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -1276,11 +1276,47 @@ static void ep_show_fdinfo(struct seq_file *m, struct file *f) } #endif +static int ep_eventpoll_mmap(struct file *filep, struct vm_area_struct *vma) +{ + struct eventpoll *ep = vma->vm_file->private_data; + size_t size; + int rc; + + if (!ep_polled_by_user(ep)) + return -ENOTSUPP; + + size = vma->vm_end - vma->vm_start; + if (!vma->vm_pgoff && size > ep->header_length) + return -ENXIO; + if (vma->vm_pgoff && ep->header_length != (vma->vm_pgoff << PAGE_SHIFT)) + /* Index ring starts exactly after the header */ + return -ENXIO; + if (vma->vm_pgoff && size > ep->index_length) + return -ENXIO; + + /* + * vm_pgoff is used *only* for indication, what is mapped: user header + * or user index ring. Sizes are checked above. + */ + if (!vma->vm_pgoff) + rc = remap_vmalloc_range_partial(vma, vma->vm_start, + ep->user_header, size); + else + rc = remap_vmalloc_range_partial(vma, vma->vm_start, + ep->user_index, size); + if (likely(!rc)) + /* No copies for forks(), please */ + vma->vm_flags |= VM_DONTCOPY; + + return rc; +} + /* File callbacks that implement the eventpoll file behaviour */ static const struct file_operations eventpoll_fops = { #ifdef CONFIG_PROC_FS .show_fdinfo = ep_show_fdinfo, #endif + .mmap = ep_eventpoll_mmap, .release = ep_eventpoll_release, .poll = ep_eventpoll_poll, .llseek = noop_llseek, -- 2.21.0