Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Anson Huang <anson.huang@nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>
CC:     "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will.deacon@arm.com" <will.deacon@arm.com>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "agross@kernel.org" <agross@kernel.org>,
        "maxime.ripard@bootlin.com" <maxime.ripard@bootlin.com>,
        "olof@lixom.net" <olof@lixom.net>,
        "horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
        "jagan@amarulasolutions.com" <jagan@amarulasolutions.com>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "marc.w.gonzalez@free.fr" <marc.w.gonzalez@free.fr>,
        "dinguyen@kernel.org" <dinguyen@kernel.org>,
        "enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Abel Vesa <abel.vesa@nxp.com>,
        "robh@kernel.org" <robh@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V3 1/2] soc: imx: Add SCU SoC info driver support
Thread-Topic: [PATCH V3 1/2] soc: imx: Add SCU SoC info driver support
Thread-Index: AQHVC5bqk1P5MqRzRU2gqcSUyb18Bw==
Date:   Thu, 16 May 2019 10:06:34 +0000
Message-ID: <AM0PR04MB6434E01AD0A18405A9E0DDF8EE0A0@AM0PR04MB6434.eurprd04.prod.outlook.com>
References: <1557976777-8304-1-git-send-email-Anson.Huang@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 341301dc-2b6c-4a33-fb56-08d6d9e62d3b
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2019 10:06:34.3525
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4947
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16.05.2019 06:24, Anson Huang wrote:=0A=
> Add i.MX SCU SoC info driver to support i.MX8QXP SoC, introduce=0A=
> driver dependency into Kconfig as CONFIG_IMX_SCU must be=0A=
> selected to support i.MX SCU SoC driver, also need to use=0A=
> platform driver model to make sure IMX_SCU driver is probed=0A=
> before i.MX SCU SoC driver.=0A=
=0A=
> +#define imx_scu_revision(soc_rev) \=0A=
> +	soc_rev ? \=0A=
> +	kasprintf(GFP_KERNEL, "%d.%d", (soc_rev >> 4) & 0xf,  soc_rev & 0xf) : =
\=0A=
> +	"unknown"=0A=
=0A=
> +	id =3D of_match_node(imx_scu_soc_match, pdev->dev.of_node);=0A=
> +	data =3D id->data;=0A=
> +	if (data) {=0A=
> +		soc_dev_attr->soc_id =3D data->name;=0A=
> +		if (data->soc_revision)=0A=
> +			soc_rev =3D data->soc_revision();=0A=
> +	}=0A=
> +=0A=
> +	soc_dev_attr->revision =3D imx_scu_revision(soc_rev);=0A=
> +	if (!soc_dev_attr->revision)=0A=
> +		return -ENODEV;=0A=
=0A=
The imx_scu_revision macro returns either kasprintf or "unknown", never =0A=
NULL. So it's not clear what this return -ENODEV does exactly.=0A=
=0A=
It makes more sense to return -ENODEV if get_soc_revision fails, so =0A=
maybe check "soc_rev !=3D 0" instead?=0A=
=0A=
If you really want to check the kasprintf result then you should return =0A=
-ENOMEM for it. It would be clearer if you dropped the imx_scu_revision =0A=
revision macro and open-coded instead.=0A=
=0A=
--=0A=
Regards,=0A=
Leonard=0A=