Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp427319yba; Thu, 16 May 2019 03:14:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqwV7YGjeOPcJ9gvVdTjijhLQ5RQ4Kj34wxP/yHDwE5nG5CY/Sop0n7NRMa8ZvoEzdFXvZr/ X-Received: by 2002:a63:495e:: with SMTP id y30mr7025683pgk.185.1558001674615; Thu, 16 May 2019 03:14:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558001674; cv=none; d=google.com; s=arc-20160816; b=JMuUPLgQvLVgJvYZDFw5YLYjXFQRIuaSHiSUABB04Y4Xfz73EYcwJ7QBUZkjs5h1Vh ouMm3JClaeLzC+++LLsGuDv2YPjBK95XESZt+EQu4cenLph/FjIbRHOT6Xy8N9+l0yKG ZxnuXWBmAju/TKUp/4OORjLtw0q0J5+28OueqNDn9ohpP3R1WQNWmZiJEsXL2MEKfMIE 3fMDLlo32zSnD0mL59M665NSkt6jXbtwb2wANPDGmqaPNIvVWrfrIngoBcZuzvNh9LOe LGfUaaC1hCPEIU3OEJB1Frxt46DkhRi4AW0hWyPe1uN3+3M6vYlf+Vh0H6rJG/gL4Aft sc9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IzKP9HLNlXee2M6iLMR2LM7xnjvarDZVD2/6gMH+Tcg=; b=x92cDAVa2XGN0adXm9yVpgVqTOfZ/FnBd/Shfo6bF2ng7NfuOd1bGYKT1blP5V48pX ypKhmZpoxiZ6QenbJjwtyqZoMZ4XuQcoRNvyAOayzWQNMIlX14vr8cipn8YKPP97GCsb J4HpWwADbmZAeqdcJ0P7Ka0EQMgKa6aAS1wGLY5RP/pVs7FyU33TWtyKzRn8S+89wnHn +a6xSVZFSEf2IQMyMnMLGqWvuziNOYBfZyKQavEd+lVqp6ETsnKVkMqxWhvWWUAOzzIf yQI74SvLa/NnF3RHhnHxV/HE/vKjjeuHCLz0lX2SxcRQj5Q/1aGynL6JHVL0695sWBqV mdpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=GNk6DCqF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z26si4557948pge.345.2019.05.16.03.14.18; Thu, 16 May 2019 03:14:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=GNk6DCqF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726799AbfEPKLz (ORCPT + 99 others); Thu, 16 May 2019 06:11:55 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:43950 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726336AbfEPKLy (ORCPT ); Thu, 16 May 2019 06:11:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IzKP9HLNlXee2M6iLMR2LM7xnjvarDZVD2/6gMH+Tcg=; b=GNk6DCqF9bgIUJZ/MEMc9fegQ 35Vx2DnTyiPqsu7Y6lI7IgL1vj/3eHS+pUx+lqDfCSVJMJqWIUXs3CB/BXWkuJM3p2TA9Zf/sbg/y ZkklGYCeOADwzVt0vwXha0hmy0KzYr8xO0b8VC31LoqzIqnmf2E2cJXTL3Yc7JW6Xu8r0=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1hRDMS-00061J-O3; Thu, 16 May 2019 10:11:40 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id AD4D11126D3F; Thu, 16 May 2019 11:11:36 +0100 (BST) Date: Thu, 16 May 2019 11:11:36 +0100 From: Mark Brown To: "S.j. Wang" Cc: "brian.austin@cirrus.com" , "Paul.Handrigan@cirrus.com" , "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2] ASoC: cs42xx8: Add reset gpio handling Message-ID: <20190516101136.GC5598@sirena.org.uk> References: <95eb314ef6d47ee6581094a406516a6069278d56.1557986457.git.shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZwgA9U+XZDXt4+m+" Content-Disposition: inline In-Reply-To: <95eb314ef6d47ee6581094a406516a6069278d56.1557986457.git.shengjiu.wang@nxp.com> X-Cookie: i figured 17G oughta be enough. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZwgA9U+XZDXt4+m+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 16, 2019 at 06:04:58AM +0000, S.j. Wang wrote: > + cs42xx8->gpiod_reset = devm_gpiod_get_optional(dev, "reset", > + GPIOD_OUT_HIGH); > + if (IS_ERR(cs42xx8->gpiod_reset)) > + return PTR_ERR(cs42xx8->gpiod_reset); You also need a binding document update for this. --ZwgA9U+XZDXt4+m+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlzdN1cACgkQJNaLcl1U h9B77wf6Am2asgXqw+nI5Ts2nEP5jHpq8r6uTGJ7oAsVZ/DvX7MFJgwRwYwmfaiI DcGaR6tx0sMwGjHVhLVu4mMG7vAgjkkwNMi7OArvG9hF+c9A4CLy84gQMlxwScqQ TR562sJfuDfzwI5sA0+FSuZAg3To/WGO9X+wKcH9IASntblmxesPPuMpxwNwb89M xVNTgRrRWSzfjWptZFCbWrRsoFv8BCov9zXx3UfDbjFMT2CQ86l88QuQs1RwHOB9 /k7pwiObaEGOngMKkg+UIRo34myrsc/RtBNpSwdXX37KpMeXjQ0nIVOIPGbjyxrl n9xbKAC+csBlahOJM6VzPQyXiCAQmA== =gQpf -----END PGP SIGNATURE----- --ZwgA9U+XZDXt4+m+--