Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp478155yba; Thu, 16 May 2019 04:10:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwb0h/U185/40yVPQOpnnA4t5SB1Tj71L63i3rHctbW+dSXqz7C6ZQZjHUaXXxi/EFcWRfQ X-Received: by 2002:a63:5608:: with SMTP id k8mr50443316pgb.393.1558005049760; Thu, 16 May 2019 04:10:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558005049; cv=none; d=google.com; s=arc-20160816; b=ubscvjQqgXnvKXv8KtqTeTAfW/KWWTlJE6tD+XkW60jAHXCNF0vI9nojNSJUaYD57w p4zJgql9aZBpx5SJvcBeh50LmmecBixbe/RFZXnn4DhRJF7cKISwrKW7b6aN0MAfIfjY 8vpGCr+rtRyIewN/rXu0W4PdgW7swNkXVQ8wdppgtIpv1OTxEf0S8/qTI63BmJtRwfzm P4HyqD7Mkn5fZ/qoaHNMrN4yEatbQD/VQHVo3EWxog4CUMhxiuY9D+mGq5jJY7Tk/OU6 RNQH7LAt64QHskFPzgdlaLXl63FV0BjjCSGoQNDPqkovtcXeNhqRRXYir0J+iDsKti8M fcww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature; bh=AXrwXc4fc+g00utorZ0Nb9cmzraEM3mU5PZ8qRlBZQM=; b=qK8Y/4pjQ5Dt17shkYvqCjxmSQSvm6PUiZqL9FPpt6yxnqlsMg7hDWTGojCLBG3BlG VKQSMgoTrgpztgw/ekYGhKKHiQzg53+gxQNH2eHB7drn6l2aAxj+Qi809dJYsBefi/lX oFtDs49G+ePsirhXwGIoirXz82v/NdkEB62oikyPbLw6aFvKZ1ZL9HhP0vzDO0+4hcX8 b/yKsYokfnTeqn4xIedGKsDntfc3ODZElmchrrNU62/uT/vBw5dP8kwi6J1bhbmwhN6w MvYZyKRgo1/xPj73plyJh3bM5V2z7XM/rXaZae+MaA/AmlI2F9Z8bX4kf4/5+uBQE4sh ZuJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=Q1DVpMIy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cp7si4686983plb.14.2019.05.16.04.10.35; Thu, 16 May 2019 04:10:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=Q1DVpMIy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726736AbfEPLJa (ORCPT + 99 others); Thu, 16 May 2019 07:09:30 -0400 Received: from mail-eopbgr80085.outbound.protection.outlook.com ([40.107.8.85]:65075 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726363AbfEPLJa (ORCPT ); Thu, 16 May 2019 07:09:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AXrwXc4fc+g00utorZ0Nb9cmzraEM3mU5PZ8qRlBZQM=; b=Q1DVpMIyfZMZpkUrXD06cB1dVDz2CasyDWLYZW3hUVGEAVD0bPTxZvyTPXFJX3nAAee5t4x9rGtjU/aikUyi3mOfks1U4HSaidMIMX9ErDDrBNGSGiZFzMZPwBfRjZw2IdWvMSZkHmIUYcysSs7oA1pc4T76tfPMR9LCRLutc4U= Received: from VE1PR04MB6479.eurprd04.prod.outlook.com (20.179.233.80) by VE1PR04MB6446.eurprd04.prod.outlook.com (20.179.232.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.16; Thu, 16 May 2019 11:09:27 +0000 Received: from VE1PR04MB6479.eurprd04.prod.outlook.com ([fe80::a5b5:13f5:f89c:9a30]) by VE1PR04MB6479.eurprd04.prod.outlook.com ([fe80::a5b5:13f5:f89c:9a30%7]) with mapi id 15.20.1900.010; Thu, 16 May 2019 11:09:27 +0000 From: "S.j. Wang" To: Mark Brown CC: "brian.austin@cirrus.com" , "Paul.Handrigan@cirrus.com" , "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2] ASoC: cs42xx8: Add reset gpio handling Thread-Topic: [PATCH V2] ASoC: cs42xx8: Add reset gpio handling Thread-Index: AdUL17zEZXZ5WMhBSxKtqwI7wVoUIA== Date: Thu, 16 May 2019 11:09:27 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shengjiu.wang@nxp.com; x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c760b800-32fb-4aff-51fa-08d6d9eef607 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:VE1PR04MB6446; x-ms-traffictypediagnostic: VE1PR04MB6446: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:393; x-forefront-prvs: 0039C6E5C5 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(376002)(396003)(136003)(39860400002)(366004)(199004)(189003)(76116006)(66556008)(64756008)(66446008)(68736007)(52536014)(66476007)(305945005)(7736002)(81166006)(102836004)(8676002)(81156014)(66066001)(476003)(6116002)(3846002)(66946007)(4326008)(256004)(186003)(25786009)(6506007)(14444005)(26005)(6916009)(486006)(71200400001)(71190400001)(7696005)(14454004)(9686003)(54906003)(73956011)(316002)(99286004)(6436002)(53936002)(4744005)(2906002)(86362001)(478600001)(5660300002)(33656002)(8936002)(55016002)(6246003)(229853002)(74316002);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR04MB6446;H:VE1PR04MB6479.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Hihky8Ner/B6gjPbfjcS4gI/a3NwVjhsMGBvyXtvQXI0hl6in9EvBEVPw0g2+M0rND5ahbfo0oSDRS5e2VOY63v/v5pWIveH021XHY0vP//4je/zje6+2AQdT8cCet/LB/f1Sa2PcS2GlDl9SMvGtDvE42mBW340YxI/InfTbYg7Bif5cpVhrK4mft2nhwhV8rNfoPxTHrz61gMtiC1RqgLdsNFHueKdVbVvLRNqlpPbMZEtM/pxWw9BjWUkDaTn/LMhcLZY7emh4j6gIpA0ag1DdzPsQTae4H2bpaHpiaSzEyY3yJidKVwnZ1aY2EpzFHxbAoljSQjLU1QLyfmQHKTQdJVT4E4s4SlY/2ZDMGP60+6HZcpR7WnYhNowOFG5gLOwQL6Grhtd8ATEI+UBWmeShkKoZMqmj3mkybw2xZ8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c760b800-32fb-4aff-51fa-08d6d9eef607 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2019 11:09:27.1523 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6446 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi >=20 > On Thu, May 16, 2019 at 06:04:58AM +0000, S.j. Wang wrote: >=20 > > + cs42xx8->gpiod_reset =3D devm_gpiod_get_optional(dev, "reset", > > + GPIOD_OUT_HIGH); > > + if (IS_ERR(cs42xx8->gpiod_reset)) > > + return PTR_ERR(cs42xx8->gpiod_reset); >=20 > You also need a binding document update for this. ok, will send v3 best regards wang shengjiu