Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 16 May 2019 16:43:04 +0300
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Cc:     architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie,
        Souptick Joarder <jrdr.linux@gmail.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: Remove duplicate header
Message-ID: <20190516134304.GK14820@pendragon.ideasonboard.com>
References: <5cda6ee2.1c69fb81.2949b.d3e7@mx.google.com>
 <20190514073542.GA4969@pendragon.ideasonboard.com>
 <CAJr6mf0zy37MTuZQV2YLLQ7dY4a0r6LpSRTKByX0dBBfxuA4_g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAJr6mf0zy37MTuZQV2YLLQ7dY4a0r6LpSRTKByX0dBBfxuA4_g@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Sabyasachi,

On Thu, May 16, 2019 at 06:45:04PM +0530, Sabyasachi Gupta wrote:
> On Tue, May 14, 2019 at 1:05 PM Laurent Pinchart wrote:
> > On Tue, May 14, 2019 at 01:01:41PM +0530, Sabyasachi Gupta wrote:
> > > Remove drm/drm_panel.h which is included more than once
> > >
> > > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> > > ---
> > >  drivers/gpu/drm/bridge/panel.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > > index 7cbaba2..402b318 100644
> > > --- a/drivers/gpu/drm/bridge/panel.c
> > > +++ b/drivers/gpu/drm/bridge/panel.c
> > > @@ -15,7 +15,6 @@
> > >  #include <drm/drm_crtc_helper.h>
> > >  #include <drm/drm_encoder.h>
> > >  #include <drm/drm_modeset_helper_vtables.h>
> > > -#include <drm/drm_panel.h>
> >
> > Which tree is this against ? The patch applies on neither drm-next nor
> > drm-misc-next.
> >
> 
> It is against linux-next tree

You will likely have to rebase it on top of the drm-next or
drm-next-misc branch.

> > While at it, could you you reorder the other header alphabetically to
> > make this kind of issue easier to notice ?
>
> It is already arranged in alphabetical order

There's an #include <drm/drm_panel.h> at the top of the list of
includes. That's the one that is out of place.

> > >
> > >  struct panel_bridge {
> > >       struct drm_bridge bridge;

-- 
Regards,

Laurent Pinchart