Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 16 May 2019 08:48:33 -0600
From:   Alex Williamson <alex.williamson@redhat.com>
To:     "richard.peng@oppo.com" <richard.peng@oppo.com>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        Alexey Kardashevskiy <aik@ozlabs.ru>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] vfio: vfio_pci_nvlink2: use a vma helper function
Message-ID: <20190516084833.757140bc@x1.home>
In-Reply-To: <2019051620382477288130@oppo.com>
References: <2019051620382477288130@oppo.com>
Organization: Red Hat
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

[Cc Alexey + kvm]

On Thu, 16 May 2019 20:38:26 +0800
"richard.peng@oppo.com" <richard.peng@oppo.com> wrote:

> Use a vma helper function to simply code.
> 
> Signed-off-by: Peng Hao <richard.peng@oppo.com>
> ---
>  drivers/vfio/pci/vfio_pci_nvlink2.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c
> index 32f695ffe128..dc42aa0e47f6 100644
> --- a/drivers/vfio/pci/vfio_pci_nvlink2.c
> +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c
> @@ -161,8 +161,7 @@ static int vfio_pci_nvgpu_mmap(struct vfio_pci_device *vdev,
>  
>  	atomic_inc(&data->mm->mm_count);
>  	ret = (int) mm_iommu_newdev(data->mm, data->useraddr,
> -			(vma->vm_end - vma->vm_start) >> PAGE_SHIFT,
> -			data->gpu_hpa, &data->mem);
> +			vma_pages(vma), data->gpu_hpa, &data->mem);
>  
>  	trace_vfio_pci_nvgpu_mmap(vdev->pdev, data->gpu_hpa, data->useraddr,
>  			vma->vm_end - vma->vm_start, ret);
> -- 
> 2.20.1