Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp862267yba; Thu, 16 May 2019 10:03:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqxXa44nSIKvb87uRNgX41jqgXlGs4upmLlQwhwerqXPF1I0dKRkw/d/BDDOdMRec9ziNIMy X-Received: by 2002:a65:4907:: with SMTP id p7mr51413712pgs.288.1558026216290; Thu, 16 May 2019 10:03:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558026216; cv=none; d=google.com; s=arc-20160816; b=d2Nr32+JjkkrV0am6aOGQwaESXP0Gv1eRAfydYBgey5EQfBMunjcTGwhR+I/pVb4d+ dTx7u+gbsd5RyZW1wR65gsMVo869M5YvZucYv6WLhuJlndxXfhhghupqFJJW5kFS/f4b gJqARunlclvtFy71Pzd0bJCFWUFvoO9/JrLle4UbOi1z7YmjCnqJrlg3VSNPyO8Td1wk rCRtgY2Oy+AxSh2XDEKOJPfx3TKAfQUxpEWWCDr4PWajtcwJaEbsurwc406litSjfjOJ Vvt8LEIuCWIbJUBrxgAajsXexktoo3xRZ2360wxbUYd8V41AtJEhE0kSiZmRu7wDWUzk DmEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=MGeS11AJ66d7xrLJ3yad9myXY0d2Y51NB+QYSsw/uBc=; b=naUee59jLDGH8odGw8cSe3GoGNlPTelEuWb/yfPOVWHHaD5fJJivuErN7+yCA7rsoN 4HMfINEvhAvmCz2AniwL8fV/dP7BDGpV9yTNRDuGOwULgXt3aKy9HIrm0C4KXR+Vbr2e QYvH8ttdO3Z4GUmzuayzhOmZUhm8Sry66fsDXQMYq6UMO6GSPSwKXI7QD5O46m0ENn88 FRf8GV+MsFC5KQjVDzRXgI1a84ezvyvAcqdBSQs4DASeUw0I4w3wgdm6CYMZljI8L6I7 G9bbGeV7VZZphO9uNkwPsC4YESIl4DY3pPMl6fd+SIV5QFSuXR1dlPMudkelv4K4Nsl5 K6Jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gn19si5273879plb.67.2019.05.16.10.03.20; Thu, 16 May 2019 10:03:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727492AbfEPPsn (ORCPT + 99 others); Thu, 16 May 2019 11:48:43 -0400 Received: from verein.lst.de ([213.95.11.211]:60317 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727037AbfEPPsm (ORCPT ); Thu, 16 May 2019 11:48:42 -0400 Received: by newverein.lst.de (Postfix, from userid 2005) id BC11268B02; Thu, 16 May 2019 17:48:20 +0200 (CEST) Date: Thu, 16 May 2019 17:48:20 +0200 From: Torsten Duwe To: Vasily Khoruzhick Cc: David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Thierry Reding , Maxime Ripard , Chen-Yu Tsai , Andrzej Hajda , Laurent Pinchart , Icenowy Zheng , Sean Paul , Harald Geyer , dri-devel , devicetree , arm-linux , linux-kernel Subject: Re: [PATCH 4/4] arm64: DTS: allwinner: a64: enable ANX6345 bridge on Teres-I Message-ID: <20190516154820.GA10431@lst.de> References: <20190514155911.6C0AC68B05@newverein.lst.de> <20190514160241.9EAC768C7B@newverein.lst.de> <20190515093141.41016b11@blackhole.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2019 at 08:08:57AM -0700, Vasily Khoruzhick wrote: > On Wed, May 15, 2019 at 12:32 AM Torsten Duwe wrote: > > > > It does comply with the bindings. The ports are all optional. > > As far as DT is concerned, the signal path ends here. This is also the > > final component _required_ to get the Linux kernel DRI up and running. > > Ugh, then bindings should be fixed. It's not optional. It may work if > bootloader enables power for you, but it won't if you disable display > driver in u-boot. I double-checked. On the Teres-I, mentioning the panel _is_ optional. PD23 powers down panel and backlight as much as possible, see 24bd5d2cb93bc arm64: dts: allwinner: a64: teres-i: enable backlight (currently only in Maxime's repo) and the Teres-I schematics... And the driver in your repo neatly guards all accesses with "if (anx6345->panel)" -- good! But I found the Vdds are required, so I added them as such. > I guess you're testing it with older version of anx6345. Newer version > that supports power management [1] needs startup delay for panel. > Another issue that you're seeing is that backlight is not disabled on > DPMS events. All in all, you need to describe panel in dts. > > [1] https://github.com/anarsoul/linux-2.6/commit/2fbf9c242419c8bda698e8331a02d4312143ae2c > > Should I also have added a Tested-by: ? ;-) > > I don't have Teres, so I haven't tested these. *I* have one, and this works. I'll retest with your newer driver, just in case. Nonetheless, the changes in this series should be fine. Sending out v2 in a moment... Torsten