Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp896390yba; Thu, 16 May 2019 10:35:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqw1AgS4i53MqDUu6+Cfk493wb9/sgO5gXdu9IcbKoLRUsqq5oPayJt31ubJf7CiMr4DSGUL X-Received: by 2002:a63:1a60:: with SMTP id a32mr7598068pgm.66.1558028127537; Thu, 16 May 2019 10:35:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558028127; cv=none; d=google.com; s=arc-20160816; b=B1IUJkilj36EKAcqML1oetrDZ76Szs0/k+w6l6ZI7s4lJoYfXO0svGitULGqrs0vyg ozreSQywEftUOFBVyXxunleIF1SEYQ4SLZL/OFK/Q7dKYotg6AN8Kikgqbi+a2EFDHdn c8MzMOfYi3uG2vn+OTl/LoeWNIW5+AfibirMCJ6H1g86QoFAJdZgqbD9ENBFnB6ckKiY wvo2N6r4EmXklipzDSs81svCC1EQU2F17KGp+68W2eMrH6nLhdB5HgxJ0aIKX3TsY+as AS6OGTwRDhRCeFqsGW3YHAd99KjiY1P0QpAwQpVyjlx/ki3D0weT7BTwpyC+S8lYqQsZ vTkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=R6gB+pd4PARXdmsD+6M1n7+wJ5h92PxWkIPVD+8jtGg=; b=yLUxCGf6l/nBXBS+2yWTqv2Nxmu6P+zcTY75724k/Q9DUsZWCRibsWEhAa7IRKCJW6 3uLYb5gXCDQRd4gLRMVy62fY07nHjdoMwQdoV5ZXmovnV+zpihB6DTNRrM7PCmM1wMdh xSg7SIWvxq8643t1GlLeXXtyui7U7rooIjJnIJUw9vv8w2OMXcClWWu7nv72EXnF8sAZ uUxE4T2aegNnbwfGEZCBsj/XvonNRP5jDwSotwCQ31eosxGZaTDz40TT6YvtZtd/Pcnj GxedN54WGBtFTCxrQptdRiREEMvGhNIz6c+qjdnNJU+qXGV4ZP2a1VEv9NniPcgrhdL6 kNgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w187si6365589pfw.221.2019.05.16.10.35.11; Thu, 16 May 2019 10:35:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727804AbfEPPcY (ORCPT + 99 others); Thu, 16 May 2019 11:32:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33294 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726692AbfEPPcY (ORCPT ); Thu, 16 May 2019 11:32:24 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BAD9B3082131; Thu, 16 May 2019 15:32:23 +0000 (UTC) Received: from localhost (ovpn-117-183.ams2.redhat.com [10.36.117.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id BFB8A5D72E; Thu, 16 May 2019 15:32:19 +0000 (UTC) Date: Thu, 16 May 2019 16:32:18 +0100 From: Stefan Hajnoczi To: Stefano Garzarella Cc: netdev@vger.kernel.org, "David S. Miller" , "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Jason Wang Subject: Re: [PATCH v2 2/8] vsock/virtio: free packets during the socket release Message-ID: <20190516153218.GC29808@stefanha-x1.localdomain> References: <20190510125843.95587-1-sgarzare@redhat.com> <20190510125843.95587-3-sgarzare@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i7F3eY7HS/tUJxUd" Content-Disposition: inline In-Reply-To: <20190510125843.95587-3-sgarzare@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 16 May 2019 15:32:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --i7F3eY7HS/tUJxUd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 10, 2019 at 02:58:37PM +0200, Stefano Garzarella wrote: > When the socket is released, we should free all packets > queued in the per-socket list in order to avoid a memory > leak. >=20 > Signed-off-by: Stefano Garzarella > --- > net/vmw_vsock/virtio_transport_common.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Ouch, this would be nice as a separate patch that can be merged right away (with s/virtio_vsock_buf/virtio_vsock_pkt/). --i7F3eY7HS/tUJxUd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAlzdgoIACgkQnKSrs4Gr c8inUgf/ZWWrRlkmdo0umzZLZb20m5kj29mccKVqTXumpuuP4uj0fUgYDiHaO2Nw RzI9h1D2ZxH0eu8lymsu9LScLZ+x/WoZh36H7BDqAJCqvo3/t3mKQVRj8h+x2Pqg nhlAE54DTQLjeNBahCiZSNHDx2znDN7XQhTGD4LlEJr4Fo5wxNkflX2aPUtwjH2P dQFDh2kXCqneuo2QQ/GPpYAufMXA4+n2YNsLKPqV3XtJP26a14tbdhbqaGOnOV4q J9tOGaC8xukkX331J0Pqo0lPRLwqgeJEYTbjsjfUHcw8OP9Fcsy+/tDZMALSTc1P 4gMCqmXG6V/yfH6zkt7xipW8qhpmsQ== =htot -----END PGP SIGNATURE----- --i7F3eY7HS/tUJxUd--