Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp926152yba; Thu, 16 May 2019 11:06:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxVjv4WsvcRb1WoS/i4EYbe+IWkFJEfCpUgOGVddBj/ujmgjTVqG2OmKunjKB8f4HQyNW7m X-Received: by 2002:aa7:8a81:: with SMTP id a1mr54639607pfc.121.1558030000707; Thu, 16 May 2019 11:06:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558030000; cv=none; d=google.com; s=arc-20160816; b=KsP0PszozsOjyCRH4z0GANa76gNxTrtsHZTWI+g24EClR7eI15lkVREJliBXvIwJ2g WXphrKBVmfn1x6wHCYbOSYcvWLKNeokJWjHlrfwKvpiZwNdIYIj0gvSAY6U9fiu2ewI2 C6Pd6oh8CSHU77sNCdaW5VfhhphhBDVmSG9ZWJNZXnVn4DepcYzgXFIujKPNDKSOmhJw b61349kMYMHm3Cm7BuQ/RgL4kR9kjsTw4QRJ47SH9681JgoaqXqvw9DGdxis/cvOaTdR Y6IyFzGs1pMClWV4Vfa4zBYBUwGpAGtvh+ZS46AkkizymlQVDtjJhHkI1ddoj89udtEP M5yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=LBNDRhhKywXBp2MSuZfngBTVHWR97SCmvRB6eI8uLbE=; b=LxtlZ655xqWTC/ISqIPtzzDF2zYqvjjDhaMMRrU+8T+pEQ8Tve/4rYs00AN25DOBwx MUbmR1yg0FAGaRfFE5B5LQLbro6BkSwdZCC+LaUjckYkbaIdfuL6abIy10Co/j0OlmA0 YqI2QpZcFkbPgeObBD+k8mEY3cCqU2wYI1ylJwzXhETtFYStj6H5u0HjEuBiYASywXag 2grBLYGbx/zXvg4EMDkNiXKJK1Emsncndv/H+gnm0ZoqD76EYTrtoHk6ro4qT/3oTYZj zGs/DJ7tsyhc/3y32IqfdtHotoNsW8rhHLIdgWBRZuaV9jb9kgyjE7Hr7pdIris+qAMO K55w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=YGLG2XRT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d37si4124500pla.63.2019.05.16.11.06.11; Thu, 16 May 2019 11:06:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=YGLG2XRT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbfEPQP2 (ORCPT + 99 others); Thu, 16 May 2019 12:15:28 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:43455 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbfEPQP2 (ORCPT ); Thu, 16 May 2019 12:15:28 -0400 Received: by mail-lf1-f66.google.com with SMTP id u27so3076966lfg.10 for ; Thu, 16 May 2019 09:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LBNDRhhKywXBp2MSuZfngBTVHWR97SCmvRB6eI8uLbE=; b=YGLG2XRTx2rzAnfC7U7Pt27EAxYtRFVsHIL2F6MDo4Eb18nu45zjdjHrwS1A9kdPGe 7AIr1yDi9FrkAOD910N+/Gftjemk6VQpdwLEb6WWejY5+Cn6CS2NDKVPjnz4IQ92cu0t 0s8PelXOgvWB0aAfwdmg6nSu5jdC5BtNCXpg4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LBNDRhhKywXBp2MSuZfngBTVHWR97SCmvRB6eI8uLbE=; b=qj35NGwLwOrp1zQy3eupsxr3au+BBB1oFmVwYnL9HLmG9iTaMNwhIrRwEiALuq/0lh 5gNG3AwWElgHotceS8dnQJJI/SfMxsOm8ml5K9uSrWW5f8Zk4wxMr2irekFhk1SH+6jC pzUt+iAhpfrt/oOcJr3ulk17Z8i99oBqQlGWLOwGc61+kNneSk6Wr0nH4m+yTNEVS+sd 3SHaoPT2qCyKxB2NneqkhHxi9xL23O8uzx0L6tGdjQ3EU5A7nnlC5P4PCHBUT1Ty2C6D Oqb+fOIpIZ/mj8G7wSBqIs2xhZK4S73QeJ+MPe/UBj5ZZD2N3qvWuFQyWMewXOMGdleW vlVA== X-Gm-Message-State: APjAAAWcL5EiAz6pp3zLTm9F8gM+Kyo/GauhWyIcRehL/0ZCmbiSUNYh zAIE14m/o5E5KirHEdoS2GqUpZK9cjOcZZXpcIpuNOW9 X-Received: by 2002:a19:2791:: with SMTP id n139mr16901324lfn.67.1558023326364; Thu, 16 May 2019 09:15:26 -0700 (PDT) MIME-Version: 1.0 References: <1558022399-24863-1-git-send-email-kdasu.kdev@gmail.com> <1558022399-24863-2-git-send-email-kdasu.kdev@gmail.com> In-Reply-To: <1558022399-24863-2-git-send-email-kdasu.kdev@gmail.com> From: Kamal Dasu Date: Thu, 16 May 2019 12:14:49 -0400 Message-ID: Subject: Re: [PATCH v2 2/2] mtd: nand: raw: brcmnand: When oops in progress use pio and interrupt polling To: Kamal Dasu Cc: MTD Maling List , bcm-kernel-feedback-list@broadcom.com, open list , Brian Norris , Miquel Raynal , Richard Weinberger , David Woodhouse , Marek Vasut , Vignesh Raghavendra Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please ignore v2 patch 1/2 and 2/2. The commit ordering is not right. v3 patch on the way Kamal On Thu, May 16, 2019 at 12:01 PM Kamal Dasu wrote: > > If mtd_oops is in progress switch to polling for nand command completion > interrupts and use PIO mode wihtout DMA so that the mtd_oops buffer can > be completely written in the assinged nand partition. > > Signed-off-by: Kamal Dasu > --- > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > index a30a7f0..dca8eb8 100644 > --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > @@ -835,7 +835,6 @@ static inline void disable_ctrl_irqs(struct brcmnand_controller *ctrl) > } > > disable_irq(ctrl->irq); > - > ctrl->pio_poll_mode = true; > } > > -- > 1.9.0.138.g2de3478 >