Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp973778yba; Thu, 16 May 2019 11:58:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqxCOoBXShORcToDXfbmq0z6jhB6RPhV09B9u//fxvfxeIXhqhH0zCRkX8YL32Gcprvh6NzF X-Received: by 2002:aa7:92da:: with SMTP id k26mr10864707pfa.70.1558033117810; Thu, 16 May 2019 11:58:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558033117; cv=none; d=google.com; s=arc-20160816; b=D4om4Qdx2W4xzdTVo8XzbQ+Ia57avBwEwvNr5mOGnBGRwMGsiPkfzE7GYsRaPfF7Rs BAsFUM+yG0IoEJeUl34bXyxYduN8A8MkjxFIPyxS4BkYhOyBf8jnNU6sTBaIvLJh87j6 9J+5eocjaijFxkGlQn/T4DmlrPAzXcz775OzeosBb9mzTvmzAncwAhPJC+RczSQzR7Vl 2XmiAuR858D9YuxuMzzBHjEQqrAD981j91e8VW+8VsimaX1cG2KBI+XlHbedGrkzpm/J Q4Wj5Dr+cV35AMVp34GrjKpc+thcYYiYUtsI1R9r+EYFetHypoedJH9AqsFTzW2eTJNs midw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=AAiegTltAZt+Z5wgi7jYPMjhxUiVL7eonbcP8iKiC74=; b=fs/PEiJq09S3wHscDy+iwdBNNnmXenrlEUlao0DayZ5vJS53bUMvVQtEuDiNf+yy6q 0ShZPoKMGAVeq/KIK6QuuAlwl4CKDHh3R8vAWZ86mOzcjtDKlZfC4Me5YZYvZ7AxY7mC KgrrOE2t56j4J1oQ+ODbrPZRadSxuT8fJqF4LQzlFlSJa21mmOEYohKLfd5ZrifTpiyO Rt0xpuTZB47PVZALhrlnUZMJ5OtM/znOUZVy9R1VXV2mtEhGIBomHW0qASSYTqliytIT s+yXpXAS+dfQjYBHWMw0VxUUnw1ysrRNFW2aqC30FtqiaX1NsuVANWfkDGVV6T7ux+Fe jSsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=D3Z96axF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e4si5768819plk.304.2019.05.16.11.58.22; Thu, 16 May 2019 11:58:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=D3Z96axF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728985AbfEPSDO (ORCPT + 99 others); Thu, 16 May 2019 14:03:14 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:44716 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726520AbfEPSDO (ORCPT ); Thu, 16 May 2019 14:03:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=AAiegTltAZt+Z5wgi7jYPMjhxUiVL7eonbcP8iKiC74=; b=D3Z96axFu7Dy /BS52TeN5pF4vLfs8u+klMVykTij0V+GiSyyQ2EhAa58ppf3FLdGsPqsKB/+6MUckUqguFVen/k6B NYLWU98xL3YDED9kfYs75Km4WI5wUPknsWCYCig533FN3SNredaMMtFalzMGUpUsmHgo2iTs7pjEp cm++U=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1hRKii-00085y-WD; Thu, 16 May 2019 18:03:09 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 1F99D112929C; Thu, 16 May 2019 19:03:05 +0100 (BST) From: Mark Brown To: Axel Lin Cc: Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , Sekhar Nori Subject: Applied "regulator: tps6507x: Fix boot regression due to testing wrong init_data pointer" to the regulator tree In-Reply-To: <20190516124808.3335-1-axel.lin@ingics.com> X-Patchwork-Hint: ignore Message-Id: <20190516180305.1F99D112929C@debutante.sirena.org.uk> Date: Thu, 16 May 2019 19:03:05 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch regulator: tps6507x: Fix boot regression due to testing wrong init_data pointer has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 7d293f56456120efa97c4e18250d86d2a05ad0bd Mon Sep 17 00:00:00 2001 From: Axel Lin Date: Thu, 16 May 2019 20:48:08 +0800 Subject: [PATCH] regulator: tps6507x: Fix boot regression due to testing wrong init_data pointer A NULL init_data once incremented will lead to oops, fix it. Fixes: f979c08f7624 ("regulator: tps6507x: Convert to regulator core's simplified DT parsing code") Reported-by: Sekhar Nori Signed-off-by: Axel Lin Tested-by: Sekhar Nori Signed-off-by: Mark Brown --- drivers/regulator/tps6507x-regulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regulator.c index a1b7fab91dd4..d2a8f69b2665 100644 --- a/drivers/regulator/tps6507x-regulator.c +++ b/drivers/regulator/tps6507x-regulator.c @@ -403,12 +403,12 @@ static int tps6507x_pmic_probe(struct platform_device *pdev) /* common for all regulators */ tps->mfd = tps6507x_dev; - for (i = 0; i < TPS6507X_NUM_REGULATOR; i++, info++, init_data++) { + for (i = 0; i < TPS6507X_NUM_REGULATOR; i++, info++) { /* Register the regulators */ tps->info[i] = info; - if (init_data && init_data->driver_data) { + if (init_data && init_data[i].driver_data) { struct tps6507x_reg_platform_data *data = - init_data->driver_data; + init_data[i].driver_data; info->defdcdc_default = data->defdcdc_default; } -- 2.20.1