Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1000053yba; Thu, 16 May 2019 12:26:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqw31/YoF9a61j8joQd7+ZaXcvh1/SoljMi/FVD5JrCIOy7fYCv3L3En9iS3Itmbadw2tGuP X-Received: by 2002:a63:9214:: with SMTP id o20mr52343133pgd.203.1558034776645; Thu, 16 May 2019 12:26:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558034776; cv=none; d=google.com; s=arc-20160816; b=M7T9yfgrwjDIC0NFAuc6Kx0IqhHCwAQMETmtQ1SdEaNw7HQ+/wXhDkQyCy6aPUyeuZ zVgPkk0IOnujNO+ypEuI+YjochpGvySc/lI+Bt1LIil5tGU0hKMrg7VhovrNxGiRwxWe bRnf0kueKXKi66M2BlvS8NUEHMFu2Uxqw9RIf8/tQEf1e/OVlhqePe6Y0qL/9erZo4Hy OibSv9oeA1uW7vGvKpyF91Stp9PMJzXkYfPsERaaxumSuLCO4hKrCmonyLBH9cRG2I10 XMua+IL2NLBttFxWLLNOGRXfrAnv4oF8fWZLdq3Xa7QUDUzv8qPkaMO2h71linum/rXz wraw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:newsgroups:cc:to :subject:dkim-signature; bh=sHz+yUZyA9WPC3vWRJaY0pM1v3pT5b+Dj5gLEfS1X4o=; b=NEvmJ+5PtPGgfQWP2n/ZxDmaGdSy7XXccMQIsXNw4C+pBqSZnuj0kMCuqjsRQvSx/H 2J5WTJIR+KVYvQkxpW9KStFNkCizvbbBQLVZqnjGtNwgwZlE7WSP7fjN+kG6s8YUcdUU HyLBgmo2qN+4dxLgvtAiQAhvWCuzZee6PC2ddnwxXApGVVy9PjRbj98Ctjwq4N0nK5Sv uaRtKhSahREC3NOBns9paz6uBNdfoEshZ38g6jGDQ64K+C/Skg6iGmYXVCNQMulr8XY0 nntRfL4qaJmvNLF1slZk6CFnO/5s4C0S5b9nRasvWXhq9/Usdu9Z1gHeCtiIbWgujN5F hZKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=JexA+fMf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1si5483322pgq.4.2019.05.16.12.26.01; Thu, 16 May 2019 12:26:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=JexA+fMf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727988AbfEPS55 (ORCPT + 99 others); Thu, 16 May 2019 14:57:57 -0400 Received: from dc8-smtprelay2.synopsys.com ([198.182.47.102]:42170 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726529AbfEPS5z (ORCPT ); Thu, 16 May 2019 14:57:55 -0400 Received: from mailhost.synopsys.com (dc2-mailhost2.synopsys.com [10.12.135.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id C03D6C0B79; Thu, 16 May 2019 18:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1558033080; bh=eMQapps435bX1sogA3FMOgT5Q36SpWnVxVJXju1OYeU=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=JexA+fMfq9vIz6NINWpVPz4QGOnKX5YizM67yasSAPdbnagGLNYA6ookBOPpGbZMX +QmBSllzUWPSJwlhmzLS7IgtSU28JqSV9EQmZ1cTXi6PbTwxIP7LWTdciKvjitQHa+ GIzA91zihS4feMevWCnUg6MRUsXvy7gJawdFEqG2mpwImT7LdPHmNYbbGToQdZ8JOH 6N550S4L0PQaVvMompJo086y9wT1L1BT4P1G05Y6qSBZar6sJUQmdCm8rZ6xbqbxFm jdXCayXcpcPcm9FVVuB1yT1vGDQxQQ3d5wcM4AlX1hUz6UjzOp/QBnXfOzekUMPaKZ jmWJCLLkrJGAg== Received: from US01WXQAHTC1.internal.synopsys.com (us01wxqahtc1.internal.synopsys.com [10.12.238.230]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id 7ECD7A0098; Thu, 16 May 2019 18:57:54 +0000 (UTC) Received: from IN01WEHTCA.internal.synopsys.com (10.144.199.104) by US01WXQAHTC1.internal.synopsys.com (10.12.238.230) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 11:57:24 -0700 Received: from IN01WEHTCB.internal.synopsys.com (10.144.199.105) by IN01WEHTCA.internal.synopsys.com (10.144.199.103) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 17 May 2019 00:27:35 +0530 Received: from [10.10.161.89] (10.10.161.89) by IN01WEHTCB.internal.synopsys.com (10.144.199.243) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 17 May 2019 00:27:22 +0530 Subject: Re: [PATCH 4/9] ARC: mm: do_page_fault refactor #3: tidyup vma access permission code To: Alexey Brodkin CC: Claudiu Zissulescu , "paltsev@snyopsys.com" , "linux-kernel@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , Eugeniy Paltsev Newsgroups: gmane.linux.kernel,gmane.linux.kernel.arc References: <1557880176-24964-1-git-send-email-vgupta@synopsys.com> <1557880176-24964-5-git-send-email-vgupta@synopsys.com> <1558027448.2682.11.camel@synopsys.com> From: Vineet Gupta Openpgp: preference=signencrypt Autocrypt: addr=vgupta@synopsys.com; keydata= mQINBFEffBMBEADIXSn0fEQcM8GPYFZyvBrY8456hGplRnLLFimPi/BBGFA24IR+B/Vh/EFk B5LAyKuPEEbR3WSVB1x7TovwEErPWKmhHFbyugdCKDv7qWVj7pOB+vqycTG3i16eixB69row lDkZ2RQyy1i/wOtHt8Kr69V9aMOIVIlBNjx5vNOjxfOLux3C0SRl1veA8sdkoSACY3McOqJ8 zR8q1mZDRHCfz+aNxgmVIVFN2JY29zBNOeCzNL1b6ndjU73whH/1hd9YMx2Sp149T8MBpkuQ cFYUPYm8Mn0dQ5PHAide+D3iKCHMupX0ux1Y6g7Ym9jhVtxq3OdUI5I5vsED7NgV9c8++baM 7j7ext5v0l8UeulHfj4LglTaJIvwbUrCGgtyS9haKlUHbmey/af1j0sTrGxZs1ky1cTX7yeF nSYs12GRiVZkh/Pf3nRLkjV+kH++ZtR1GZLqwamiYZhAHjo1Vzyl50JT9EuX07/XTyq/Bx6E dcJWr79ZphJ+mR2HrMdvZo3VSpXEgjROpYlD4GKUApFxW6RrZkvMzuR2bqi48FThXKhFXJBd JiTfiO8tpXaHg/yh/V9vNQqdu7KmZIuZ0EdeZHoXe+8lxoNyQPcPSj7LcmE6gONJR8ZqAzyk F5voeRIy005ZmJJ3VOH3Gw6Gz49LVy7Kz72yo1IPHZJNpSV5xwARAQABtCpWaW5lZXQgR3Vw dGEgKGFsaWFzKSA8dmd1cHRhQHN5bm9wc3lzLmNvbT6JAj4EEwECACgCGwMGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheABQJbBYpwBQkLx0HcAAoJEGnX8d3iisJeChAQAMR2UVbJyydOv3aV jmqP47gVFq4Qml1weP5z6czl1I8n37bIhdW0/lV2Zll+yU1YGpMgdDTHiDqnGWi4pJeu4+c5 xsI/VqkH6WWXpfruhDsbJ3IJQ46//jb79ogjm6VVeGlOOYxx/G/RUUXZ12+CMPQo7Bv+Jb+t NJnYXYMND2Dlr2TiRahFeeQo8uFbeEdJGDsSIbkOV0jzrYUAPeBwdN8N0eOB19KUgPqPAC4W HCg2LJ/o6/BImN7bhEFDFu7gTT0nqFVZNXlOw4UcGGpM3dq/qu8ZgRE0turY9SsjKsJYKvg4 djAaOh7H9NJK72JOjUhXY/sMBwW5vnNwFyXCB5t4ZcNxStoxrMtyf35synJVinFy6wCzH3eJ XYNfFsv4gjF3l9VYmGEJeI8JG/ljYQVjsQxcrU1lf8lfARuNkleUL8Y3rtxn6eZVtAlJE8q2 hBgu/RUj79BKnWEPFmxfKsaj8of+5wubTkP0I5tXh0akKZlVwQ3lbDdHxznejcVCwyjXBSny d0+qKIXX1eMh0/5sDYM06/B34rQyq9HZVVPRHdvsfwCU0s3G+5Fai02mK68okr8TECOzqZtG cuQmkAeegdY70Bpzfbwxo45WWQq8dSRURA7KDeY5LutMphQPIP2syqgIaiEatHgwetyVCOt6 tf3ClCidHNaGky9KcNSQuQINBFEffBMBEADXZ2pWw4Regpfw+V+Vr6tvZFRl245PV9rWFU72 xNuvZKq/WE3xMu+ZE7l2JKpSjrEoeOHejtT0cILeQ/Yhf2t2xAlrBLlGOMmMYKK/K0Dc2zf0 MiPRbW/NCivMbGRZdhAAMx1bpVhInKjU/6/4mT7gcE57Ep0tl3HBfpxCK8RRlZc3v8BHOaEf cWSQD7QNTZK/kYJo+Oyux+fzyM5TTuKAaVE63NHCgWtFglH2vt2IyJ1XoPkAMueLXay6enSK Nci7qAG2UwicyVDCK9AtEub+ps8NakkeqdSkDRp5tQldJbfDaMXuWxJuPjfSojHIAbFqP6Qa ANXvTCSuBgkmGZ58skeNopasrJA4z7OsKRUBvAnharU82HGemtIa4Z83zotOGNdaBBOHNN2M HyfGLm+kEoccQheH+my8GtbH1a8eRBtxlk4c02ONkq1Vg1EbIzvgi4a56SrENFx4+4sZcm8o ItShAoKGIE/UCkj/jPlWqOcM/QIqJ2bR8hjBny83ONRf2O9nJuEYw9vZAPFViPwWG8tZ7J+R euXKai4DDr+8oFOi/40mIDe/Bat3ftyd+94Z1RxDCngd3Q85bw13t2ttNLw5eHufLIpoEyAh TCLNQ58eT91YGVGvFs39IuH0b8ovVvdkKGInCT59Vr0MtfgcsqpDxWQXJXYZYTFHd3/RswAR AQABiQIlBBgBAgAPAhsMBQJbBYpwBQkLx0HdAAoJEGnX8d3iisJewe8P/36pkZrVTfO+U+Gl 1OQh4m6weozuI8Y98/DHLMxEujKAmRzy+zMHYlIl3WgSih1UMOZ7U84yVZQwXQkLItcwXoih ChKD5D2BKnZYEOLM+7f9DuJuWhXpee80aNPzEaubBYQ7dYt8rcmB7SdRz/yZq3lALOrF/zb6 SRleBh0DiBLP/jKUV74UAYV3OYEDHN9blvhWUEFFE0Z+j96M4/kuRdxvbDmp04Nfx79AmJEn fv1Vvc9CFiWVbBrNPKomIN+JV7a7m2lhbfhlLpUk0zGFDTWcWejl4qz/pCYSoIUU4r/VBsCV ZrOun4vd4cSi/yYJRY4kaAJGCL5k7qhflL2tgldUs+wERH8ZCzimWVDBzHTBojz0Ff3w2+gY 6FUbAJBrBZANkymPpdAB/lTsl8D2ZRWyy90f4VVc8LB/QIWY/GiS2towRXQBjHOfkUB1JiEX YH/i93k71mCaKfzKGXTVxObU2I441w7r4vtNlu0sADRHCMUqHmkpkjV1YbnYPvBPFrDBS1V9 OfD9SutXeDjJYe3N+WaLRp3T3x7fYVnkfjQIjDSOdyPWlTzqQv0I3YlUk7KjFrh1rxtrpoYS IQKf5HuMowUNtjyiK2VhA5V2XDqd+ZUT3RqfAPf3Y5HjkhKJRqoIDggUKMUKmXaxCkPGi91T hhqBJlyU6MVUa6vZNv8E Message-ID: Date: Thu, 16 May 2019 11:57:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.89] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/16/19 10:44 AM, Alexey Brodkin wrote: >> On 5/16/19 10:24 AM, Eugeniy Paltsev wrote: >>>> + unsigned int write = 0, exec = 0, mask; >>> Probably it's better to use 'bool' type for 'write' and 'exec' as we really use them as a boolean >> variables. >> >> Right those are semantics, but the generated code for "bool" is not ideal - given >> it is inherently a "char" it is promoted first to an int with an additional EXTB >> which I really dislike. >> Guess it is more of a style thing. > > In that sense maybe think about re-definition of "bool" type to 32-bit one > for entire architecture and get that benefit across the entire source tree? what bool maps to is driven by the ABI and while not explicit in the ARCv2 ABI doc, I guess it is byte and hence can't be changed just like that. -Vineet